https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-05-31T23:24:01ZRedmineRedmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=789062017-05-31T23:24:01ZMischa The Evil
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Feature</i></li><li><strong>Subject</strong> changed from <i>Allow custom fields to appear in search results like Description</i> to <i>Allow custom fields to appear in the issue list like 'Description' (as an inline column)</i></li></ul><p>jb cbdse wrote:</p>
<blockquote>
<p>[...]<br />I don't believe that patch will add the feature I am looking for.</p>
</blockquote>
<p>Indeed. That feature does not include the addition of the ability to render custom fields as inline columns.</p> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=789172017-06-01T14:54:17Zjb cbdse
<ul><li><strong>File</strong> <a href="/attachments/18439">26081.patch.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18439/26081.patch.txt">26081.patch.txt</a> added</li></ul><p>Here's the patch we did on 3.3.3.</p>
<p>Mashing 'description' onto the css classes of custom fields is not ideal, but it got the job done.</p>
<p>I can't test against trunk. I haven't been able to get a checkout of trunk working.</p> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=789282017-06-01T19:06:37ZMischa The Evil
<ul><li><strong>Subject</strong> changed from <i>Allow custom fields to appear in the issue list like 'Description' (as an inline column)</i> to <i>Allow long-text custom fields to appear in the issue list like 'Description' (as a block column)</i></li></ul><p>Thanks for sharing your patch.</p>
<p>jb cbdse wrote:</p>
<blockquote>
<p>Mashing 'description' onto the css classes of custom fields is not ideal, but it got the job done.</p>
</blockquote>
<p>It is indeed far from ideal and certainly not (yet) ready for integration. It also misses the correct rendering of the values using a <code>div.wiki</code> element to wrap the <code>p</code> element. This <em>can</em> (and probably will) cause problems rendering formatted values (especially thinking about syntax highlighting here).</p>
<p>jb cbdse wrote:</p>
<blockquote>
<p>I can't test against trunk. [...]</p>
</blockquote>
<p>The patch will need some modifications (in line with <a class="changeset" title="Show Last Comment in Issue list (#1474). Patch by Marius BALTEANU." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16367">r16367</a> for <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Show last comment/notes in the issue list (Closed)" href="https://www.redmine.org/issues/1474">#1474</a>) for trunk compatibility.</p>
<p>I have been pondering about this feature for some time, and I think it could be a nice improvement on top of <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Option for long text custom fields to be displayed using full width (Closed)" href="https://www.redmine.org/issues/21705">#21705</a>. I'll explain. With <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Option for long text custom fields to be displayed using full width (Closed)" href="https://www.redmine.org/issues/21705">#21705</a>, full_width_layout long-text custom field columns are still rendered as inline columns while the content they'll hold would be presumed to render with a full-width layout. This can make the values hard to read and — as such — the (inline) column not-very usable. If we have <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Option for long text custom fields to be displayed using full width (Closed)" href="https://www.redmine.org/issues/21705">#21705</a> extended in such a way that it'll render full_width_layout long-text custom field columns as block columns, it might improve the usability of it. I'll ping the author of <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Option for long text custom fields to be displayed using full width (Closed)" href="https://www.redmine.org/issues/21705">#21705</a> (and also <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Show last comment/notes in the issue list (Closed)" href="https://www.redmine.org/issues/1474">#1474</a>) to get his opinion on this FR.<br />For the above, TS's patch should be modified to also check on <code>custom_field.full_width_layout?</code> (like <code>if custom_field.field_format == "text" && custom_field.full_width_layout? ...</code>).</p>
<p>PS: I have modified the subject to match the terminology of the Redmine code base (the reciprocal of inline) and to precise the request itself.</p> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=789302017-06-01T19:07:07ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/21705">Patch #21705</a>: Option for long text custom fields to be displayed using full width</i> added</li></ul> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=789322017-06-01T19:23:17ZMischa The Evil
<ul></ul><p>Note: TS's patch also changes the custom fields' column on the timelog views, which might not be desired and/or expected.</p> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=789402017-06-01T21:39:31Zjb cbdse
<ul></ul><p>Thanks for the feedback. Yeah, I figured someone would know a lot more than me, but I was glad to be able to prove the concept. We ended up changing the <h3> in that patch to something smaller and italicized. We ended up hard-coding something to omit it for the stock 'description' field. When it was big and bold, it looked bad in queries with 'group' criteria - the group headings got lost. I still think it needs a label, but it needs to be relatively unemphasized.</p>
<p>Yes, I agree that basing it off of full_width_layout would be better. There's a "multi column custom fields" plugin, and I originally based it off of the multi_column attribute that it added, but I didn't want to depend on the plugin logic. So, I totally agree about the new field from <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Option for long text custom fields to be displayed using full width (Closed)" href="https://www.redmine.org/issues/21705">#21705</a>. Ruby's not my thing, but I might revisit this later if I can get trunk working.</p> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=789822017-06-02T09:12:19ZMischa The Evil
<ul><li><strong>Subject</strong> changed from <i>Allow long-text custom fields to appear in the issue list like 'Description' (as a block column)</i> to <i>Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)</i></li></ul><p>jb cbdse wrote:</p>
<blockquote>
<p>Yes, I agree that basing it off of full_width_layout would be better.</p>
</blockquote>
<p>I'll modify the issue subject accordingly.</p> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=881522018-10-28T21:12:09ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li></ul> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=897902019-02-03T19:46:04ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/22347">0001-Show-full-width-layout-custom-fields-as-block-column.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22347/0001-Show-full-width-layout-custom-fields-as-block-column.patch">0001-Show-full-width-layout-custom-fields-as-block-column.patch</a> added</li><li><strong>File</strong> <a href="/attachments/22346">0002-Styles-for-block-column-name.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22346/0002-Styles-for-block-column-name.patch">0002-Styles-for-block-column-name.patch</a> added</li><li><strong>File</strong> <a href="/attachments/22348">block_columns.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22348/block_columns.png">block_columns.png</a> added</li></ul><p>Attached two patches:<br />1. <a class="attachment" href="https://www.redmine.org/attachments/22347">0001-Show-full-width-layout-custom-fields-as-block-column.patch</a> which implements this feature.<br />2. <a class="attachment" href="https://www.redmine.org/attachments/22346">0002-Styles-for-block-column-name.patch</a> which is optional and adds some styles to the block column names in order to make them more obvious for users:<br /><img src="https://www.redmine.org/attachments/download/22348/block_columns.png" style="width:80%;border: 1px solid grey;margin-top: 2px;" alt="" /></p>
<p>Tests pass: <a class="external" href="https://gitlab.com/marius-balteanu/redmine/-/jobs/155542640">https://gitlab.com/marius-balteanu/redmine/-/jobs/155542640</a></p> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=897922019-02-03T21:13:43ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=900642019-02-12T07:56:00ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=901002019-02-13T14:08:04ZGo MAEDA
<ul><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you for contributing the patches.</p> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=901142019-02-14T04:15:52ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=956262020-01-10T16:52:01ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32768">Defect #32768</a>: Internal Error when issue text custom field is shown in Spent time query results</i> added</li></ul> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=958562020-01-25T10:13:32ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32859">Defect #32859</a>: Issue list: long text custom field missing in PDF export</i> added</li></ul> Redmine - Feature #26081: Allow full_width_layout long-text custom fields to appear in the issue list like 'Description' (as a block column)https://www.redmine.org/issues/26081?journal_id=968272020-03-18T09:39:40ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/33169">Defect #33169</a>: Issues CSV export does not include custom fields with "Full width layout" enabled</i> added</li></ul>