Feature #2610

Git repository comments should use git convention for commit messages

Added by Mattias Holm almost 9 years ago. Updated over 5 years ago.

Status:ClosedStart date:2009-01-28
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:-
Resolution:Wont fix

Description

Git is typically used with the convention that commit messages are written with a short one line subject and then a more descriptive paragraph.

Redmine however display the entire message in the comment field. In the repository overview this is OK, since linefeeds are added after the subject as specified in the commit-message. However, for the activity view, the entire message is displayed as one line (no line feeds where they are supposed to be), this means that many comments are unreadable.

I suggest that for git, firstly in the issue lists, only the first line should be displayed and that in the activity view, the commit message will be displayed with its first line following the revision and the message below should only contain the body of the message.


Related issues

Related to Redmine - Feature #6092: Truncate Git revision labels in Activity page/feed and al... Closed 2010-08-09

History

#1 Updated by Jean-Philippe Lang almost 9 years ago

  • Tracker changed from Defect to Feature

#2 Updated by Gerrit Kaiser almost 9 years ago

+1

#3 Updated by Karsten Dambekalns over 7 years ago

+1 from me as well. And this doesn't apply to git only, it purely is a question of commit message style...

#4 Updated by Felix Schäfer over 7 years ago

The activity list already only shows the first line of the commit message. What other places would you think need improvement?

#5 Updated by Mattias Holm over 7 years ago

Felix Schäfer wrote:

The activity list already only shows the first line of the commit message. What other places would you think need improvement?

In the repository view, the file browser shows parts of the commit message truncated to some length. This comment shows not just the first line, but also the rest of the message (with the line feeds stripped).

Also in the repository view, the latest commit browser, shows the messages, with line feeds, but multiple linefeeds (new paragraphs) are ignored and concatenated to one big paragraph. It also does not clearly label the first line as being the subject.

My preferred solution would be to have the file browser in the repository view to only show the first line and the commit browser respect the linefeeds in the commit message plus labelling the first line (bold font or something like that), as a subject line for the commit.

#6 Updated by Toshi MARUYAMA over 6 years ago

  • Status changed from New to Closed
  • Resolution set to Wont fix

#6092 changed 8 chars for git revision in feed and activity.
So, this issue is obsolete.

Also available in: Atom PDF