https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292009-01-31T10:04:22ZRedmineRedmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=70232009-01-31T10:04:22ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><blockquote>
<p>Re-submitting the form fails because Redmine is using the stale lock and not a fresh one.</p>
</blockquote>
<p>It prevents user B from overwriting user A's changes by simply re-submitting the form.<br />Surely, it's a poor design but it's not a defect.</p> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=70242009-01-31T10:04:26ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Tracker</strong> changed from <i>Defect</i> to <i>Feature</i></li></ul> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=70792009-02-03T00:00:57ZEric Davis
<ul></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
<p>It prevents user B from overwriting user A's changes by simply re-submitting the form.<br />Surely, it's a poor design but it's not a defect.</p>
</blockquote>
<p>It puts the user into a position where they either lose their data or have to copy and paste it all into a new browser tab, hence the defect. If you look the form when there is a conflict, there is a hidden field for lock_version that is the stale lock. So at that point, the user cannot ever submit the form, even if they reconcile the differences. If the error is going to be handled by displaying a form, then the form should be functional.</p> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=128372009-12-09T00:16:21ZEric Davis
<ul><li><strong>File</strong> <a href="/attachments/2882">stale-error-messages.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2882/stale-error-messages.png">stale-error-messages.png</a> added</li><li><strong>Target version</strong> set to <i>0.9.0</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>0</i></li></ul><p>I've attached a patch to fix thi, I've ran into it many times and every time I lose data. This patch fixes several things and makes the user interface more friendly (I hope):</p>
<ul>
<li>When a conflict occurs, the user can submit their change</li>
<li>The conflicting fields are shown to the user (in Red)</li>
<li>File attachments that failed are saved and re-associated (this reverts the fix in <a class="changeset" title="Fixed: issue attachments are saved even if the issue has been updated by another user (#3846)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/2875">r2875</a> / <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: issue edit accepts attachment even if the change is rejected because the issue has been updated b... (Closed)" href="https://www.redmine.org/issues/3846">#3846</a>. If the user just spent a bunch of time to upload a large file, deleting it could make them unhappy).</li>
</ul>
<p>I'm ready to commit this fix if it looks good.</p>
<p>Here's a screenshot of what the user would see if a conflict occurred.</p>
<p><img src="https://www.redmine.org/attachments/download/2882/stale-error-messages.png" alt="" /></p> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=128382009-12-09T00:18:10ZEric Davis
<ul><li><strong>File</strong> <a href="/attachments/2883">0001-Handle-the-StaleObjectError-when-two-users-edit-the-.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2883/0001-Handle-the-StaleObjectError-when-two-users-edit-the-.patch">0001-Handle-the-StaleObjectError-when-two-users-edit-the-.patch</a> added</li></ul> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=128392009-12-09T00:24:38ZRobert Chady
<ul></ul><p>It does not appear to list any journal entries that accompany the updates. Could you include the journal entries that go with the changes so the user has all the information available to them?</p> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=132202009-12-23T20:08:24ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> changed from <i>0.9.0</i> to <i>1.0.0 (RC)</i></li></ul><p>I prefer that we take some time before this gets added to a stable branch.<br />And it's a bit late for 0.9.</p> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=174762010-06-19T18:53:54ZAlexey Palazhchenko
<ul></ul><p>Part of BugMash 1.0…</p> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=178192010-06-30T01:04:38ZEric Davis
<ul><li><strong>Priority</strong> changed from <i>High</i> to <i>Normal</i></li><li><strong>Target version</strong> changed from <i>1.0.0 (RC)</i> to <i>1.1.0</i></li></ul><p>Pushing to a later release. If I can get me some more feedback on the UI I can update the patch.</p> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=217862010-10-25T15:04:14ZEric Davis
<ul><li><strong>Assignee</strong> deleted (<del><i>Eric Davis</i></del>)</li></ul> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=232912010-12-18T13:48:39ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> changed from <i>1.1.0</i> to <i>Unplanned backlogs</i></li></ul><p>1.1 feature freeze.</p> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=278862011-04-14T09:56:01ZEtienne Massip
<ul><li><strong>Target version</strong> changed from <i>Unplanned backlogs</i> to <i>Candidate for next major release</i></li></ul> Redmine - Feature #2621: Errors when editing an issue that was just edited - StaleObjectErrorhttps://www.redmine.org/issues/2621?journal_id=358132012-02-04T17:58:35ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>7</i> to <i>Closed</i></li><li><strong>Target version</strong> deleted (<del><i>Candidate for next major release</i></del>)</li><li><strong>Resolution</strong> set to <i>Duplicate</i></li></ul><p>Superseded by <a class="issue tracker-2 status-5 priority-5 priority-high2 closed" title="Feature: Better handling of issue update conflict (Closed)" href="https://www.redmine.org/issues/8691">#8691</a> which is fixed for 1.4.0.</p>