https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292017-07-07T18:26:02ZRedmineRedmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=798372017-07-07T18:26:02ZPavel Rosický
<ul></ul><p>you can disable imagemagick and then you won't be able to resize thumbnails<br /><pre>
bundle install --without rmagick
</pre></p> Redmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=798632017-07-08T08:03:16ZGo MAEDA
<ul></ul><p>Gabriel Cardoso wrote:</p>
<blockquote>
<p>In the `thumbnail_tag` helper from `ApplicationHelper`, the width attribute is set width `Setting.thumbnails_size`. I suggest to remove this attribute from the image tag since the source thumbnail has the right size.</p>
</blockquote>
<p>The width attribute is workaround for strange behavior of Firefox. Please see <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Render high resolution Gravatars and Thumbnails (Closed)" href="https://www.redmine.org/issues/24927#note-6">#24927#note-6</a> and <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Render high resolution Gravatars and Thumbnails (Closed)" href="https://www.redmine.org/issues/24927#note-8">#24927#note-8</a> for details.</p> Redmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=798642017-07-08T08:10:30ZGo MAEDA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Defect</i></li><li><strong>Affected version</strong> set to <i>3.4.0</i></li></ul> Redmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=798652017-07-08T08:21:50ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/18703">26379-3_3@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18703/26379-3_3@2x.png">26379-3_3@2x.png</a> added</li><li><strong>File</strong> <a href="/attachments/18704">26379-3_4@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18704/26379-3_4@2x.png">26379-3_4@2x.png</a> added</li></ul><p>Redmine 3.3 (displayed with 25px * 100px):<br /><img src="https://www.redmine.org/attachments/download/18703/26379-3_3@2x.png" srcset="https://www.redmine.org/attachments/download/18703/26379-3_3@2x.png 2x" style="width: 480px;border: 1px solid #ccc;" alt="" /></p>
<p>Redmine 3.4 (displayed with 100px * 392px):<br /><img src="https://www.redmine.org/attachments/download/18704/26379-3_4@2x.png" srcset="https://www.redmine.org/attachments/download/18704/26379-3_4@2x.png 2x" style="width: 480px;border: 1px solid #ccc;" alt="" /></p> Redmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=798932017-07-09T06:41:17ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/18707">defect-26379.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/18707/defect-26379.diff">defect-26379.diff</a> added</li><li><strong>Target version</strong> set to <i>3.4.1</i></li></ul><p>Here is a patch to fix this issue.<br />Thumbnails are displayed in the same way as in Redmine 3.3 if the patch applied.</p> Redmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=798952017-07-09T07:16:10ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> changed from <i>3.4.1</i> to <i>3.4.2</i></li></ul><p>Waiting for some feedback before merging it.</p> Redmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=799192017-07-10T08:29:24ZGabriel Cardoso
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li></ul><p>Perfect ! Thank you !</p>
<p>Indeed, your approach is better and solve the proble. Hope it doesn't break <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Render high resolution Gravatars and Thumbnails (Closed)" href="https://www.redmine.org/issues/24927#note-6">#24927#note-6</a> and <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Render high resolution Gravatars and Thumbnails (Closed)" href="https://www.redmine.org/issues/24927#note-8">#24927#note-8</a> on Firefox</p> Redmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=799232017-07-10T08:59:13ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Confirmed</i></li></ul><p>Gabriel Cardoso wrote:</p>
<blockquote>
<p>Indeed, your approach is better and solve the proble. Hope it doesn't break <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Render high resolution Gravatars and Thumbnails (Closed)" href="https://www.redmine.org/issues/24927#note-6">#24927#note-6</a> and <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Render high resolution Gravatars and Thumbnails (Closed)" href="https://www.redmine.org/issues/24927#note-8">#24927#note-8</a> on Firefox</p>
</blockquote>
<p>No problem. Setting both <code>max-width</code> and <code>max-height</code> resolved <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Render high resolution Gravatars and Thumbnails (Closed)" href="https://www.redmine.org/issues/24927#note-6">#24927#note-6</a>.<br />Thank you for your feedback!</p>
<hr />
<p>"Resolved" status is used by core developers, I am setting the status to "Confirmed".</p> Redmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=799362017-07-10T21:19:38ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Fix thumbnail rendering</i> to <i>Fix thumbnail rendering for images with height >> width</i></li><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Patch committed, thanks.</p> Redmine - Defect #26379: Fix thumbnail rendering for images with height >> widthhttps://www.redmine.org/issues/26379?journal_id=800682017-07-16T11:49:29ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>