Patch #2641

other-formats paragraph location is inconsistent

Added by Brad Beattie over 8 years ago. Updated over 8 years ago.

Status:NewStart date:2009-02-02
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

50%

Category:UIEstimated time:0.20 hour
Target version:-

Description

On an issue view page, the other-formats paragraph appears at the bottom of the page, just above the footer through use of

<div style="clear: both;"/>

On other pages, the other-formats paragraph appears simply as the last element in the #content div.

It doesn't really matter to me which one is used, but I figured consistency would be good, yeah? The following patch puts all at the bottom through use of relative absolute positioning with the #content div and, consequently, removes the single instance of the clear div.

### Eclipse Workspace Patch 1.0
#P Redmine
Index: app/views/issues/show.rhtml
===================================================================
--- app/views/issues/show.rhtml    (revision 2338)
+++ app/views/issues/show.rhtml    (working copy)
@@ -99,7 +99,6 @@
 <%= render :partial => 'history', :locals => { :journals => @journals } %>
 </div>
 <% end %>
-<div style="clear: both;"></div>

 <% if authorize_for('issues', 'edit') %>
   <div id="update" style="display:none;">
Index: public/stylesheets/application.css
===================================================================
--- public/stylesheets/application.css    (revision 2352)
+++ public/stylesheets/application.css    (working copy)
@@ -55,7 +55,7 @@
 #sidebar hr{ width: 100%; margin: 0 auto; height: 1px; background: #ccc; border: 0; }
 * html #sidebar hr{ width: 95%; position: relative; left: -6px; color: #ccc; }

-#content { width: 80%; background-color: #fff; margin: 0px; border-right: 1px solid #ddd; padding: 6px 10px 10px 10px; z-index: 10; }
+#content { width: 80%; background-color: #fff; margin: 0px; border-right: 1px solid #ddd; padding: 6px 10px 10px 10px; z-index: 10; position: relative; }
 * html #content{ width: 80%; padding-left: 0; margin-top: 0px; padding: 6px 10px 10px 10px;}
 html>body #content { min-height: 600px; } 
 * html body #content { height: 600px; } /* IE */
@@ -308,7 +308,7 @@
 div.attachments img { vertical-align: middle; }
 div.attachments span.author { font-size: 0.9em; color: #888; }

-p.other-formats { text-align: right; font-size:0.9em; color: #666; }
+p.other-formats { text-align: right; font-size:0.9em; color: #666; position: absolute; bottom: 0; right: 1em; }
 .other-formats span + span:before { content: "| "; }

 a.atom { background: url(../images/feed.png) no-repeat 1px 50%; padding: 2px 0px 3px 16px; }

History

#1 Updated by Brad Beattie over 8 years ago

  • Assignee set to Jean-Philippe Lang

Also available in: Atom PDF