Patch #26522
Repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | SCM | |||
| Target version: | 4.0.0 |
Description
If the first component of a path in a repository equals one of the strings above, the wrong route gets selected in the case of links without repository_id (as they are generated from wiki source: links to the default repository of a project) and the intended action is mistaken for the repository_id parameter. Attached is a patch to the repository routing test illustrating the issue.
I would suggest to change repository#identifier_param to always return an identifier (see second patch) and remove the repository routes without repository_id (rows 280ff in current config/routes.rb).
repository_routing_test.patch 
- illustrates failure of route for certain path
(555 Bytes)
repository_identifier_param.patch
- always return a repository identifier
(381 Bytes)
Associated revisions
Removes repository routes without repository_id (#26522).
History
#1
Updated by Toshi MARUYAMA over 1 year ago
- Target version set to 4.0.0
#2
Updated by Jean-Philippe Lang 5 months ago
- Subject changed from repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/ to Repository routing bug when file path starts with (browse|entry|raw|changes|annotate|diff)/
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
Routes without repository_id are removed.