Patch #27024

Links on custom field values don't have "external" class

Added by Go MAEDA 2 months ago. Updated about 1 month ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Custom fields
Target version:4.1.0

Description

Textile and Markdown formatter in Redmine adds "external" class to a element when rendering links to an external site. Here is an exmaple:

Textile:

"Redmine":http://www.redmine.org/

Rendered HTML:

<a class="external" href="http://www.redmine.org/">

Although those formatters adds "external" class like as above, links on custom field values, which can be configured in "Link values to URL" of custom fields, don't have "external" class. I am in trouble with this behavior because I use UI theme that provides JavaScript code which opens external link in a new browser window (please see https://github.com/farend/redmine_theme_farend_basic/blob/master/javascripts/theme.js#L3).

I think that links on custom field should have "external" class for consistency and convenience. Attaching a patch to fix this.

add-external-class-to-cf-link.diff Magnifier (10.7 KB) Go MAEDA, 2017-09-18 16:57

History

#1 Updated by Go MAEDA 2 months ago

  • File deleted (add-external-class-to-cf-link.diff)

#2 Updated by Go MAEDA 2 months ago

Sorry, replaced the patch. The previous patch contained irrelevant codes.

#3 Updated by Toshi MARUYAMA about 1 month ago

  • Target version set to 4.1.0

Also available in: Atom PDF