Patch #27025

Regex support for excluded mail attachments

Added by Jan from Planio www.plan.io about 1 year ago. Updated 10 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Email receiving
Target version:4.0.0

Description

Now that we have regex support for mail body delimiters, it makes sense to allow regex parsing for excluded attachment filenames as well.

The common case are email signatures including images. In many cases, the filenames include something like footer or signature, so regexes like the following proved to be quite useful for us at Planio:

smime.p7s,.+\.vcf,.*(footer|signature).*\.(gif|jpg|jpeg|png)

The attached patch series implements this feature.

0002-Whitespace-only.patch Magnifier (2.38 KB) Jan from Planio www.plan.io, 2017-09-18 19:41

0001-Optional-regex-for-filtering-attachments-on-incoming.patch Magnifier (6.04 KB) Jan from Planio www.plan.io, 2017-09-18 19:41

0004-Improve-German-translation-for-mail-handler-regex-se.patch Magnifier (2.17 KB) Jan from Planio www.plan.io, 2017-09-18 19:41

0003-Rename-setting_mail_handler_enable_regex_delimiters-.patch Magnifier (35.3 KB) Jan from Planio www.plan.io, 2017-09-18 19:41


Related issues

Blocks Redmine - Patch #28279: Change German translation for not_a_regexp and setting_ma... Closed

Associated revisions

Revision 17225
Added by Go MAEDA 10 months ago

Optional regex for filtering attachments on incoming emails (#27025).

Patch by Jan Schulz-Hofen.

Revision 17226
Added by Go MAEDA 10 months ago

Fix indent (#27025).

Patch by Jan Schulz-Hofen.

Revision 17227
Added by Go MAEDA 10 months ago

Rename :setting_mail_handler_enable_regex_delimiters i18n string to :setting_mail_handler_enable_regex (#27025).

Patch by Jan Schulz-Hofen.

History

#1 Updated by Marius BALTEANU about 1 year ago

Very useful feature.

#2 Updated by Toshi MARUYAMA about 1 year ago

  • Target version changed from Candidate for next minor release to 4.1.0

LGTM.

#3 Updated by Go MAEDA 10 months ago

  • Blocks Patch #28279: Change German translation for not_a_regexp and setting_mail_handler_enable_regex added

#4 Updated by Go MAEDA 10 months ago

The series of patches make "Incoming emails" settings page more consistent.

#5 Updated by Go MAEDA 10 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0

Committed the patch 0001, 0002 and 0003. I will commit the patch 0004 as another issue (#28279).

Thank you for contributing the patches.

Also available in: Atom PDF