Patch #27240

Render the activities block on the UsersController#show view grouped, with event_type icon and with the 'me' indication

Added by Mischa The Evil about 1 month ago. Updated about 1 month ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:4.1.0

Description

The activities block on the UsersController#show view is currently missing three things:
  • the grouping as introduced via #12542 for the general activities view(s);
  • the event_type icon, as it is used for the general activities view(s);
  • the indication of events that were authored by 'me', as it is used for the general activities view(s).

The attached patch fixes these inconsistencies and makes the rendering of the activities block on the UsersController#show view the same as it is for the general activities view(s). See the following screenshots:

Screenshots:
Before:
After:

The patch, against source:/trunk@16967, is produced using git format-patch which makes it apply-able using "patch -p1 < 0001-...".

Environment:

Environment:
  Redmine version                3.4.2.devel@r16967
  Ruby version                   2.3.3-p222 (2016-11-21) [x86_64-linux]
  Rails version                  5.1.2
  Environment                    production
  Database adapter               Mysql2
SCM:
  Subversion                     1.8.8
  Git                            1.9.1
  Filesystem                     
Redmine plugins:
  no plugin installed

before.png (16.9 KB) Mischa The Evil, 2017-10-20 16:11

after.png (20.4 KB) Mischa The Evil, 2017-10-20 16:11

0001-Render-activities-block-on-UsersController-show-grou.patch Magnifier (2 KB) Mischa The Evil, 2017-10-20 16:17


Related issues

Related to Redmine - Feature #12542: Group events in the activity view Closed

History

#1 Updated by Go MAEDA about 1 month ago

  • Target version set to 4.1.0

It looks good. I am setting target version to 4.1.0.
Thank you for the patch.

#2 Updated by Mischa The Evil 29 days ago

Also available in: Atom PDF