Patch #27807

Use a unique way to check/uncheck a group/fieldset with checkboxes

Added by Marius BALTEANU 4 months ago. Updated about 1 month ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:4.1.0

Description

Currently, there are 2 ways to check/uncheck a group/fieldset with checkboxes:

1. Using the green tick icon in screens like:
- New member modal
- Workflow, tab Status transitions

2. Using the explicit links "Check All/Uncheck All" in screens like
- New tracker form
- New custom field form

These 2 patches propose to replace the explicit links from the above mentioned screens (point 2) with the toggle feature.

In this way, will have a unique and consistent way to check/uncheck a group of checkboxes across the application.

I chose to use the version with the green tick because it requires less space than the explicit links and it fits better.
I'm not saying that the green tick is the best option, but this is an ongoing discussion (#27678).

0005-replace-check_all_links-in-new-tracker-form-with-too.patch Magnifier (1.25 KB) Marius BALTEANU, 2017-12-16 11:04

0006-replace-check_all_links-in-new-custom-field-form-wit.patch Magnifier (2.06 KB) Marius BALTEANU, 2017-12-16 11:04

Screen Shot 2017-12-16 at 12.05.42.png (53 KB) Marius BALTEANU, 2017-12-16 11:08

Screen Shot 2017-12-16 at 12.05.54.png (74.2 KB) Marius BALTEANU, 2017-12-16 11:08


Related issues

Related to Redmine - Patch #27678: Make "Check all / Uncheck all" link noticeable New
Related to Redmine - Defect #28079: The green tick is positioned after the label in the new m... Closed
Related to Redmine - Patch #28242: Add toggle checkboxes link (green tick) to several screens Closed

History

#1 Updated by Marius BALTEANU 4 months ago

  • Tracker changed from Defect to Patch

#2 Updated by Marius BALTEANU 4 months ago

Some screenshots

#3 Updated by Marius BALTEANU 4 months ago

  • Related to Patch #27678: Make "Check all / Uncheck all" link noticeable added

#4 Updated by Mizuki ISHIKAWA 3 months ago

+1
I think that this change will improve usability.

#5 Updated by Marius BALTEANU 3 months ago

  • Related to Defect #28079: The green tick is positioned after the label in the new member modals added

#6 Updated by Marius BALTEANU about 1 month ago

I'm removing patches 0007 and 0008 because were committed in #28079.

#7 Updated by Marius BALTEANU about 1 month ago

  • File deleted (0007-use-regular-icon-icon-checked-classes.patch)

#8 Updated by Marius BALTEANU about 1 month ago

  • File deleted (0008-fix-icon-position-in-new-member-modal.patch)

#9 Updated by Go MAEDA about 1 month ago

I agree to fix the problem that green tick icons are missing on some pages.

But I am worried that patch 0005 and 0006, which delete existing UI elements, may cause confusion for users because the green tick icons are not so noticeable as Mizuki mentioned in #27678.

#10 Updated by Marius BALTEANU about 1 month ago

  • Description updated (diff)

I've moved the patches that add the toggle checkboxes feature (the green tick) to several screens to this ticket (#28242).

In this one we can discuss more about replacing the "Check all | Uncheck all" links with the same toggle checkboxes mechanism in order to a have a unique an consistent way to check/uncheck a group of checkboxes across the application

#11 Updated by Marius BALTEANU about 1 month ago

  • Related to Patch #28242: Add toggle checkboxes link (green tick) to several screens added

#12 Updated by Marius BALTEANU about 1 month ago

  • File deleted (0001-adds-toogle-checkboxes-to-activities-tab-from-projec.patch)

#13 Updated by Marius BALTEANU about 1 month ago

  • File deleted (0003-adds-toogle-checkboxes-to-project-modules-from-proje.patch)

#14 Updated by Marius BALTEANU about 1 month ago

  • File deleted (0002-adds-toogle-checkboxes-to-trackers-and-custom-fields.patch)

#15 Updated by Marius BALTEANU about 1 month ago

  • File deleted (0004-adds-toogle-checkboxes-feature-to-roles-permissions.patch)

#16 Updated by Marius BALTEANU about 1 month ago

  • File deleted (Screen Shot 2017-12-16 at 12.04.52.png)

#17 Updated by Marius BALTEANU about 1 month ago

  • File deleted (Screen Shot 2017-12-16 at 12.05.07.png)

#18 Updated by Marius BALTEANU about 1 month ago

  • File deleted (Screen Shot 2017-12-16 at 12.05.33.png)

#19 Updated by Go MAEDA about 1 month ago

  • Target version set to 4.1.0

Also available in: Atom PDF