Remove filename from attachment preview links
|Assignee:||Go MAEDA||% Done:|
- right-click on the link of the attachment on the issue page,
- "save link as" to save the attachment to disk,
- send the saved file to a user not on the Redmine.
With the current URL scheme for attachment preview pages (
/attachments/:id/:filename), when the users click the preview attachment link instead of the download attachment link, the resulting html file still has the
filename of the attachment. If the user does not have a look at the attachment before using it for something else, the user might have downloaded the html preview page instead of the attachment itself.
#1 Updated by Felix Schäfer 10 months ago
- File 27822.patch added
The attached patch changes the URL rendered to preview pages from
/attachments/:id. Both URLs work before and after the patch, so this will for example not break plugins or links coming from external sites. The links to the preview attachment pages in Redmine will not have the
filename in the URL, thus if a user erroneously downloads that instead of the attachment the downloaded file will be called
123.html instead of
image.png for example.
We have to update existing tests to commit this patch.
This is an example:
Failure: ApplicationHelperTest#test_attachment_link_should_link_to_latest_attachment [/Users/maeda/redmines/redmine-trunk/test/helpers/application_helper_test.rb:694]: --- expected +++ actual @@ -1 +1 @@ -"<p><a class=\"attachment\" href=\"/attachments/1100/test.txt\">test.txt</a></p>" +"<p><a class=\"attachment\" href=\"/attachments/1100\">test.txt</a></p>"