Feature #28085

Wiki Toolbar on Full Width Custom Fields

Added by Stephen Stuart 11 months ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Custom fields
Target version:-
Resolution:Duplicate

Description

Upon upgrading to version 3.4.4 we noticed we now have the ability to have custom long text fields with Full Width Layout and Text Formatting options.

When editing an issue, fields with these options should also have the wiki toolbar displayed.

We were able to make it appear by adding a call to wikitoolbar_for in app/views/issues/_form_custom_fields.html.erb as follows:

<% custom_field_values_full_width.each do |value| %>
  <p><%= custom_field_tag_with_label :issue, value, :required => @issue.required_attribute?(value.custom_field_id) %>
  <%= wikitoolbar_for custom_field_tag_id :issue, value.custom_field %>
  </p>
<% end %>

Note that I'm not checking the Text Formatting option so all full width fields have the toolbar.

patch.txt Magnifier (7.89 KB) Osamu Murayama, 2018-02-07 12:28

wiki-toolbar-and-preview-for-full-width-cf@2x.png (40.8 KB) Go MAEDA, 2018-02-20 15:29

patch.patch Magnifier - Same patch as note-1, but with correct extension. (7.89 KB) Mischa The Evil, 2018-02-24 00:42


Related issues

Related to Redmine - Patch #21705: Option for long text custom fields to be displayed using ... Closed
Duplicates Redmine - Feature #29712: Preview and wiki toolbar for full width custom fields New

History

#1 Updated by Osamu Murayama 10 months ago

I upload my patch. All (not only issue's) custom fields which format_type "text" and text_formatting "full" have the wiki toolbar in there edit forms.
And you can preview at "project setting" and issue's form.

#2 Updated by Mischa The Evil 10 months ago

  • Related to Patch #21705: Option for long text custom fields to be displayed using full width added

#3 Updated by Go MAEDA 10 months ago

Osamu Murayama, thank you for sharing the patch. Preview for full-width custom fields is especially nice.

Marius, could you review this patch? I think you are the right person to check this patch because you implemented full-width custom fields (#21705) and now working to improve preview (#27758).

#4 Updated by Marius BALTEANU 10 months ago

Go MAEDA wrote:

Marius, could you review this patch? I think you are the right person to check this patch because you implemented full-width custom fields (#21705) and now working to improve preview (#27758).

Go MAEDA, I'll be happy to review this patch, but first I would like to take a call regarding #27758. I think that this feature can be implemented easier after the preview tab is added to the core.

#5 Updated by Mischa The Evil 10 months ago

I'll attach the same patch, but renamed so that it is recognized by Redmine as a patch (which will ease the review process of it).

#6 Updated by Go MAEDA 3 months ago

  • Related to Feature #29712: Preview and wiki toolbar for full width custom fields added

#7 Updated by Marius BALTEANU about 1 month ago

  • Related to deleted (Feature #29712: Preview and wiki toolbar for full width custom fields)

#8 Updated by Marius BALTEANU about 1 month ago

  • Duplicates Feature #29712: Preview and wiki toolbar for full width custom fields added

#9 Updated by Marius BALTEANU about 1 month ago

  • Status changed from New to Closed
  • Target version deleted (Candidate for next major release)
  • Resolution set to Duplicate

I'm closing this in favour of #29712 where we started the discussions to implement this feature.

Also available in: Atom PDF