https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292009-02-25T23:16:48ZRedmineRedmine - Feature #2835: clickable/linkable line #'s while browsing the repohttps://www.redmine.org/issues/2835?journal_id=76442009-02-25T23:16:48ZMischa The Evil
<ul></ul><p>+1, it seems to me that the chosen implementation has a pretty low severity in contrast to a the highly improved useability it provides...</p> Redmine - Feature #2835: clickable/linkable line #'s while browsing the repohttps://www.redmine.org/issues/2835?journal_id=76672009-02-26T09:28:33ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Target version</strong> set to <i>0.8.2</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul>Committed in <a class="changeset" title="Clickable/linkable line #'s while browsing the repo or viewing a text file (#2835)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/2527">r2527</a> with sligth changes:
<ul>
<li>title attribute removed (hardcoded english word)</li>
<li>change to scm.css removed (not related to this feature)</li>
</ul>
<p>Thanks.</p> Redmine - Feature #2835: clickable/linkable line #'s while browsing the repohttps://www.redmine.org/issues/2835?journal_id=76882009-02-26T22:25:16ZMischa The Evil
<ul><li><strong>File</strong> <a href="/attachments/1592">linenumbers_without_css.jpg</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1592/linenumbers_without_css.jpg">linenumbers_without_css.jpg</a> added</li><li><strong>File</strong> <a href="/attachments/1593">linenumbers_with_css.jpg</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1593/linenumbers_with_css.jpg">linenumbers_with_css.jpg</a> added</li></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
Committed in <a class="changeset" title="Clickable/linkable line #'s while browsing the repo or viewing a text file (#2835)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/2527">r2527</a> with sligth changes:
<ul>
<li>...</li>
<li>change to scm.css removed (not related to this feature)</li>
</ul>
</blockquote>
<p>I am in the opinion that it ís related in the sense of the styling of the feature. As such: I think these selectors maybe shouldn't be declared in <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/public/stylesheets/scm.css">source:/trunk/public/stylesheets/scm.css</a>. Instead they seem to belong to the <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/public/stylesheets/application.css">source:/trunk/public/stylesheets/application.css</a>.</p>
<p>See the following screenshots:</p>
<table>
<tr>
<td style="text-align:center;"><strong>Without the CSS style-declarations (as committed)</strong> </td>
<td style="text-align:center;"><strong>With the CSS style-declarations (like the patch)</strong> </td>
</tr>
<tr>
<td> <img src="https://www.redmine.org/attachments/download/1592/linenumbers_without_css.jpg" alt="" /> </td>
<td> <img src="https://www.redmine.org/attachments/download/1593/linenumbers_with_css.jpg" alt="" /> </td>
</tr>
</table>
As you see the changes are:
<ul>
<li>on <code>hover</code> -> underlining removed</li>
<li>color -> instead of default link-color a more sophisticated gray-teint is used.</li>
</ul>
<p>Though, consider it just a minor CSS-improvement... ;)</p>
<p>Thanks for your fast response on this issue...</p> Redmine - Feature #2835: clickable/linkable line #'s while browsing the repohttps://www.redmine.org/issues/2835?journal_id=78592009-03-07T11:02:19ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Yes, sorry. The style is committed in <a class="changeset" title="Change to line #'s links in file/repo viewer (#2835)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/2555">r2555</a>.</p>
<blockquote>
<p>Instead they seem to belong to the <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/public/stylesheets/application.css">source:/trunk/public/stylesheets/application.css</a></p>
</blockquote>
<p>scm.css is included when browsing a repo or viewing a file. So I don't think this style is needed in application.css<br />Am I wrong?</p> Redmine - Feature #2835: clickable/linkable line #'s while browsing the repohttps://www.redmine.org/issues/2835?journal_id=78632009-03-07T11:15:16ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged in 0.8-stable in <a class="changeset" title="Merged r2515, r2516, r2527, r2534, r2555 from trunk." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/2556">r2556</a>.</p> Redmine - Feature #2835: clickable/linkable line #'s while browsing the repohttps://www.redmine.org/issues/2835?journal_id=112172009-10-02T13:48:43ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Estimated time</strong> deleted (<del><i>0.00 h</i></del>)</li></ul>