Defect #28469

Syntax highlighter does not work if language name is single-quoted

Added by Go MAEDA about 1 month ago. Updated 24 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Text formatting
Target version:3.3.8
Resolution:Fixed Affected version:

Description

Please see the screenshot below. Syntax highlighter does not work if "Text formatting" is set to "Textile" and the language name is enclosed by single quotation marks. The Textile formatter should accept single quotation marks as well as double quotation marks.

screenshot@2x.png (22.7 KB) Go MAEDA, 2018-03-30 09:00

add-single-quoted.patch Magnifier (695 Bytes) Mizuki ISHIKAWA, 2018-04-16 01:57

add-single-quoted-2.patch Magnifier (1.54 KB) Mizuki ISHIKAWA, 2018-04-24 06:50

Associated revisions

Revision 17322
Added by Go MAEDA 24 days ago

Fix: Syntax highlighter does not work if language name is single-quoted (#28469).

Patch by Mizuki ISHIKAWA.

Revision 17323
Added by Go MAEDA 24 days ago

Merged r17322 from trunk to 3.4-stable (#28469).

Revision 17324
Added by Go MAEDA 24 days ago

Merged r17322 from trunk to 3.3-stable (#28469).

History

#1 Updated by Mizuki ISHIKAWA about 1 month ago

I think it is natural to use single quotes.
I wrote a patch to fix this defect.

#2 Updated by Marius BALTEANU about 1 month ago

Mizuki ISHIKAWA wrote:

I think it is natural to use single quotes.
I wrote a patch to fix this defect.

I would recommend to add a tests for this single quotes case.

#3 Updated by Mizuki ISHIKAWA about 1 month ago

Marius BALTEANU wrote:

Mizuki ISHIKAWA wrote:

I think it is natural to use single quotes.
I wrote a patch to fix this defect.

I would recommend to add a tests for this single quotes case.

I forgot to write a test.
I appreciate your advice.

This is the patch that added the test.

#4 Updated by Go MAEDA 25 days ago

  • Target version set to 3.3.8

LGTM. Setting target version to 3.3.8.

#5 Updated by Go MAEDA 24 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed to the trunk and stable branches. Thank you for fixing this issue.

Also available in: Atom PDF