Patch #28602

Move edit and delete buttons for queries to the buttons section

Added by Bernhard Rohloff 7 months ago. Updated 5 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Gantt
Target version:4.0.0

Description

Except in the gantts view, in all query based views the edit and delete buttons are placed inside the buttons section (apply/clear/save) under the filters and options.
I think the gantts view should be aligned to the common UI pattern, as well.

In the submitted patch the yet empty contextual area is left inside the view as it breaks the tests and I don't know if it should be left to make further modifications easier.

Current view

Proposed view

gantt_before_patch.png (7.1 KB) Bernhard Rohloff, 2018-04-22 08:46

gantt_after_patch.png (8.99 KB) Bernhard Rohloff, 2018-04-22 08:46

0001-align-query-buttons-with-other-query-based-views.patch Magnifier (1.35 KB) Bernhard Rohloff, 2018-04-22 08:59


Related issues

Related to Redmine - Patch #26125: Unify form#query_form on calendar/gantt views with issues... Closed

Associated revisions

Revision 17413
Added by Go MAEDA 5 months ago

Move edit and delete buttons for queries to the buttons section (#28602).

Patch by Bernhard Rohloff.

History

#1 Updated by Marius BALTEANU 7 months ago

  • Related to Patch #26125: Unify form#query_form on calendar/gantt views with issues/spent time views added

#2 Updated by Marius BALTEANU 7 months ago

It'll be nice to deliver this change along with #26125.

#3 Updated by Go MAEDA 7 months ago

  • Target version set to Candidate for next major release

+1

The buttons on issues list page were moved in r15344. To make the UI consistent, I think also the buttons on gantt page should be moved to below the filters.

#4 Updated by Marius BALTEANU 7 months ago

Bernhard Rohloff wrote:

In the submitted patch the yet empty contextual area is left inside the view as it breaks the tests and I don't know if it should be left to make further modifications easier.

I'm in favour of removing the empty contextual element and update the tests accordingly.

#5 Updated by Go MAEDA 7 months ago

Marius BALTEANU wrote:

Bernhard Rohloff wrote:

In the submitted patch the yet empty contextual area is left inside the view as it breaks the tests and I don't know if it should be left to make further modifications easier.

I'm in favour of removing the empty contextual element and update the tests accordingly.

I am concerned that removing the div.contextual may affect some plugins which insert custom tags into the area.

#6 Updated by Go MAEDA 6 months ago

  • Target version changed from Candidate for next major release to 4.1.0

Setting target version to 4.1.0.

#7 Updated by Go MAEDA 5 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0

Committed. Thank you for improving Redmine.

#8 Updated by Go MAEDA 5 months ago

  • Subject changed from [Gantt] Move edit and delete buttons for queries to the buttons section to Move edit and delete buttons for queries to the buttons section

Also available in: Atom PDF