Project

General

Profile

Actions
Copy link

Patch #28602

closed

Move edit and delete buttons for queries to the buttons section

Added by Bernhard Rohloff almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Gantt
Target version:
4.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Except in the gantts view, in all query based views the edit and delete buttons are placed inside the buttons section (apply/clear/save) under the filters and options.
I think the gantts view should be aligned to the common UI pattern, as well.

In the submitted patch the yet empty contextual area is left inside the view as it breaks the tests and I don't know if it should be left to make further modifications easier.

Current view

Proposed view

Files

Download all files
gantt_before_patch.png (7.1 KB) gantt_before_patch.png Bernhard Rohloff, 2018-04-22 08:46
gantt_after_patch.png (8.99 KB) gantt_after_patch.png Bernhard Rohloff, 2018-04-22 08:46
0001-align-query-buttons-with-other-query-based-views.patch (1.35 KB) 0001-align-query-buttons-with-other-query-based-views.patch Bernhard Rohloff, 2018-04-22 08:59

Related issues

Related to Redmine - Patch #26125: Unify form#query_form on calendar/gantt views with issues/spent time viewsClosedJean-Philippe Lang

Actions
Actions
Copy link
 #1

Updated by Marius BĂLTEANU almost 6 years ago

  • Related to Patch #26125: Unify form#query_form on calendar/gantt views with issues/spent time views added
Actions
Copy link
 #2

Updated by Marius BĂLTEANU almost 6 years ago

It'll be nice to deliver this change along with #26125.

Actions
Copy link
 #3

Updated by Go MAEDA almost 6 years ago

  • Target version set to Candidate for next major release

+1

The buttons on issues list page were moved in r15344. To make the UI consistent, I think also the buttons on gantt page should be moved to below the filters.

Actions
Copy link
 #4

Updated by Marius BĂLTEANU almost 6 years ago

Bernhard Rohloff wrote:

In the submitted patch the yet empty contextual area is left inside the view as it breaks the tests and I don't know if it should be left to make further modifications easier.

I'm in favour of removing the empty contextual element and update the tests accordingly.

Actions
Copy link
 #5

Updated by Go MAEDA almost 6 years ago

Marius BALTEANU wrote:

Bernhard Rohloff wrote:

In the submitted patch the yet empty contextual area is left inside the view as it breaks the tests and I don't know if it should be left to make further modifications easier.

I'm in favour of removing the empty contextual element and update the tests accordingly.

I am concerned that removing the div.contextual may affect some plugins which insert custom tags into the area.

Actions
Copy link
 #6

Updated by Go MAEDA almost 6 years ago

  • Target version changed from Candidate for next major release to 4.1.0

Setting target version to 4.1.0.

Actions
Copy link
 #7

Updated by Go MAEDA almost 6 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0

Committed. Thank you for improving Redmine.

Actions
Copy link
 #8

Updated by Go MAEDA almost 6 years ago

  • Subject changed from [Gantt] Move edit and delete buttons for queries to the buttons section to Move edit and delete buttons for queries to the buttons section
Actions
Copy link

Also available in: Atom PDF