https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-07-04T13:36:03ZRedmineRedmine - Patch #29189: Display custom fields on group pageshttps://www.redmine.org/issues/29189?journal_id=860432018-07-04T13:36:03ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/21031">screenshot-29189@2x.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21031/screenshot-29189@2x.png">screenshot-29189@2x.png</a> added</li></ul><p>This is a screenshot of <code>/groups/:id</code> page after applying the patch.</p>
<p><img src="https://www.redmine.org/attachments/download/21031/screenshot-29189@2x.png" srcset="https://www.redmine.org/attachments/download/21031/screenshot-29189@2x.png 2x" style="width: 355px;border: 1px #ccc solid;" alt="" /></p> Redmine - Patch #29189: Display custom fields on group pageshttps://www.redmine.org/issues/29189?journal_id=860442018-07-04T13:48:23ZGo MAEDA
<ul><li><strong>Assignee</strong> set to <i>Gregor Schmidt</i></li></ul><p>Thank you for posting the patch. I think this patch improves the consistency of UI.</p>
<p>But I wonder whether the heading "Attributes" is necessary. <code>/users/:id</code> page does not add such a heading when showing custom fields (see <a class="external" href="http://www.redmine.org/users/347">http://www.redmine.org/users/347</a> for example). In addition, <code>:label_attribute_plural</code> is only used in <code>app/views/auth_sources/_form_auth_source_ldap.html.erb</code>.</p>
<p>Do you think we can remove "<code><h3><%= l(:label_attribute_plural) %></h3></code>" from the patch?</p> Redmine - Patch #29189: Display custom fields on group pageshttps://www.redmine.org/issues/29189?journal_id=860462018-07-04T14:10:13ZGregor Schmidtschmidt@nach-vorne.eu
<ul></ul><p>Thank you for reviewing this patch.</p>
<p>I don't have a strong opinion on this one. I've added the sub heading for cosmetic reasons. If you think it's not necessary, this is OK for me.</p> Redmine - Patch #29189: Display custom fields on group pageshttps://www.redmine.org/issues/29189?journal_id=860622018-07-05T12:35:32ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/21033">29189.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21033/29189.patch">29189.patch</a> added</li><li><strong>Assignee</strong> deleted (<del><i>Gregor Schmidt</i></del>)</li><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul><p>I have slightly changed Gregor Schmidt's patch. Setting target version to 4.1.0.</p> Redmine - Patch #29189: Display custom fields on group pageshttps://www.redmine.org/issues/29189?journal_id=860632018-07-05T13:08:51ZMarius BÄ‚LTEANU
<ul></ul><p>Go Maeda, lets have a basic test for this feature.</p> Redmine - Patch #29189: Display custom fields on group pageshttps://www.redmine.org/issues/29189?journal_id=860862018-07-06T04:45:31ZMizuki ISHIKAWA
<ul><li><strong>File</strong> <a href="/attachments/21040">add_test_to_29189_patch.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21040/add_test_to_29189_patch.patch">add_test_to_29189_patch.patch</a> added</li></ul><p>I wrote a test for 20189.patch.</p> Redmine - Patch #29189: Display custom fields on group pageshttps://www.redmine.org/issues/29189?journal_id=860882018-07-06T07:11:02ZGregor Schmidtschmidt@nach-vorne.eu
<ul></ul><p>Thank you very much for providing a test case.</p> Redmine - Patch #29189: Display custom fields on group pageshttps://www.redmine.org/issues/29189?journal_id=861552018-07-10T07:07:29ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>4.0.0</i></li></ul><p>Committed the patch and test with a slight change. Thank you all for the contribution.</p>