Project

General

Profile

Actions
Copy link

Patch #29395

closed

Pagination between repository entries and attachments of the same container

Added by Jens Krämer over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Attachments
Target version:
4.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This feature was implemented for Planio and consists of 3 patches:

1. adds pagination under the attachment preview which allows to cycle through the list of attachments of the container object
2. adds pagination under the preview of repository entries to navigate other entries on the same level
3. adds some Javascript which binds left/right arrow keys to work like clicks on the previous / next links (only in the cases of 1 and 2).

Files

Download all files
0001-attachments-prev-next-navigation.patch (3.61 KB) 0001-attachments-prev-next-navigation.patch Jens Krämer, 2018-08-16 10:58
0002-repository-entry-pagination.patch (3.55 KB) 0002-repository-entry-pagination.patch Jens Krämer, 2018-08-16 10:58
29395-pagination-screenshot@2x.png (136 KB) 29395-pagination-screenshot@2x.png Go MAEDA, 2018-08-18 09:19
cannot-see-bottom-part-of-content.png (72.7 KB) cannot-see-bottom-part-of-content.png Go MAEDA, 2018-09-21 06:36
0004-Let-pagination-always-be-visible.patch (2.72 KB) 0004-Let-pagination-always-be-visible.patch Felix Gliesche, 2018-09-25 15:02
0003-adds-file-preview-prev-next-navigation-with-arrow-ke.patch (2.4 KB) 0003-adds-file-preview-prev-next-navigation-with-arrow-ke.patch Jens Krämer, 2018-10-04 09:05
Actions
Copy link
 #1

Updated by Go MAEDA over 5 years ago

This is a screenshot after applying 0001-attachments-prev-next-navigation.patch. I like this feature.

Actions
Copy link
 #2

Updated by Yuuki NARA over 5 years ago

+1

Actions
Copy link
 #3

Updated by Felix Gliesche over 5 years ago

  • File 0004-Let-pagination-always-be-visible.patch added

I am adding a small improvement to this patch: When browsing through a series of attachments it's convenient for the user to have the pagniation always in the viewport in order to avoid scrolling after page change. The attached patch takes care, that the pagination is always visible.

Actions
Copy link
 #4

Updated by Go MAEDA over 5 years ago

  • Status changed from New to Needs feedback

The pagination is really nice, but some features don't work on my environment. Could you look into it? The second problem is reproducible also on Planio.

  1. Left and right arrow keys don't work at all. Nothing occurs when I hit those keys.
  2. Bottom part of the content and pagination are not shown if I apply 0004-Let-pagination-always-be-visible.patch.

I tested with Firefox 62.0 and Chrome 69.0.3497.100 on macOS.

Actions
Copy link
 #5

Updated by Go MAEDA over 5 years ago

The screenshot below describes the problem I wrote in #29395#note-4. The attachment '100-lines.txt' consists of 100 lines of text, but the page shows only 35 lines and a user cannot scroll down. No problem if 0004-Let-pagination-always-be-visible.patch is not applied.

Actions
Copy link
 #6

Updated by Felix Gliesche over 5 years ago

Thanks for reporting this problem. I will take care of it and update the patch.

Actions
Copy link
 #7

Updated by Felix Gliesche over 5 years ago

Here is an update to the patch, that should fix the before mentioned case.

Go MAEDA: could you delete the old version of the file 0004-Let-pagination-always-be-visible.patch?

Thanks!

Actions
Copy link
 #8

Updated by Go MAEDA over 5 years ago

  • File deleted (0004-Let-pagination-always-be-visible.patch)
Actions
Copy link
 #9

Updated by Go MAEDA over 5 years ago

Felix Gliesche wrote:

Here is an update to the patch, that should fix the before mentioned case.

Thank you for updating the patch. But I could not find differences between before and after applying 0004-Let-pagination-always-be-visible.patch. Could you tell me how the patch should work? Please show me some screenshots if possible.

And, the left and right arrow key don't work on my environment (Firefox 62.0.2 and Chrome 69.0.3497.100 on macOS). Could you also investigate this?

Actions
Copy link
 #10

Updated by Jens Krämer over 5 years ago

Go MAEDA wrote:
Could you tell me how the patch should work?

The new version of the patch is supposed to remove the height limiting for any plain text files, that is, the file should be shown as usual and the pagination below. So in turn the height limiting, keeping pagination visible at the bottom of the screen, should only be active for images / video where it makes the most sense. I just tried this out locally and it looked good to me.

And, the left and right arrow key don't work on my environment (Firefox 62.0.2 and Chrome 69.0.3497.100 on macOS). Could you also investigate this?

The javascript function was indeed never called. I upload an updated version of the patch which also fixes the problem that pagination was triggered when modifier keys were pressed together with an arrow key (i.e. when trying to go back a page using Alt-ArrowLeft)

Actions
Copy link
 #11

Updated by Go MAEDA over 5 years ago

  • Status changed from Needs feedback to New
  • Target version changed from Candidate for next major release to 4.1.0

Confirmed that everything is working fine now!
Setting target version to 4.1.0.

Actions
Copy link
 #12

Updated by Go MAEDA over 5 years ago

  • File deleted (0003-adds-file-preview-prev-next-navigation-with-arrow-ke.patch)
Actions
Copy link
 #13

Updated by Go MAEDA over 5 years ago

  • Subject changed from [Feature] Pagination between repository entries and attachments of the same container to Pagination between repository entries and attachments of the same container
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Target version changed from 4.1.0 to 4.0.0

Committed the patch series. Thank you for providing the nice feature!

Actions
Copy link

Also available in: Atom PDF