Patch #29838

time logging via commit message does not work when the configured activity has been overridden on the project level

Added by Jens Krämer about 1 year ago. Updated 2 months ago.

Status:Needs feedbackStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Time tracking
Target version:Candidate for next major release

Description

This happened with a client at Planio, we came up with the attached patch which fixes the problem by looking up the activity in the activities of the associated issues' project. Test case included to illustrate the problem.

The second patch is just a small refactoring which moves the activity finder to the Project model.

0001-fix-logging-time-via-a-commit-message-for-project-sp.patch Magnifier (3.04 KB) Jens Krämer, 2018-10-23 11:28

0002-small-refactoring-moves-the-method-to-find-the-activ.patch Magnifier (1.97 KB) Jens Krämer, 2018-10-23 11:29

0002-small-refactoring-moves-the-method-to-find-the-activ.patch Magnifier - updated version of the second patch, better method name to match the setting (1.96 KB) Jens Krämer, 2018-10-23 11:42

History

#1 Updated by Jens Krämer about 1 year ago

updated version of the second patch, better method name to match the setting

#2 Updated by Go MAEDA about 1 year ago

  • Target version set to Candidate for next major release

#3 Updated by Go MAEDA about 1 year ago

  • Target version changed from Candidate for next major release to 4.1.0

#4 Updated by Go MAEDA 8 months ago

  • Status changed from New to Needs feedback

The test fails in my environment.

Failure:
ChangesetTest#test_ref_keywords_any_with_timelog [test/unit/changeset_test.rb:142]:
Expected false to be truthy.

bin/rails test test/unit/changeset_test.rb:106

#5 Updated by Go MAEDA 2 months ago

  • Target version changed from 4.1.0 to Candidate for next major release

Removing from 4.1.0 because the test fails.

Also available in: Atom PDF