https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-11-06T03:07:24ZRedmineRedmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=882752018-11-06T03:07:24ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/27780">Defect #27780</a>: Case-insensitive matching fails for Unicode filenames when referring to attachments in text formatting</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=910482019-03-31T22:32:40ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/31128">Feature #31128</a>: Drop Ruby < 2.5 support</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=924982019-06-20T14:16:58ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Unplanned backlogs</i> to <i>5.0.0</i></li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=926932019-07-01T12:43:01ZEnziin System
<ul></ul><p>Rails 6?</p>
<p>Please carefully, because Rails 6 drop sprockets assets and use Webpack default.</p>
<p>In the wonderland, Redmine converts to the frontend with Angular/Reactjs/Vue, it's my dream.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=931482019-08-17T03:50:18ZGo MAEDA
<ul><li><strong>Blocked by</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/31919">Patch #31919</a>: Update roadie-rails gem (~> 2.1.0)</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=932202019-08-18T15:04:18ZMarius BĂLTEANU
<ul></ul><p>Rails 6 is released: <a class="external" href="https://weblog.rubyonrails.org/2019/8/18/this-week-in-rails-rails-6-is-released-sass-rails-6-improved-mysql2-error-and-more/">https://weblog.rubyonrails.org/2019/8/18/this-week-in-rails-rails-6-is-released-sass-rails-6-improved-mysql2-error-and-more/</a></p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=956132020-01-10T02:39:48ZTigergm Wu
<ul></ul><p>Yes. I hope so.<br />Enziin System wrote:</p>
<blockquote>
<p>Rails 6?</p>
<p>Please carefully, because Rails 6 drop sprockets assets and use Webpack default.</p>
<p>In the wonderland, Redmine converts to the frontend with Angular/Reactjs/Vue, it's my dream.</p>
</blockquote> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=958652020-01-26T09:07:45ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32885">Defect #32885</a>: Rails 6: DEPRECATION WARNING: Single arity template handlers are deprecated</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=958692020-01-26T14:41:22ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32886">Patch #32886</a>: Rails 6: Use #media_type instead of #content_type to test the MIME type of a response</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=958832020-01-26T22:12:25ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32887">Patch #32887</a>: Rails 6: Use "render template:" instead of "render file:" in app/views/layouts/admin.html.erb</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=958922020-01-27T04:31:10ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/24685">32886-wip-r19467.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/24685/32886-wip-r19467.patch">32886-wip-r19467.patch</a> added</li></ul><p>I started work on this issue.</p>
<p>Here is the very first version of the work-in-progress patch but there are still many errors.</p>
<pre>
4936 runs, 22346 assertions, 34 failures, 42 errors, 7 skips
</pre>
<p>Please feel free to update the patch. Your help is highly appreciated!</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959132020-01-27T17:00:00ZMarius BĂLTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I started work on this issue.</p>
<p>Here is the very first version of the work-in-progress patch but there are still many errors.</p>
<p>[...]</p>
<p>Please feel free to update the patch. Your help is highly appreciated!</p>
</blockquote>
<p>I'm willing to help with this, but I think we should have first a decision (from Jean-Philippe, I guess) regarding next Redmine major version. If we're going to update to Rails 6, we should merge version 4.2.0 to 5.0.0.</p>
<p>Considering the time frame of the major releases, I'm in favour of Redmine 5.0.0 with support for Rails 6.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959152020-01-27T22:07:31ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32897">Defect #32897</a>: Rails 6: Pass `case_sensitive: true` option explicitly to the uniqueness validator</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959222020-01-28T05:34:57ZGo MAEDA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I'm willing to help with this, but I think we should have first a decision (from Jean-Philippe, I guess) regarding next Redmine major version. If we're going to update to Rails 6, we should merge version 4.2.0 to 5.0.0.</p>
</blockquote>
<p>I agree. Redmine 5.0.0 is the appropriate version to switch to Rails 6 and this should be decided by Jean-Philippe Lang.</p>
<p>But while waiting for Jean-Philippe's decision, we can prepare for moving to Rails 6. And I think we should do it to quickly switch to Rails 6 once JPL decided to do.</p>
<p>I think we should move to Rails 6 as soon as we can because the Rails team no longer provides bug fixes for Rails 5.2 except for security fixes. The negative impacts of that are already happening. For example, Redmine does not support Ruby 2.7 because Rails 5.2 does not. And probably Rails 5.2 will never support 2.7.</p>
<p>So, I think we should prepare for Rails 6 in parallel with waiting for the decision.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959332020-01-28T13:57:05ZAleksandar Pavic
<ul></ul><p>+1 however I guess lot's of plugin developers will need to be notified and start their upgrades as well...</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959402020-01-28T21:51:57ZMarius BĂLTEANU
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I agree. Redmine 5.0.0 is the appropriate version to switch to Rails 6 and this should be decided by Jean-Philippe Lang.</p>
<p>But while waiting for Jean-Philippe's decision, we can prepare for moving to Rails 6. And I think we should do it to quickly switch to Rails 6 once JPL decided to do.</p>
<p>I think we should move to Rails 6 as soon as we can because the Rails team no longer provides bug fixes for Rails 5.2 except for security fixes. The negative impacts of that are already happening. For example, Redmine does not support Ruby 2.7 because Rails 5.2 does not. And probably Rails 5.2 will never support 2.7.</p>
<p>So, I think we should prepare for Rails 6 in parallel with waiting for the decision.</p>
</blockquote>
<p>Let's do it then. I've prepared <a href="https://gitlab.com/redmine-org/redmine/pipelines/113081049" class="external">this</a> branch on my Gitlab CI instance, it should be easier to track the test fails. <br />As next steps, I propose to open issues for all fails and deprecation warnings and to discuss there the fixes. I expect to get some feedback from other active contributors.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959422020-01-28T22:02:01ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32908">Defect #32908</a>: Rails 6: Sending mail with DeliveryJob is deprecated</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959512020-01-29T07:23:50ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32909">Patch #32909</a>: Replace pluck().first with pick()</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959532020-01-29T07:24:03ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32910">Defect #32910</a>: Rails 6: add lookup_context to hook_test.rb</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959552020-01-29T07:24:11ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32911">Patch #32911</a>: Rails 6: Fix deprecation warning "Class level methods will no longer inherit scoping"</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959572020-01-29T07:24:19ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32912">Defect #32912</a>: Rails 6: update no longer bypass optimistic locking</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959592020-01-29T07:24:27ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32913">Defect #32913</a>: Rails 6: add filename header</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959612020-01-29T07:24:35ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32914">Defect #32914</a>: Rails 6: remove #filename_for_content_disposition for MS browsers</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959782020-01-30T07:14:15ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32922">Patch #32922</a>: Reload detached attachments</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959822020-01-30T07:20:54ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32923">Defect #32923</a>: Rails 6: detach attachments when a conflict occurs</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=959842020-01-30T07:21:07ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32921">Defect #32921</a>: Rails 6: add header=present to csv tests</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=960392020-02-03T02:05:48ZPavel Rosický
<ul></ul><p>all tests should be passing now</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=960552020-02-03T22:55:30ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32935">Defect #32935</a>: Rails 6: fix set role_ids</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=960572020-02-03T22:56:12ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32936">Defect #32936</a>: Rails 6: disable AJ test adapter for integration tests</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=960592020-02-03T22:56:28ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32937">Patch #32937</a>: test_revisions_latin_1_identifier should be skipped on Windows</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=960612020-02-03T22:56:48ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/32938">Feature #32938</a>: Rails 6: Zeitwerk support</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=960632020-02-03T22:57:04ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32939">Defect #32939</a>: Rails 6: fix plugin migrations</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=994902020-10-21T02:48:02ZGo MAEDA
<ul><li><strong>Related to</strong> deleted (<i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/27780">Defect #27780</a>: Case-insensitive matching fails for Unicode filenames when referring to attachments in text formatting</i>)</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=997892020-11-19T13:30:57ZPetr Pospisil
<ul></ul><p>Hello all,</p>
<p>I would like to offer you our help to speed up migration to Rails 6. If you are interested in, please contact me. I have several experienced Redmine developers that should help to move Redmine forward. We can setup a plan and deliver issues done. I know we can send a patch, but I am talking about closer cooperation.</p>
<p>Thank you<br />Petr</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1016172021-03-29T20:17:11ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/34980">Defect #34980</a>: Fix "undefined method `represent_boolean_as_integer=' for nil:NilClass" in Rails 6.1</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1016302021-03-30T10:20:58ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/34985">Defect #34985</a>: Rails 6.1 replace ActiveModel::Errors #<< with #add</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1016322021-03-30T10:21:05ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/34984">Defect #34984</a>: Rails 6.1 Rendering actions with '.' in the name is deprecated</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1016662021-03-30T16:42:25ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/26987">0010-Fix-ArgumentError-wrong-number-of-arguments-given-1-.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26987/0010-Fix-ArgumentError-wrong-number-of-arguments-given-1-.patch">0010-Fix-ArgumentError-wrong-number-of-arguments-given-1-.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26988">0009-Fix-ArgumentError-wrong-number-of-arguments-given-1-.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26988/0009-Fix-ArgumentError-wrong-number-of-arguments-given-1-.patch">0009-Fix-ArgumentError-wrong-number-of-arguments-given-1-.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26989">0008-Rails-6.1-add-header-present-to-csv-tests-29914-3292.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26989/0008-Rails-6.1-add-header-present-to-csv-tests-29914-3292.patch">0008-Rails-6.1-add-header-present-to-csv-tests-29914-3292.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26990">0007-Fix-ActionView-Template-Error-wrong-number-of-argume.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26990/0007-Fix-ActionView-Template-Error-wrong-number-of-argume.patch">0007-Fix-ActionView-Template-Error-wrong-number-of-argume.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26991">0006-Fix-DEPRECATION-WARNING-Passing-a-path-to-relative-t.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26991/0006-Fix-DEPRECATION-WARNING-Passing-a-path-to-relative-t.patch">0006-Fix-DEPRECATION-WARNING-Passing-a-path-to-relative-t.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26992">0005-Fix-ActiveRecord-StaleObjectError-Attempted-to-updat.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26992/0005-Fix-ActiveRecord-StaleObjectError-Attempted-to-updat.patch">0005-Fix-ActiveRecord-StaleObjectError-Attempted-to-updat.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26993">0004-Fix-Subclasses-must-implement-a-find_templates-name-.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26993/0004-Fix-Subclasses-must-implement-a-find_templates-name-.patch">0004-Fix-Subclasses-must-implement-a-find_templates-name-.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26994">0003-Fix-sending-mail-with-DeliveryJob-is-deprecated-2991.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26994/0003-Fix-sending-mail-with-DeliveryJob-is-deprecated-2991.patch">0003-Fix-sending-mail-with-DeliveryJob-is-deprecated-2991.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26995">0002-Fix-undefined-method-for-nil-NilClass-in-Rails-6.1-2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26995/0002-Fix-undefined-method-for-nil-NilClass-in-Rails-6.1-2.patch">0002-Fix-undefined-method-for-nil-NilClass-in-Rails-6.1-2.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26996">0001-Fix-DEPRECATION-WARNING-Uniqueness-validator-will-no.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26996/0001-Fix-DEPRECATION-WARNING-Uniqueness-validator-will-no.patch">0001-Fix-DEPRECATION-WARNING-Uniqueness-validator-will-no.patch</a> added</li></ul><p>I'm attaching a patch series (19) that updates Rails to 6.1.3.1 and fixes all the tests on <a href="https://gitlab.com/redmine-org/redmine/-/jobs/1140003736" class="external">MySQL</a> and <a href="https://gitlab.com/redmine-org/redmine/-/jobs/1140003740" class="external">PostgreSQL</a>. MS SQL support is broken for now because the gem supports only Rails 6.0, but I'm confident that will be fixed in the following weeks (there are active discussions/PRs).</p>
<p>My proposal is to have these patches committed as soon as possible in order to have enough time to catch and fix other issues caused by this update (this apply also for plugin developers) and to discuss the other improvements that Rails 6.0/6.1 are adding. In the meanwhile, to track the changes easily, I've changed from Patch to Defect all those tickets that are a must for this update (and for which we have patches attached here).</p>
<p>Thanks again Pavel Rosický for you work on this!</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1016672021-03-30T16:42:47ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/26998">0019-Update-activerecord-sqlserver-adapter-to-6.0.1.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26998/0019-Update-activerecord-sqlserver-adapter-to-6.0.1.patch">0019-Update-activerecord-sqlserver-adapter-to-6.0.1.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26997">0018-Rails-6.1-fix-set-roleids-29914-32935.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26997/0018-Rails-6.1-fix-set-roleids-29914-32935.patch">0018-Rails-6.1-fix-set-roleids-29914-32935.patch</a> added</li><li><strong>File</strong> <a href="/attachments/26999">0017-Fix-DEPRECATION-WARNING-Calling-to-an-ActiveModel-Er.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/26999/0017-Fix-DEPRECATION-WARNING-Calling-to-an-ActiveModel-Er.patch">0017-Fix-DEPRECATION-WARNING-Calling-to-an-ActiveModel-Er.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27002">0016-Fix-DEPRECATION-WARNING-Rendering-actions-with-.-in-.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27002/0016-Fix-DEPRECATION-WARNING-Rendering-actions-with-.-in-.patch">0016-Fix-DEPRECATION-WARNING-Rendering-actions-with-.-in-.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27000">0015-Fix-detach-attachments-when-a-conflict-occurs-29914-.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27000/0015-Fix-detach-attachments-when-a-conflict-occurs-29914-.patch">0015-Fix-detach-attachments-when-a-conflict-occurs-29914-.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27001">0014-Disable-TestAdapter-on-IntegrationTest-29914-32936.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27001/0014-Disable-TestAdapter-on-IntegrationTest-29914-32936.patch">0014-Disable-TestAdapter-on-IntegrationTest-29914-32936.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27003">0013-Remove-filename_for_content_disposition-for-MS-brows.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27003/0013-Remove-filename_for_content_disposition-for-MS-brows.patch">0013-Remove-filename_for_content_disposition-for-MS-brows.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27005">0012-Add-filename-header-29914-32913.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27005/0012-Add-filename-header-29914-32913.patch">0012-Add-filename-header-29914-32913.patch</a> added</li><li><strong>File</strong> <a href="/attachments/27004">0011-Use-media_type-to-get-the-MIME-type-of-the-request-2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27004/0011-Use-media_type-to-get-the-MIME-type-of-the-request-2.patch">0011-Use-media_type-to-get-the-MIME-type-of-the-request-2.patch</a> added</li></ul><p>Batch 2.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1016692021-03-31T00:29:16ZGo MAEDA
<ul></ul><p>Thank you all for working on this.</p>
<p>Marius BALTEANU wrote:</p>
<blockquote>
<p>My proposal is to have these patches committed as soon as possible in order to have enough time to catch and fix other issues caused by this update (this apply also for plugin developers) and to discuss the other improvements that Rails 6.0/6.1 are adding.</p>
</blockquote>
<p>I agree. Support for Rails 5.2 will end when Rails 7.0 is released (maybe this year?). So we need to migrate to Rails 6 as soon as possible.</p>
<p>I will commit the patches contributed by Pavel Rosický and Marius BALTEANU in the coming days.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1016812021-03-31T06:25:21ZMarius BĂLTEANU
<ul><li><strong>Subject</strong> changed from <i>Migrate to Rails 6</i> to <i>Migrate to Rails 6.1</i></li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1016832021-03-31T06:25:39ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-1 priority-4 priority-default" href="/issues/34987">Feature #34987</a>: Rails 6.1 destroy async</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1016872021-03-31T06:41:12ZGo MAEDA
<ul><li><strong>Blocks</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/34992">Feature #34992</a>: Ruby 3.0 support</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017112021-04-01T07:58:12ZGo MAEDA
<ul></ul><p>The following error was reported while running the test suite.</p>
<pre>
Failure:
RepositoriesSubversionControllerTest#test_entry_download [/Users/maeda/redmines/trunk/test/functional/repositories_subversion_controller_test.rb:332]:
--- expected
+++ actual
@@ -1 +1 @@
-"attachment; filename=\"helloworld.c\""
+"attachment; filename=\"helloworld.c\"; filename*=UTF-8''helloworld.c"
rails test test/functional/repositories_subversion_controller_test.rb:318
</pre> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017122021-04-01T08:29:45ZGo MAEDA
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>The following error was reported while running the test suite.</p>
<p>[...]</p>
</blockquote>
<p>I will fix <code>RepositoriesSubversionControllerTest#test_entry_download</code> when I commit <a class="attachment" href="https://www.redmine.org/attachments/27005">0012-Add-filename-header-29914-32913.patch</a></p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017262021-04-01T16:12:59ZGo MAEDA
<ul></ul><p>Committed 19 patches attached to <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Migrate to Rails 6.1 with Zeitwerk autoloading (Closed)" href="https://www.redmine.org/issues/29914#note-38">#29914#note-38</a> and <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Migrate to Rails 6.1 with Zeitwerk autoloading (Closed)" href="https://www.redmine.org/issues/29914#note-39">#29914#note-39</a> (<a class="changeset" title="Gemfile: Update Rails to 6.1 (#29914)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/20879">r20879</a> .. <a class="changeset" title="Fix a test failure caused by an assert forgotten to be deleted (#29914, #32913)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/20901">r20901</a>).</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017362021-04-02T00:35:19ZYuichi HARADA
<ul></ul><p>Updating activerecord-sqlserver-adapter with <a class="changeset" title="Update activerecord-sqlserver-adapter to 6.0.1 (#29914)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/20900">r20900</a>, but when I execute <code>bundle update</code>, the following error occurs.</p>
<pre>
% bundle update
Fetching gem metadata from https://rubygems.org/..........
Resolving dependencies...
Bundler could not find compatible versions for gem "activerecord":
In Gemfile:
activerecord-sqlserver-adapter (~> 6.0.1) was resolved to 6.0.1, which depends on
activerecord (~> 6.0.0)
rails (= 6.1.3.1) was resolved to 6.1.3.1, which depends on
activerecord (= 6.1.3.1)
</pre> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017372021-04-02T00:47:48ZPavel Rosický
<ul></ul><p><a class="user active" href="https://www.redmine.org/users/129121">優一 内田</a> activerecord-sqlserver-adapter doesn't support Rails 6.1 yet, but there's an open PR<br /><a class="external" href="https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/861">https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/861</a></p>
<p>it would be nice if someone could run tests on it.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017382021-04-02T01:17:14ZYuichi HARADA
<ul></ul><p>Pavel Rosický wrote:</p>
<blockquote>
<p><a class="user active" href="https://www.redmine.org/users/129121">優一 内田</a> activerecord-sqlserver-adapter doesn't support Rails 6.1 yet, but there's an open PR<br /><a class="external" href="https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/861">https://github.com/rails-sqlserver/activerecord-sqlserver-adapter/pull/861</a></p>
<p>it would be nice if someone could run tests on it.</p>
</blockquote>
<p>Thank you for teaching me. I hope it will be resolved by the time Redmine 5.0 is released.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017452021-04-02T05:57:02ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/35002">Defect #35002</a>: Fix MS SQL on Rails 6.1</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017462021-04-02T05:57:26ZMarius BĂLTEANU
<ul></ul><p>I've created <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Fix MS SQL on Rails 6.1 (Closed)" href="https://www.redmine.org/issues/35002">#35002</a> to track the compatibility with MS SQL.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017482021-04-02T06:07:23ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/35003">Defect #35003</a>: Update Rails UJS</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017522021-04-02T07:26:12ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/35004">Defect #35004</a>: DEPRECATION WARNING during startup</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017542021-04-02T08:14:27ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/35005">Defect #35005</a>: RuntimeError "Couldn't find Active Storage configuration" is raised at startup</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017652021-04-02T20:49:16ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/27025">0001-Update-TargetRailsVersion-to-6.1.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/27025/0001-Update-TargetRailsVersion-to-6.1.patch">0001-Update-TargetRailsVersion-to-6.1.patch</a> added</li></ul><p>We should update Rubocop TargetRailsVersion to 6.1</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1017712021-04-03T01:38:18ZGo MAEDA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>We should update Rubocop TargetRailsVersion to 6.1</p>
</blockquote>
<p>Done in <a class="changeset" title="Set TargetRailsVersion of RuboCop to 6.1 (#29914)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/20908">r20908</a>.</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1019642021-04-13T02:22:01ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/35081">Patch #35081</a>: Update config/environments/*.rb for Rails 6.1</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1029822021-06-26T04:29:01ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/35466">Patch #35466</a>: Rename test/fixtures/configuration/*.yml.example to test/fixtures/files/configuration/*.yml</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1046542021-11-17T23:38:12ZMarius BĂLTEANU
<ul><li><strong>Subject</strong> changed from <i>Migrate to Rails 6.1</i> to <i>Migrate to Rails 6.1 with Zeitwerk autoloading</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Now that we switched to Zeitwerk autoloader (<a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Rails 6: Zeitwerk support (Closed)" href="https://www.redmine.org/issues/32938">#32938</a>), we can consider the migration to Rails 6.1 completed.</p>
<p>Thanks again for all the help!</p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1046552021-11-17T23:38:37ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1047322021-11-25T21:35:07ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/36218">Defect #36218</a>: Plugin assets are not copied correctly in trunk r21289</i> added</li></ul> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1048662021-12-15T00:58:38ZGo MAEDA
<ul></ul><p>Updated Rails to 6.1.4.3 in <a class="changeset" title="Update Rails to 6.1.4.3 (#29914)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21315">r21315</a>.</p>
<p>Rails 6.1.4.2 fixes <a href="https://discuss.rubyonrails.org/t/possible-open-redirect-in-host-authorization-middleware/79505" class="external">CVE-2021-44528</a>. 6.1.4.3 fixes a bug that exists only in 6.1.4.2.</p>
<p><a class="external" href="https://weblog.rubyonrails.org/2021/12/14/Rails-6-0-4-2-6-1-4-2-and-7-0-0-rc2-have-been-released/">https://weblog.rubyonrails.org/2021/12/14/Rails-6-0-4-2-6-1-4-2-and-7-0-0-rc2-have-been-released/</a><br /><a class="external" href="https://weblog.rubyonrails.org/2021/12/14/Rails-6-0-4-3-6-1-4-3-and-7-0-0-rc3-have-been-released/">https://weblog.rubyonrails.org/2021/12/14/Rails-6-0-4-3-6-1-4-3-and-7-0-0-rc3-have-been-released/</a></p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1048802021-12-16T00:09:15ZGo MAEDA
<ul></ul><p>Updated Rails to 6.1.4.4 in <a class="changeset" title="Update Rails to 6.1.4.4 (#29914)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/21316">r21316</a>.<br /><a class="external" href="https://weblog.rubyonrails.org/2021/12/15/Rails-6-0-4-4-and-6-1-4-4-have-been-released/">https://weblog.rubyonrails.org/2021/12/15/Rails-6-0-4-4-and-6-1-4-4-have-been-released/</a></p> Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadinghttps://www.redmine.org/issues/29914?journal_id=1087862022-12-18T08:36:12ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/36273">Defect #36273</a>: Modifying the source code of a plugin does not reload it after r21295</i> added</li></ul>