https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292018-11-11T07:12:31ZRedmineRedmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=883352018-11-11T07:12:31ZMarius BĂLTEANU
<ul></ul><p>I can take a look if you want.</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=883362018-11-11T10:00:06ZGo MAEDA
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>I can take a look if you want.</p>
</blockquote>
<p>Thanks. I have not started the work yet, so I am glad if you work on it. Although the priority of this issue is low, we have to upgrade i18n someday.</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=884172018-11-17T11:42:21ZMarius BĂLTEANU
<ul></ul><p>The test that fails on my local environment is the below one and not the one from <a class="changeset" title="Gemfile: pin i18n version 0.7.0 i18n 0.8.0 causes error. <pre> Redmine::I18nTest#test_languages..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16324">r16324</a>.</p>
<pre><code class="bash syntaxhl">root@45ec3a6558b0:/work# ruby <span class="nb">test</span>/unit/lib/redmine/i18n_test.rb
DEPRECATION WARNING: <span class="sb">`</span>secrets.secret_token<span class="sb">`</span> is deprecated <span class="k">in </span>favor of <span class="sb">`</span>secret_key_base<span class="sb">`</span> and will be removed <span class="k">in </span>Rails 6.0. <span class="o">(</span>called from &lt<span class="p">;</span>top <span class="o">(</span>required<span class="o">)</span>&gt<span class="p">;</span> at /work/config/environment.rb:14<span class="o">)</span>
Run options: <span class="nt">--seed</span> 36235
<span class="c"># Running:</span>
.........F
Failure:
Redmine::I18nTest#test_fallback <span class="o">[</span><span class="nb">test</span>/unit/lib/redmine/i18n_test.rb:234]:
<span class="nt">---</span> expected
+++ actual
@@ <span class="nt">-1</span> +1 @@
-<span class="s2">"Untranslated string"</span>
+<span class="s2">"translation missing: fr.untranslated"</span>
</code></pre> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=884182018-11-17T12:37:13ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/21823">0001-Updates-i18n-gem-to-1.1.1.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/21823/0001-Updates-i18n-gem-to-1.1.1.patch">0001-Updates-i18n-gem-to-1.1.1.patch</a> added</li></ul><p>There are multiple changes between 0.7.0 version and 1.1.1.</p>
<p>One reason of the failing test is <a class="external" href="https://github.com/svenfuchs/i18n/pull/415">https://github.com/svenfuchs/i18n/pull/415</a> which doesn't consider anymore the default locale as fallback locale. Now you need to explicitly define in the config the fallback locales. For example, if we add the line <code>config.i18n.fallbacks = [:en]</code> to <code>config/application.rb</code>, the above test will pass, but I don't think that should be the solution because from what I've observed until now, we add the en version of the locale to all locale files (which is healthier from point of view).</p>
<p>Attached the patch that updates the gem version and fixes the failing test. The safest way is to schedule this update for <a class="version" href="https://www.redmine.org/versions/127">4.1.0</a> in order to have time to catch missing translation keys (if exists).</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=884192018-11-17T15:22:17ZMarius BĂLTEANU
<ul></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>[...] but I don't think that should be the solution because from what I've observed until now, we add the en version of the locale to all locale files (which is healthier from point of view).</p>
</blockquote>
<p>It seems that are some missing keys.</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=899792019-02-10T15:52:31ZMarius BĂLTEANU
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul><p>i18n now is at v1.5.3 which supports only Ruby > 2.2. I'll work on this for <a class="version" href="https://www.redmine.org/versions/127">4.1.0</a></p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=900572019-02-11T22:46:27ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/22392">0001-Update-i18n-gem-to-1.5.3.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22392/0001-Update-i18n-gem-to-1.5.3.patch">0001-Update-i18n-gem-to-1.5.3.patch</a> added</li><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul><p>I've attached a new patch with a different fix, but I would like a review on the proposed changes even if all the existing tests <a href="https://gitlab.com/marius-balteanu/redmine/-/jobs/159806408" class="external">pass</a></p>
<p>The failing test from <a class="changeset" title="Gemfile: pin i18n version 0.7.0 i18n 0.8.0 causes error. <pre> Redmine::I18nTest#test_languages..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/16324">r16324</a> was generated by a change to the <code>exists?</code> method which returns true when a fallback exists (please see <a class="external" href="https://github.com/ruby-i18n/i18n/pull/326">https://github.com/ruby-i18n/i18n/pull/326</a>).</p>
<p>In my note 3, I wasn't able to reproduce the failing test because the fallback was not enabled.</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=900582019-02-11T22:48:24ZMarius BĂLTEANU
<ul></ul><p>One more thing, in the future, we can change back to <code>exists?</code> method if the <a class="external" href="https://github.com/ruby-i18n/i18n/issues/365">https://github.com/ruby-i18n/i18n/issues/365</a> will be implemented.</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=901262019-02-14T09:16:55ZGo MAEDA
<ul><li><strong>Blocked by</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/30356">Feature #30356</a>: Drop Ruby 2.2 support</i> added</li></ul> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=902882019-02-19T10:30:47ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update i18n gem</i> to <i>Update i18n gem (~> 1.5.3)</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you for writing the patch.</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=905452019-03-04T05:09:40ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>i18n 1.6.0 has been released on 2019-03-03.<br /><a class="external" href="https://rubygems.org/gems/i18n/versions/1.6.0">https://rubygems.org/gems/i18n/versions/1.6.0</a></p>
<p>I confirmed that it passes all tests. We can update i18n to ~> 1.6.0.</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=905522019-03-04T08:35:55ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Update i18n gem (~> 1.5.3)</i> to <i>Update i18n gem (~> 1.6.0)</i></li><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Updated i18n to 1.6 in <a class="changeset" title="Update i18n gem to 1.6 (#29946)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/17921">r17921</a>.</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=918552019-05-19T13:28:04ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/31384">Patch #31384</a>: Remove custom lazy loading of i18n files</i> added</li></ul> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=918582019-05-19T13:28:54ZGo MAEDA
<ul><li><strong>Related to</strong> deleted (<i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/31384">Patch #31384</a>: Remove custom lazy loading of i18n files</i>)</li></ul> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=918602019-05-19T13:29:07ZGo MAEDA
<ul><li><strong>Blocked by</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/31384">Patch #31384</a>: Remove custom lazy loading of i18n files</i> added</li></ul> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=918612019-05-19T13:30:53ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p><a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Remove custom lazy loading of i18n files (Closed)" href="https://www.redmine.org/issues/31384">#31384</a> has been reported for this change.</p> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=924712019-06-20T08:42:53ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul> Redmine - Feature #29946: Update i18n gem (~> 1.6.0)https://www.redmine.org/issues/29946?journal_id=974272020-04-22T05:23:12ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/33334">Defect #33334</a>: bump i18n for advisory: CVE-2014-10077 </i> added</li></ul>