https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-04-26T05:22:49ZRedmineRedmine - Defect #30431: Useless "Delete issues" tracker permission is shown on the role page for Anonymous and Non-memberhttps://www.redmine.org/issues/30431?journal_id=913492019-04-26T05:22:49ZYuichi HARADA
<ul><li><strong>File</strong> <a href="/attachments/22878">30431.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22878/30431.patch">30431.patch</a> added</li></ul><p>It was displayed "Delete issues" column in the tracker permission table on the role page because it was not confirmed the settable permissions of the role.<br />I attached a patch.</p> Redmine - Defect #30431: Useless "Delete issues" tracker permission is shown on the role page for Anonymous and Non-memberhttps://www.redmine.org/issues/30431?journal_id=913552019-04-26T07:01:35ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul> Redmine - Defect #30431: Useless "Delete issues" tracker permission is shown on the role page for Anonymous and Non-memberhttps://www.redmine.org/issues/30431?journal_id=938512019-09-22T05:33:55ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/23903">30431-v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23903/30431-v2.patch">30431-v2.patch</a> added</li><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>4.1.0</i></li></ul><p>LGTM but I propose a slight change as follows. Using <code>&</code> operator is simpler and much faster than using <code>delete_if</code>.</p>
<pre><code class="erb syntaxhl"><span class="cp"><%</span> <span class="n">permissions</span> <span class="o">=</span> <span class="p">[</span><span class="ss">:view_issues</span><span class="p">,</span> <span class="ss">:add_issues</span><span class="p">,</span> <span class="ss">:edit_issues</span><span class="p">,</span> <span class="ss">:add_issue_notes</span><span class="p">,</span> <span class="ss">:delete_issues</span><span class="p">]</span> <span class="o">&</span> <span class="n">setable_permissions</span><span class="p">.</span><span class="nf">collect</span><span class="p">(</span><span class="o">&</span><span class="ss">:name</span><span class="p">)</span> <span class="cp">%></span>
</code></pre>
<p>Setting the target version to 4.1.0.</p> Redmine - Defect #30431: Useless "Delete issues" tracker permission is shown on the role page for Anonymous and Non-memberhttps://www.redmine.org/issues/30431?journal_id=938832019-09-24T04:19:28ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patch. Thank you for fixing this issue.</p>