https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-04-02T16:01:36ZRedmineRedmine - Defect #30441: Attachments with Unicode uppercase names are not shown in wiki pageshttps://www.redmine.org/issues/30441?journal_id=910802019-04-02T16:01:36ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next minor release</i></li></ul> Redmine - Defect #30441: Attachments with Unicode uppercase names are not shown in wiki pageshttps://www.redmine.org/issues/30441?journal_id=910812019-04-02T16:02:34ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/27780">Defect #27780</a>: Case-insensitive matching fails for Unicode filenames when referring to attachments in text formatting</i> added</li></ul> Redmine - Defect #30441: Attachments with Unicode uppercase names are not shown in wiki pageshttps://www.redmine.org/issues/30441?journal_id=911942019-04-10T23:30:14ZGo MAEDA
<ul></ul><p>Evgeny Seliverstov wrote:</p>
<blockquote>
<p>The problem can be fixed easily just by avoiding calling <code>String#downcase</code> in <code>ApplicationHelper#parse_inline_attachments</code>.<br />Comparing ASCII filenames with any cases should still work without changes (because of <code>casecmp</code>).<br />Comparing Unicode filenames should work fine because we do not bother with changing filename at all.</p>
</blockquote>
<p>I agree. The <code>downcase</code> method in <code>ApplicationHelper#parse_inline_attachments</code> is not necessary because the case-insensitive match is performed for <code>filename</code> variable in Attachment#latest_attach. I think the <code>downcase</code> method should have been removed when implementing <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Use String#casecmp for case insensitive comparison (Closed)" href="https://www.redmine.org/issues/20369">#20369</a>.</p> Redmine - Defect #30441: Attachments with Unicode uppercase names are not shown in wiki pageshttps://www.redmine.org/issues/30441?journal_id=912052019-04-12T04:30:21ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/22797">test-30441.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22797/test-30441.patch">test-30441.patch</a> added</li><li><strong>Target version</strong> changed from <i>Candidate for next minor release</i> to <i>4.0.4</i></li></ul><p>Rewrote the test.</p> Redmine - Defect #30441: Attachments with Unicode uppercase names are not shown in wiki pageshttps://www.redmine.org/issues/30441?journal_id=912072019-04-12T05:43:46ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Attachments with unicode uppercase names are not shown in wiki</i> to <i>Attachments with Unicode uppercase names are not shown in wiki pages</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Committed the patches. Thank you for reporting and fixing the issue.</p> Redmine - Defect #30441: Attachments with Unicode uppercase names are not shown in wiki pageshttps://www.redmine.org/issues/30441?journal_id=912442019-04-18T14:32:07ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>