Defect #30474
IssuesControllerTest#test_index_sort_by_total_estimated_hours tests practically nothing
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Code cleanup/refactoring | |||
Target version: | 4.1.0 | |||
Resolution: | Affected version: |
Description
IssuesControllerTest#test_index_sort_by_total_estimated_hours tries to test if the issues list is sorted by estimated hours, but it actually does not test anything.
In test/fixtures/issues.yml, all objects don't have estimate_hours value. As a result, the content of the array hours
is always [nil, nil, nil, nil. nil]. Since all values in the array are the same, you cannot check whether the sorting works well or not.
def test_index_sort_by_total_estimated_hours
get :index, :params => {
:sort => 'total_estimated_hours:desc'
}
assert_response :success
hours = issues_in_list.map(&:total_estimated_hours)
assert_equal hours.sort.reverse, hours
end
Associated revisions
IssuesControllerTest#test_index_sort_by_total_estimated_hours tests nothing (#30474).
Patch by Go MAEDA.
History
#1
Updated by Go MAEDA 11 months ago
- File fix-30474.diff
added
Here is a patch to fix this. After applying this patch, the value of hours
array is [200.0, 2.0, 1.0, 0.5]
and the test can properly check the order of issues.