https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-03-13T15:50:53ZRedmineRedmine - Patch #31022: Always use HTTPS when accessing gravatar.comhttps://www.redmine.org/issues/31022?journal_id=907222019-03-13T15:50:53ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul> Redmine - Patch #31022: Always use HTTPS when accessing gravatar.comhttps://www.redmine.org/issues/31022?journal_id=907362019-03-14T07:09:48ZGo MAEDA
<ul></ul><p>This updated patch is frozen string literals ready.</p>
<pre><code class="diff syntaxhl"><span class="gh">Index: lib/plugins/gravatar/lib/gravatar.rb
===================================================================
</span><span class="gd">--- lib/plugins/gravatar/lib/gravatar.rb (revision 17946)
</span><span class="gi">+++ lib/plugins/gravatar/lib/gravatar.rb (working copy)
</span><span class="p">@@ -1,3 +1,5 @@</span>
<span class="gi">+# frozen_string_literal: true
+
</span> require 'digest/md5'
require 'cgi'
@@ -61,7 +63,7 @@
# Returns the base Gravatar URL for the given email hash
def gravatar_api_url(hash)
<span class="gd">- "//www.gravatar.com/avatar/#{hash}"
</span><span class="gi">+ 'https://www.gravatar.com/avatar/' + hash.to_s
</span> end
# Return the gravatar URL for the given email address.
</code></pre> Redmine - Patch #31022: Always use HTTPS when accessing gravatar.comhttps://www.redmine.org/issues/31022?journal_id=907502019-03-15T03:14:48ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li></ul><p>Committed.</p> Redmine - Patch #31022: Always use HTTPS when accessing gravatar.comhttps://www.redmine.org/issues/31022?journal_id=915122019-05-04T01:53:04ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/9112">Feature #9112</a>: Libravatar and Gravatar-compatible servers support</i> added</li></ul> Redmine - Patch #31022: Always use HTTPS when accessing gravatar.comhttps://www.redmine.org/issues/31022?journal_id=916342019-05-08T20:38:07ZMarius BÄ‚LTEANU
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>We should remove the <code>:ssl</code> option because it is not used anymore:</p>
<pre><code class="diff syntaxhl"><span class="p">vagrant@jessie:/vagrant/project/redmine$ git diff lib/plugins/gravatar/
</span><span class="gh">diff --git a/lib/plugins/gravatar/lib/gravatar.rb b/lib/plugins/gravatar/lib/gravatar.rb
index aa8500b..f368b99 100644
</span><span class="gd">--- a/lib/plugins/gravatar/lib/gravatar.rb
</span><span class="gi">+++ b/lib/plugins/gravatar/lib/gravatar.rb
</span><span class="p">@@ -34,9 +34,6 @@</span> module GravatarHelper
# The class to assign to the img tag for the gravatar.
:class => 'gravatar',
<span class="gd">-
- # Whether or not to display the gravatars using HTTPS instead of HTTP
- :ssl => false,
</span> }
</code></pre> Redmine - Patch #31022: Always use HTTPS when accessing gravatar.comhttps://www.redmine.org/issues/31022?journal_id=916352019-05-08T21:46:40ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Marius BALTEANU wrote:</p>
<blockquote>
<p>We should remove the <code>:ssl</code> option because it is not used anymore:</p>
<p>[...]</p>
</blockquote>
<p>Committed the fix. Thank you for pointing it out.</p>