Project

General

Profile

Actions

Defect #31063

closed

Can't uncheck Gantt chart options of custom queries

Added by Mizuki ISHIKAWA about 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Gantt
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If you set the draw_progress_line option and the draw_related_issues option of the custom query to true, you can not change it to false from the screen.

I think this problem is due to the influence of #29701.


Files

options.png (105 KB) options.png Mizuki ISHIKAWA, 2019-03-20 03:41

Related issues

Related to Redmine - Defect #29701: Custom queries are broken by updating with nil parameter valuesClosedGo MAEDA

Actions
Actions #1

Updated by Mizuki ISHIKAWA about 5 years ago

I think that the cause is that the parameter is nil when the check box is false.
The solution is to make the parameter '0' if the checkbox is false by the hidden tag.

diff --git a/app/views/queries/_form.html.erb b/app/views/queries/_form.html.erb
index f424e103cd..7f79906efb 100644
--- a/app/views/queries/_form.html.erb
+++ b/app/views/queries/_form.html.erb
@@ -40,6 +40,8 @@
 <% else %>
 <fieldset id="options"><legend><%= l(:label_options) %></legend>
   <p><label><%= l(:button_show) %></label>
+  <%= hidden_field_tag 'query[draw_relations]', '0' %>
+  <%= hidden_field_tag 'query[draw_progress_line]', '0' %>
   <label class="inline"><%= check_box_tag "query[draw_relations]", "1", @query.draw_relations %> <%= l(:label_related_issues) %></label>
   <label class="inline"><%= check_box_tag "query[draw_progress_line]", "1", @query.draw_progress_line %> <%= l(:label_gantt_progress_line) %></label>
   </p>

Actions #2

Updated by Go MAEDA about 5 years ago

  • Target version set to Candidate for next minor release
Actions #3

Updated by Go MAEDA about 5 years ago

  • Related to Defect #29701: Custom queries are broken by updating with nil parameter values added
Actions #4

Updated by Go MAEDA about 5 years ago

  • Target version changed from Candidate for next minor release to 4.0.3

Setting the target version to 4.0.3.

Actions #5

Updated by Jean-Philippe Lang almost 5 years ago

  • Subject changed from Can't change Ganttchart options of custom query to false to Can't uncheck Gantt chart options of custom queries
  • Category set to Gantt
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed
Actions #6

Updated by Jean-Philippe Lang almost 5 years ago

Committed, thanks.

Actions #7

Updated by Jean-Philippe Lang almost 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF