Patch #31065

Fix tests that has incorrect verification target

Added by Mizuki ISHIKAWA 2 months ago. Updated 15 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:-

Description

These two tests check Mailer.deliver_issue_add.
I think those tests should check Mailer.deliver_issue_edit as described in the title.

This patch fixes those tests.

fix-13111-tests.patch Magnifier (1.47 KB) Mizuki ISHIKAWA, 2019-03-20 07:43


Related issues

Related to Redmine - Feature #13111: New setting to include the status changes in issue mail n... Closed 2008-02-04

Associated revisions

Revision 18134
Added by Go MAEDA 15 days ago

Fix tests to test Mailer.deliver_issue_edit instead of Mailer.deliver_issue_add (#13111, #31065).

Patch by Mizuki ISHIKAWA.

History

#1 Updated by Go MAEDA 2 months ago

  • Related to Feature #13111: New setting to include the status changes in issue mail notifications subject added

#2 Updated by Go MAEDA 2 months ago

Those two tests are added by #13111 for upcoming 4.1.0.

#3 Updated by Go MAEDA 15 days ago

  • Assignee set to Marius BALTEANU

Marius, could you check the attached fix?

#4 Updated by Marius BALTEANU 15 days ago

  • Assignee changed from Marius BALTEANU to Go MAEDA

Mizuki, you're right, the tests should check Mailer.deliver_issue_edit, thanks for catching and fixing this.

Go, it can be committed as part of #13111.

#5 Updated by Go MAEDA 15 days ago

  • Status changed from New to Closed

Committed the fix. Thank you all for working on this issue.

Also available in: Atom PDF