Patch #31385

Formating toolbar : new color tools

Added by Jérôme BATAILLE 3 months ago. Updated 2 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:Candidate for next major release

Description

This patch provides 2 new tools with a new color palette to change sélection color :
  • text color
  • background color

RM_31385_formating_toolbar_color_tools_SVN.diff Magnifier (4.3 KB) Jérôme BATAILLE, 2019-05-18 14:49

bt_bgcolor.png (429 Bytes) Jérôme BATAILLE, 2019-05-18 14:49

bt_color.png (699 Bytes) Jérôme BATAILLE, 2019-05-18 14:49

text_color_and_background.png (8.75 KB) Jérôme BATAILLE, 2019-05-18 15:06

text_color.png (14.8 KB) Jérôme BATAILLE, 2019-05-18 15:06

RM_31385_formating_toolbar_color_tools_SVN.diff Magnifier (6.25 KB) Jérôme BATAILLE, 2019-05-21 01:33

RM_31385_formating_toolbar_color_tools_SVN.diff Magnifier (6.81 KB) Jérôme BATAILLE, 2019-05-21 23:53

RM_31385_formating_toolbar_color_tools2_SVN.diff Magnifier (8.36 KB) Jérôme BATAILLE, 2019-05-24 03:08

History

#1 Updated by Jérôme BATAILLE 3 months ago

The correct issue title should : Formating toolbar : new color tools

#2 Updated by Go MAEDA 3 months ago

  • Subject changed from Wiki formating tous : new color tools to Formating toolbar : new color tools

#3 Updated by Jérôme BATAILLE 3 months ago

Here is the patch, and the 2 new images to put in public/images/jstoolbar/

This patch does not manage the case when we want background an text color at the same time.

#5 Updated by Jérôme BATAILLE 3 months ago

Here is a new patch managing some mixed cases of color / background color.

Detects if selected text already contains a css tag.
  • If tag contains the css we want, replace the color.
  • If not, add the css to the other tags.

#6 Updated by Jérôme BATAILLE 3 months ago

Fixed previous patch.

Managed more mixed color / background color tags.

@Go thanks to have renamed the issue subject

#7 Updated by Go MAEDA 3 months ago

The patch seems supports only Textile but Markdown. Since Redmine supports both Textile and Markdown, I think the patch should also support Markdown.

#8 Updated by Jérôme BATAILLE 3 months ago

Hi, I am going to provide the patch for <span style color="green">Markdown</span>

Now that Textile is OK.

#9 Updated by Jérôme BATAILLE 3 months ago

Hi, here is a patch to apply after the previous patch.
It includes code refactoring and Markdown support.
For Markdown, html filter must be disabled (C.f. http://www.redmine.org/boards/2/topics/56096?r=57052#message-57052).

One remark about responsive design, the tools icons div has no horizontal scrollbar enabled. Thus some icons on the right can disappear with smaller window size.

#10 Updated by Go MAEDA 3 months ago

  • Target version set to Candidate for next major release

#11 Updated by Jérôme BATAILLE 2 months ago

Thanks Go to have proposed this for the next major release.

Also available in: Atom PDF