Patch #31385

Formating toolbar : new color tools

Added by Jérôme BATAILLE 7 months ago. Updated 3 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:Candidate for next major release

Description

This patch provides 2 new tools with a new color palette to change sélection color :
  • text color
  • background color

RM_31385_formating_toolbar_color_tools_SVN.diff Magnifier (4.3 KB) Jérôme BATAILLE, 2019-05-18 14:49

bt_bgcolor.png (429 Bytes) Jérôme BATAILLE, 2019-05-18 14:49

bt_color.png (699 Bytes) Jérôme BATAILLE, 2019-05-18 14:49

text_color_and_background.png (8.75 KB) Jérôme BATAILLE, 2019-05-18 15:06

text_color.png (14.8 KB) Jérôme BATAILLE, 2019-05-18 15:06

RM_31385_formating_toolbar_color_tools_SVN.diff Magnifier (6.25 KB) Jérôme BATAILLE, 2019-05-21 01:33

RM_31385_formating_toolbar_color_tools_SVN.diff Magnifier (6.81 KB) Jérôme BATAILLE, 2019-05-21 23:53

RM_31385_formating_toolbar_color_tools2_SVN.diff Magnifier (8.36 KB) Jérôme BATAILLE, 2019-05-24 03:08

RM_31385_formating_toolbar_color_tools_jstoolbar_SVN.diff Magnifier (4.44 KB) Jérôme BATAILLE, 2019-09-16 16:48

History

#1 Updated by Jérôme BATAILLE 7 months ago

The correct issue title should : Formating toolbar : new color tools

#2 Updated by Go MAEDA 7 months ago

  • Subject changed from Wiki formating tous : new color tools to Formating toolbar : new color tools

#3 Updated by Jérôme BATAILLE 7 months ago

Here is the patch, and the 2 new images to put in public/images/jstoolbar/

This patch does not manage the case when we want background an text color at the same time.

#5 Updated by Jérôme BATAILLE 7 months ago

Here is a new patch managing some mixed cases of color / background color.

Detects if selected text already contains a css tag.
  • If tag contains the css we want, replace the color.
  • If not, add the css to the other tags.

#6 Updated by Jérôme BATAILLE 7 months ago

Fixed previous patch.

Managed more mixed color / background color tags.

@Go thanks to have renamed the issue subject

#7 Updated by Go MAEDA 7 months ago

The patch seems supports only Textile but Markdown. Since Redmine supports both Textile and Markdown, I think the patch should also support Markdown.

#8 Updated by Jérôme BATAILLE 7 months ago

Hi, I am going to provide the patch for <span style color="green">Markdown</span>

Now that Textile is OK.

#9 Updated by Jérôme BATAILLE 7 months ago

Hi, here is a patch to apply after the previous patch.
It includes code refactoring and Markdown support.
For Markdown, html filter must be disabled (C.f. http://www.redmine.org/boards/2/topics/56096?r=57052#message-57052).

One remark about responsive design, the tools icons div has no horizontal scrollbar enabled. Thus some icons on the right can disappear with smaller window size.

#10 Updated by Go MAEDA 7 months ago

  • Target version set to Candidate for next major release

#11 Updated by Jérôme BATAILLE 6 months ago

Thanks Go to have proposed this for the next major release.

#12 Updated by Dmitry Makurin 3 months ago

Two latest patches don't work without:

Index: public/javascripts/jstoolbar/jstoolbar.js
===================================================================
--- public/javascripts/jstoolbar/jstoolbar.js    (date 1568621686000)
+++ public/javascripts/jstoolbar/jstoolbar.js    (date 1568636186385)
@@ -373,12 +373,12 @@
         }

         if (typeof(fn) == 'function') {
-            res = (sel) ? fn.call(this,sel) : fn('');
+            res = (sel) ? fn.call(this,sel,prefix,suffix) : fn('');
         } else {
             res = (sel) ? sel : '';
         }

-        subst = prefix + res + suffix;
+        subst = res;

         if (typeof(document["selection"]) != "undefined") {
             document.selection.createRange().text = subst;

Am I missing something? That change have never been mentioned in any of related patches.

#13 Updated by Jérôme BATAILLE 3 months ago

Hello, you're right changes to jstoolbar.js were missing.

Here is the full SVN diff for this file.

Also available in: Atom PDF