Patch #31640

Add clear query icon next to selected query in sidebar

Added by Marius BALTEANU about 1 month ago. Updated about 1 month ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:Candidate for next major release

Description

Now that "All issues" link was removed from the sidebar, we should have an easier way in sidebar to clear the current query.

My proposal is to add a Clear link next to selected query link:

On hover:

clear_query.png (43.4 KB) Marius BALTEANU, 2019-06-29 13:42

clear_query_hover.png (45.2 KB) Marius BALTEANU, 2019-06-29 13:43

0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch Magnifier (3.64 KB) Marius BALTEANU, 2019-06-29 13:57

clear_with_close.png (41.2 KB) Marius BALTEANU, 2019-07-01 00:07

0001-Add-clear-link-icon-for-selected-query-in-sidebar_2.patch Magnifier (3.64 KB) Marius BALTEANU, 2019-07-01 00:09


Related issues

Related to Redmine - Patch #30294: Move the links (View all issues, Summary, Import) from th... Closed

History

#1 Updated by Marius BALTEANU about 1 month ago

  • File 0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch added

#2 Updated by Marius BALTEANU about 1 month ago

  • Related to Patch #30294: Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown added

#3 Updated by Marius BALTEANU about 1 month ago

  • File deleted (0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch)

#4 Updated by Marius BALTEANU about 1 month ago

Fixed some Rubocop warnings.

#6 Updated by Go MAEDA about 1 month ago

Although I understand the reason why you use (reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to (close.png).

#7 Updated by Marius BALTEANU about 1 month ago

Go MAEDA wrote:

Although I understand the reason why you use (reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to (close.png).

Agree, but (close.png) icon is not so visible:

Attached the updated patch. Go Maeda, if you have a better idea, please fell free to update my patch.

Also available in: Atom PDF