Project

General

Profile

Actions

Defect #31779

closed

Total estimated time column shown even when estimated time field is deactivated

Added by Felix Schäfer over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Issues list
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Even when the estimated time field is deactivated in the trackers available in the issue list the total estimated time column is available. This diff patches this issue, though maybe fixing it in Tracker.disabled_core_fields would be better.

--- a/app/models/issue_query.rb
+++ b/app/models/issue_query.rb
@@ -288,6 +288,7 @@ class IssueQuery < Query
     end

     disabled_fields = Tracker.disabled_core_fields(trackers).map {|field| field.sub(/_id$/, '')}
+    disabled_fields << "total_estimated_hours" if disabled_fields.include?("estimated_hours")
     @available_columns.reject! {|column|
       disabled_fields.include?(column.name.to_s)
     }



Files

31779_add_test.patch (1.12 KB) 31779_add_test.patch Yuichi HARADA, 2019-09-18 06:58
Actions #1

Updated by Kevin Fischer over 4 years ago

Since it's not a "core field" in the original sense, fixing it here seems good to me
+1

Actions #2

Updated by Go MAEDA over 4 years ago

  • Target version set to 4.0.5
Actions #3

Updated by Yuichi HARADA over 4 years ago

Felix Schäfer wrote:

Even when the estimated time field is deactivated in the trackers available in the issue list the total estimated time column is available. This diff patches this issue, though maybe fixing it in Tracker.disabled_core_fields would be better.

[...]

I created a test. I attached a patch.

Actions #4

Updated by Go MAEDA over 4 years ago

  • Target version changed from 4.0.5 to 3.4.12
Actions #5

Updated by Jean-Philippe Lang over 4 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks.

Actions

Also available in: Atom PDF