https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292019-09-04T17:31:53ZRedmineRedmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=935052019-09-04T17:31:53ZAnonymous
<ul><li><strong>File</strong> <a href="/attachments/23780">roundedlisttables.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23780/roundedlisttables.png">roundedlisttables.png</a> added</li><li><strong>File</strong> <a href="/attachments/23781">roundedlisttables2.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23781/roundedlisttables2.png">roundedlisttables2.png</a> added</li></ul><p><img src="https://www.redmine.org/attachments/download/23780/roundedlisttables.png" style="border: 1px solid;border-color: #ccc;width: 99%;" alt="" /></p>
<p><img src="https://www.redmine.org/attachments/download/23781/roundedlisttables2.png" style="border: 1px solid;border-color: #ccc;width: 99%;" alt="" /></p> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=937862019-09-18T15:10:28ZBernhard Rohloff
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32013">Patch #32013</a>: Rounded corners of the main menu</i> added</li></ul> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=939792019-09-27T14:45:09ZGo MAEDA
<ul></ul><p>The patch removes <code>border-collapse</code> property. Do you think it is OK? (sorry if this is a stupid question. I am not a CSS expert).</p> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=939802019-09-27T15:03:34ZAnonymous
<ul></ul><p>Go, roundness with <strong>border-radius</strong> on table elements can't seem to be achieved if <strong>border-collapse: collapse;</strong> is present, so I cleared it in a favor of <strong>border-spacing: 0;</strong> for this reason, which it did seem like does the same thing, only, unlike <strong>border-collapse</strong>, it doesn't block <strong>border-radius</strong> to be applied.</p> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=939822019-09-27T15:26:31ZBernhard Rohloff
<ul></ul><p>Yes, as Antonio wrote, it's necessary to get the border radius and <code>border-spacing: 0;</code> compensates it.<br />One notice of caution: I played with the border radius and found out that the cells don't get clipped to the round shape. Maybe an additional <code>overflow: hidden;</code> is missing here.</p> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=939862019-09-27T18:46:24ZAnonymous
<ul><li><strong>File</strong> <a href="/attachments/23978">rounded-tables(excl-calendar+gantt+mypage)-v2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/23978/rounded-tables(excl-calendar+gantt+mypage)-v2.patch">rounded-tables(excl-calendar+gantt+mypage)-v2.patch</a> added</li></ul><p>Bernhard Rohloff wrote:</p>
<blockquote>
<p>Maybe an additional <code>overflow: hidden;</code> is missing here.</p>
</blockquote>
<p>Not that it's a biggie, as our border radius doesn't seem to be that big anyway, for cells under to stick out, it's only 3px after all, but here is the patch with hidden overflow just in case ;-)</p> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=939972019-09-28T00:07:09ZGo MAEDA
<ul><li><strong>Subject</strong> changed from <i>Rounded corners on table/list elements</i> to <i>Rounded corners on table.list elements</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Go MAEDA</i></li><li><strong>Target version</strong> set to <i>4.1.0</i></li></ul><p>Committed the patch. Thank you for improving Redmine.</p> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=940122019-09-28T13:48:26ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>I will revert this change because the change caused other changes such as <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Rounded corners on table.cal (Closed)" href="https://www.redmine.org/issues/32165">#32165</a> and <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Rounded corners on table.gantt-table (New)" href="https://www.redmine.org/issues/32166">#32166</a> and I cannot predict how much the impact will spread further.</p> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=940132019-09-28T14:22:43ZAnonymous
<ul></ul><p>Go MAEDA wrote:</p>
<blockquote>
<p>I will revert this change because the change caused other changes such as <a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Rounded corners on table.cal (Closed)" href="https://www.redmine.org/issues/32165">#32165</a> and <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Rounded corners on table.gantt-table (New)" href="https://www.redmine.org/issues/32166">#32166</a> and I cannot predict how much the impact will spread further.</p>
</blockquote>
<p><a class="issue tracker-3 status-5 priority-4 priority-default closed" title="Patch: Rounded corners on table.cal (Closed)" href="https://www.redmine.org/issues/32165">#32165</a> and <a class="issue tracker-3 status-1 priority-4 priority-default" title="Patch: Rounded corners on table.gantt-table (New)" href="https://www.redmine.org/issues/32166">#32166</a> would be the last patches for the tables anyway, and it's really to be over with now after those two really small patches :D<br />Just calendar and gantt were styled and structured differently than list.tables and also each-other, hence why required separate patches.</p>
<p>Either way, I think it's better to keep it like that rather than reverting it, since gantt and calendar seem like the only exceptions anyway. Then deliver those two in later versions (if release will happen before they ready) if necessary.<br />We should probably add them as related too.</p> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=941022019-10-02T14:42:08ZGo MAEDA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=941112019-10-03T01:41:21ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32165">Patch #32165</a>: Rounded corners on table.cal</i> added</li></ul> Redmine - Patch #32014: Rounded corners on table.list elementshttps://www.redmine.org/issues/32014?journal_id=941132019-10-03T01:41:29ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-1 priority-4 priority-default" href="/issues/32166">Patch #32166</a>: Rounded corners on table.gantt-table</i> added</li></ul>