Patch #32166

Rounded corners on table.gantt-table

Added by Antonio McDeal 3 months ago. Updated 2 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:Candidate for next major release

Description

This patch is a follow up to #32014 to add 3px border-radius to gantt table.

roundness-gantt-table.patch Magnifier (731 Bytes) Antonio McDeal, 2019-09-28 14:42

unnecessary-line-before@2x.png (3 KB) Go MAEDA, 2019-10-03 14:22

unnecessary-line-after@2x.png (16.4 KB) Go MAEDA, 2019-10-03 14:22


Related issues

Related to Redmine - Patch #32014: Rounded corners on table.list elements Closed

History

#1 Updated by Go MAEDA 2 months ago

  • Target version set to Candidate for next major release

#2 Updated by Go MAEDA 2 months ago

  • Related to Patch #32014: Rounded corners on table.list elements added

#3 Updated by Go MAEDA 2 months ago

Thank you for posting the patch.

But I found a small issue. You will see an unnecessary vertical line after applying the patch. Please see the screenshots below.

Before:

After:

#4 Updated by Antonio McDeal 2 months ago

Go MAEDA wrote:

Thank you for posting the patch.
But I found a small issue. You will see an unnecessary vertical line after applying the patch. Please see the screenshots below.

Thanks for pointing it out. I did this on purpose, to mark the gantt containing parent table (table.gantt-table), so it would kind of be exactly like calendar in styling, or else in the most zoomed-out state, or when you choose to display a low amount of months ahead, gantt table ends up too far from the the sidebar, and there is bare emptiness in between, which I didn't think looked good.
Maybe I should have also colored table.gantt-table with slight gray for it to look a bit more distinct.

I will post alternative patch though which just doesn't add border to the parent container (table.gantt-table), but instead changes the border of the gantt itself.

Also available in: Atom PDF