Project

General

Profile

Actions

Defect #32307

closed

AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png fails if ImageMagick convert is not available

Added by Go MAEDA over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

To reproduce it, set invalid value to imagemagick_convert_command in configuration.yml and run attachments_controller_test.rb.

Failure:
AttachmentsControllerTest#test_thumbnail_for_pdf_should_be_png [/Users/maeda/redmines/redmine-trunk/test/functional/attachments_controller_test.rb:478]:
Expected response to be a <2XX: success>, but was a <404: Not Found>
Response body:

bin/rails test test/functional/attachments_controller_test.rb:472

The test should be skipped if convert command is not available.


Files


Related issues

Related to Redmine - Feature #22481: Show thumbnails for PDF attachmentsClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA over 4 years ago

  • Status changed from New to Closed
  • Target version deleted (Candidate for next major release)
  • Resolution set to Fixed

Committed the patch as a part of #22481.

Actions #2

Updated by Marius BÄ‚LTEANU over 4 years ago

  • Related to Feature #22481: Show thumbnails for PDF attachments added
Actions

Also available in: Atom PDF