Project

General

Profile

Actions

Defect #3715

closed

Login page should not show projects link and search box if authentication is required

Added by Lucas Panjer over 14 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
UI
Target version:
Start date:
2009-08-06
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If authentication is required then you can't reach any other page unless you have logged in. To avoid confusion for users and for a cleaner login page, the "Projects" link and "Search" box in the header menu should not appear. Any contribution to the header menu from plugins should also be suppressed.


Files

3715-1.diff (1.16 KB) 3715-1.diff Lucas Panjer, 2009-09-04 08:37
3715-2.patch (1.65 KB) 3715-2.patch Lucas Panjer, 2009-09-09 10:03

Related issues

Is duplicate of Redmine - Patch #2321: Hide search textbox if authorization requiredClosed2008-12-12

Actions
Actions #1

Updated by Lucas Panjer over 14 years ago

simple approach attached in diff

Actions #2

Updated by Eric Davis over 14 years ago

Nice simple implementation. It would be good to add a short integration test for this to make sure they stay hidden in the future.

Actions #3

Updated by Lucas Panjer over 14 years ago

Added a test. The menu_manager test suite seemed like a roughly appropriate spot for it.
Adjusted change to remove the entire #quick-search. I don't see any point in leaving the div with no form.

The other approach to this issue is to ask each plugin to respect the login_required setting and adjust Redmine in the menu manager somewhere. This approach would preserve the ability to show menu items to unauthenticated users when login is required, which the approach in this patch does not allow.

Actions #4

Updated by Jean-Philippe Lang over 14 years ago

  • Category set to UI
  • Priority changed from Normal to Low
Actions #5

Updated by Etienne Massip about 13 years ago

  • Target version set to Candidate for next major release
Actions #6

Updated by Jean-Philippe Lang about 13 years ago

  • Status changed from New to Closed
  • Target version changed from Candidate for next major release to 1.2.0
  • Resolution set to Fixed

Patch committed in r5007. Test slightly edited and moved to layout_test.

Actions #7

Updated by Denis Tomashenko about 13 years ago

#2321 - this can be closed too

Actions #8

Updated by Etienne Massip about 13 years ago

Done, thanks.

Actions

Also available in: Atom PDF