Patch #3731

Incoming mail handler : Allow spaces between keywords and colon

Added by Thomas Recloux about 8 years ago. Updated almost 8 years ago.

Status:ClosedStart date:2009-08-12
Priority:NormalDue date:
Assignee:Eric Davis% Done:

100%

Category:Email receiving
Target version:0.8.5

Description

Actually, the keyword syntax for incoming mail is "keyword: value".
Ex : Project: foo

Some mail clients like Outlook are inserting one space before the colon symbol, causing the keywords to be ignored by Redmine.

This modification allows spaces between the keyword and the colon symbol.
Ex : Project : foo

Built against the trunk in revision 2836
Tested on the trunk and on the 0.8.4 tag
Includes unit test

patch_incoming_mail_parsing.diff Magnifier (4.54 KB) Thomas Recloux, 2009-08-12 15:15

Associated revisions

Revision 2837
Added by Eric Davis about 8 years ago

Allow spaces between the keyword and colon in incoming mail. (#3731)

Revision 2838
Added by Eric Davis about 8 years ago

Added missing fixture file from r2837 (#3731)

History

#1 Updated by Eric Davis about 8 years ago

  • Status changed from New to Resolved
  • Assignee set to Eric Davis
  • Target version set to 0.8.5
  • % Done changed from 0 to 100

Thank you, your patch was great. Applied in r2837.

#2 Updated by Thomas Recloux about 8 years ago

Thanks for applying the patch so quickly.

I think you may have forgot to add the ticket_with_spaces_between_attribute_and_separator.eml test file ?

#3 Updated by Eric Davis about 8 years ago

Thomas Recloux wrote:

I think you may have forgot to add the ticket_with_spaces_between_attribute_and_separator.eml test file ?

Oh thanks, it should be in r2838.

#4 Updated by Jean-Philippe Lang about 8 years ago

  • Status changed from Resolved to Closed

Merged in 0.8-stable in r2881.

#5 Updated by Jean-Philippe Lang almost 8 years ago

  • Category changed from Email notifications to Email receiving

Also available in: Atom PDF