https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292009-09-11T14:02:47ZRedmineRedmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=109132009-09-11T14:02:47ZCedric VINCENT
<ul></ul><p>Patch to apply against redmine-0.8.4</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=109202009-09-12T04:25:28ZEric Davis
<ul><li><strong>Category</strong> set to <i>Time tracking</i></li></ul><p>Thank you, that's a good feature. We'll need to update the patch to apply to trunk. I'm not sure if the edit time entries permission should be used or if a new one should be created.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=109342009-09-12T11:34:54ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>I think a new permission would be required if we add this feature.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=110782009-09-21T14:48:53ZCedric VINCENT
<ul><li><strong>File</strong> <a href="/attachments/2562">0002-Access-params-time_entry-only-if-editing-a-time-entr.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2562/0002-Access-params-time_entry-only-if-editing-a-time-entr.patch">0002-Access-params-time_entry-only-if-editing-a-time-entr.patch</a> added</li><li><strong>File</strong> <a href="/attachments/2563">0003-Allow-to-change-the-owner-a-protected-attribute-of-a.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2563/0003-Allow-to-change-the-owner-a-protected-attribute-of-a.patch">0003-Allow-to-change-the-owner-a-protected-attribute-of-a.patch</a> added</li></ul><p>Oops! There are two bugs in the previous patch, here come the corresponding fixes:</p>
<ol>
<li>Access params[:time_entry] only if editing a time entry. It fixes the error "ActiveRecord::RecordNotFound".</li>
<li>Allow to change the "owner" of a time entry. Previously, the "owner" was not changed because it is a protected attribute.</li>
</ol>
<p>Cheers,<br />Cedric.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=151292010-03-14T05:19:11ZOleg Volkov
<ul></ul><p>You can update the patch to version 0.9.3?</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=151322010-03-14T06:57:57ZOleg Volkov
<ul></ul><p>This patch is not entirely correct, since there is no information who (instead of the user) has made him the information. In addition, there is a need to create new questions and make comments from another user. Both questions are needed when the user is not possible to do it yourself, and he asked the operator to do so by phone.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=151332010-03-14T08:11:40ZOleg Volkov
<ul><li><strong>File</strong> <a href="/attachments/3364">Allow-the-current-user-to-record-the-time-spent-0.9.3.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3364/Allow-the-current-user-to-record-the-time-spent-0.9.3.patch">Allow-the-current-user-to-record-the-time-spent-0.9.3.patch</a> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=151342010-03-14T10:44:26ZOleg Volkov
<ul><li><strong>File</strong> <a href="/attachments/3365">time-spent-by-another-user-v.0.1.path</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3365/time-spent-by-another-user-v.0.1.path">time-spent-by-another-user-v.0.1.path</a> added</li></ul><p>This path is changed:<br />1. Allow change user only entry/edit "Spent time" (<a class="external" href="http://www.redmine.org/attachments/2520/timelog1.png">http://www.redmine.org/attachments/2520/timelog1.png</a>) and disabled from Issue Update (<a class="external" href="http://www.redmine.org/attachments/2521/timelog2.png">http://www.redmine.org/attachments/2521/timelog2.png</a>).<br />2. Select only users with permission to add record time. (Excluded admin!)</p>
<p>TODO: Logged real user name.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=152472010-03-18T11:04:58ZOleg Volkov
<ul><li><strong>File</strong> <a href="/attachments/3391">time-spent-by-another-user-v.0.2.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/3391/time-spent-by-another-user-v.0.2.patch">time-spent-by-another-user-v.0.2.patch</a> added</li></ul><p>I created a new version of the patch.<br />The patch is shorter.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=237122011-01-05T15:57:10ZArnaud Lesauvage
<ul></ul><p>I'm very interested in this patch. Is the patch submitted by Oleg still working ?<br />We are running redmine against trunk <a class="changeset" title="Use File#expand_path for require's in script/* for Ruby 1.9.2 compatibility. #4050 Since Ruby 1...." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4359">r4359</a>.</p>
<p>I still think this is a very useful feature. In our company, we have projects where the workers do not encode their spent times themselves.<br />Eric and Jean-Philippe both have shown interest in this so I am hopeful in seeing this integrated in trunk ?</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=266492011-03-21T07:45:10ZJack T
<ul><li><strong>File</strong> <a href="/attachments/5612">log-time-for-another-user.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5612/log-time-for-another-user.diff">log-time-for-another-user.diff</a> added</li></ul><p>Updated Oleg's patch to work on Redmine 1.1.0.</p>
<p>I'm new to Redmine, and one of the updates I made to Oleg's patch was in <code>app/controllers/timelog_controller.rb</code>, I made changes to both <code>def new</code> and <code>def create sections instead of @def edit</code>.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=312782011-08-05T03:57:26ZLars Dornheim
<ul><li><strong>File</strong> <a href="/attachments/6390">patch-3848_log-time-for-others-users-ld.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/6390/patch-3848_log-time-for-others-users-ld.diff">patch-3848_log-time-for-others-users-ld.diff</a> added</li></ul><p>The last patch did not work for my Redmine 1.1.0.stable.4761, so I adapted it a little bit to work with my Redmine. Furthermore editing of the user field of existing time logs now works for me, too.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=431272012-11-29T10:17:24ZPavel Potcheptsovektos.net@gmail.com
<ul></ul><p>Is there any plan to include this in current?</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=446672013-01-18T15:44:39ZPavel Potcheptsovektos.net@gmail.com
<ul></ul><p>this worked for 1.3.3<br />but unfortunately last patch doesn't work with current 2.x.x<br />any suggestions?</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=466342013-03-13T17:37:12ZBishma Stornelli Ortega
<ul><li><strong>File</strong> <a href="/attachments/9288">log-time-for-other-users.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/9288/log-time-for-other-users.diff">log-time-for-other-users.diff</a> added</li></ul><p>I update the patch to work with version 2.2.1. I haven't tested in any other version.</p>
<p>Some changes were added. In a nutshell, this patch does:</p>
<ul>
<li>Allow users with permission :edit_time_entries to log time in a project for another user assigned to that project and with permission to log time.</li>
<li>Since an admin does not need to be assigned to a project to log time in it, he/she will be added to the select list of users as "<< me >>" </li>
<li>The label << me >> will appear in the select list if the available users include the current user (or if current user is admin as mentioned before).</li>
<li>These log can be done either through /projects/identifier/time_entries/new or when updating an issue. Maybe I'll add later the option to update through /time_entries/new but it will require a little adittional work.</li>
</ul>
<p>Let me know if you find any bug.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=466352013-03-13T19:01:29ZToshi MARUYAMA
<ul><li><strong>Tracker</strong> changed from <i>Patch</i> to <i>Feature</i></li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=466402013-03-13T20:02:20ZDaniel Felix
<ul></ul><p>Maybe this could be a candidate for 2.4?</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=475052013-03-26T11:19:34ZCassiano Monteiro
<ul></ul><p>Agreed. This is definitely something I need (my co-workers are very lazy on logging their times).</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=504012013-07-08T21:18:42ZGary Watson
<ul><li><strong>File</strong> <a href="/attachments/10022">log-time-for-other-users.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/10022/log-time-for-other-users.diff">log-time-for-other-users.diff</a> added</li></ul><p>A slightly updated diff that works with redmine 2.3.1 There was a small modification I had to make by hand to get the patch to apply otherwise it's the same as the one produced by Bishma Stornelli Ortega that worked with 2.2.1</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=531412013-11-15T08:18:18ZMaximilian Schwerin
<ul></ul><p>The last patch requires ruby >= 1.9.2.</p>
<p>+1 for including this in asap</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=548892014-02-18T13:56:55ZPaul Freund
<ul><li><strong>File</strong> <a href="/attachments/11132">log-time-for-other-users.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/11132/log-time-for-other-users.diff">log-time-for-other-users.diff</a> added</li></ul><p>The patch from Gary Watson also works with version 2.4.2 if you remove the diff for issue.rb. I've attatched an updated patch. All use cases we tested worked but I can't guarantee it works in all.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=566452014-06-05T07:21:36ZPavel Potcheptsovektos.net@gmail.com
<ul></ul><p>Paul Freund wrote:</p>
<blockquote>
<p>The patch from Gary Watson also works with version 2.4.2 if you remove the diff for issue.rb. I've attatched an updated patch. All use cases we tested worked but I can't guarantee it works in all.</p>
</blockquote>
<p>is there any plan to include this functionality in trunk?</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=594942014-10-30T19:59:50ZAlex Dergachev
<ul></ul><p>I just threw together a hacky plugin that seeks to achieve the same thing<br />It doesn't check any permissions and probably has other bugs, but it works for us on redmine 2.6 without hacking core:</p>
<p><a class="external" href="https://github.com/evolvingweb/redmine_timesheet_log_user">https://github.com/evolvingweb/redmine_timesheet_log_user</a></p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=611732015-01-29T22:08:54ZPatrik Halfar
<ul><li><strong>File</strong> <a href="/attachments/13044">redmine_foreign_timelog.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/13044/redmine_foreign_timelog.patch">redmine_foreign_timelog.patch</a> added</li></ul><p>Hi all,<br /> for latest version 2.6.1 I'm using following patch, is has origin in patch from this feature request, but include separete permisson, so it is possible permit this functionality for some roles only.</p>
<p>Intersting should be add functionality requested by <a class="issue tracker-2 status-1 priority-4 priority-default" title="Feature: Log Time for Multiple Users (New)" href="https://www.redmine.org/issues/8505">#8505</a>.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=615692015-02-17T16:54:43ZJosh Ovett
<ul></ul><p>We tested Patrick Halfars patch, Redmine_foreign_timelog.patch and it breaks redmine 2.6.1.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=629372015-04-09T07:43:35ZHenry Auffahrt
<ul></ul><p>+1 is there a plugin for that?</p>
<p>Our Admin only want to implement plugins and no patch files. Thanks a Lot!</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=641532015-06-12T08:17:07ZPavel Potcheptsovektos.net@gmail.com
<ul></ul><p>Unfortunately this path doesn't work in redmine 3.x.<br />If you select another person you want to log time for, you'll get time entries logged by yourself and not by that person.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=653692015-08-11T07:55:27ZAlexander Ryabinovskiy
<ul></ul><p>We use this plugin <a class="external" href="http://www.redmine.org/plugins/redmine_work_time">http://www.redmine.org/plugins/redmine_work_time</a> with Redmine 3.1.0. It allows to add / edit work time of another users. But it is not very simple, please add this functionality to Redmine core!</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=688522016-01-25T06:49:14ZАлександр Скворцов
<ul></ul><p>How select collection: assigned and current user only?</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=724802016-07-29T11:26:43ZAndor Tóth
<ul><li><strong>File</strong> <a href="/attachments/16444">redmine_3_2_log_time_for_others.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/16444/redmine_3_2_log_time_for_others.patch">redmine_3_2_log_time_for_others.patch</a> added</li></ul><p>I have updated Patrik's patch for 3.2.0.stable.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=819992017-11-08T17:08:37ZToshi MARUYAMA
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/27328">Feature #27328</a>: edit the time of the user</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=835342018-02-12T09:46:46ZAndrei Melis
<ul><li><strong>File</strong> <a href="/attachments/20075">redmine_3_4_log_time_for_others.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20075/redmine_3_4_log_time_for_others.patch">redmine_3_4_log_time_for_others.patch</a> added</li></ul><p>Edited the patch above for 3.4 (tested on 3.4.2)</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=842492018-03-31T06:33:52ZGrant Ferley
<ul></ul><p>My Synology docker Redmine recently went to 3.3.6-1 so instead of manually patching I just put it in a plugin. I'll be adding my own custom stuff, but for now the master version is just a plugin for Patrik's 3.2 patch. YMMV, and it's my first attempt at ruby and Redmine plugins.<br /><a class="external" href="https://github.com/gferley/redmine_ferplugin">https://github.com/gferley/redmine_ferplugin</a></p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=843242018-04-02T13:16:43ZHans Kaiser
<ul></ul><p>Grant Ferley wrote:</p>
<blockquote>
<p>My Synology docker Redmine recently went to 3.3.6-1 so instead of manually patching I just put it in a plugin. I'll be adding my own custom stuff, but for now the master version is just a plugin for Patrik's 3.2 patch. YMMV, and it's my first attempt at ruby and Redmine plugins.<br /><a class="external" href="https://github.com/gferley/redmine_ferplugin">https://github.com/gferley/redmine_ferplugin</a></p>
</blockquote>
<p>great! do you know if your plugins supports also redmine 3.2.1. If so I can be your alpha tester...</p>
<p>By the way, the issue is already 8 years old. Is there any plan to integrate this patch into latest 3.x branch or maybe even into 4.0 branch?</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848442018-05-05T21:23:11ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/20615">new_log_time.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20615/new_log_time.png">new_log_time.png</a> added</li><li><strong>File</strong> <a href="/attachments/20616">filter_and_columns.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20616/filter_and_columns.png">filter_and_columns.png</a> added</li><li><strong>File</strong> <a href="/attachments/20617">permissions.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20617/permissions.png">permissions.png</a> added</li><li><strong>File</strong> <i>0001-Allow-the-current-user-to-log-time-for-other-users.patch</i> added</li></ul><p>I made a new patch for this feature (inspired from the existing ones) which is more complete from my point of view.</p>
<p>The patch:<br />- adds a new column ('author_id') to the time entries table where the user who logs the time spent is saved. For the existing entries, author_id will be filled with the user_id during the migration. I found this change a must for this feature. <br />- makes this new column available in the columns list and filters (from Spent time tab)<br />- renames the permission to "Add time logs for other users" <br />- adds tests <br />- adds the user field only in the new log time page. I don't find it necessary to add the select field also to the time log section from the issue edit page.</p>
<p>Some screenshots attached.</p>
<p>This feature is long requested and it has multiple duplicate issues.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848472018-05-05T21:30:00ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> deleted (<i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/7239">Feature #7239</a>: Allow some users to add / edit time entries on behalf of other users</i>)</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848492018-05-05T21:30:02ZMarius BĂLTEANU
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/7239">Feature #7239</a>: Allow some users to add / edit time entries on behalf of other users</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848522018-05-05T21:31:24ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> deleted (<i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/9276">Feature #9276</a>: Log Time on an issue assigned to other</i>)</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848542018-05-05T21:31:39ZMarius BĂLTEANU
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/9276">Feature #9276</a>: Log Time on an issue assigned to other</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848562018-05-05T21:32:12ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> deleted (<i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/6486">Feature #6486</a>: Log time for other users</i>)</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848582018-05-05T21:32:22ZMarius BĂLTEANU
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/6486">Feature #6486</a>: Log time for other users</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848712018-05-06T13:10:51ZGo MAEDA
<ul></ul><p>Marius, thank you for your great work. This is one of the long-awaited features.</p>
<p>The patch <a class="attachment" href="https://www.redmine.org/attachments/20934">0001-Allow-the-current-user-to-log-time-for-other-users.patch</a> works almost fine, however, I found only one small issue. Users who don't have "Log spent time" permission should not be able to access TimelogController#new page, however, they can access the page via "+" button if they have "Log time for other users" permission. They can fill the form but they will see 403 error after hitting "Create" button.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848722018-05-06T13:33:22ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848732018-05-06T13:54:49ZMarius BĂLTEANU
<ul><li><strong>File</strong> <i>0001-Allow-the-current-user-to-log-time-for-other-users.patch</i> added</li></ul><p>Thanks for pointing this out. I've fixed the issue in the attached patch.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848742018-05-06T13:54:57ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0001-Allow-the-current-user-to-log-time-for-other-users.patch</i></del>)</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848902018-05-07T15:16:48ZGo MAEDA
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul><p>Now the patch series looks good. Setting target version to 4.1.0.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=848922018-05-07T15:53:33ZHolger Just
<ul></ul><p>I really like the idea of this feature and would love to have the ability to log time for other users in Redmine. Good job on polishing the patch and making it ready for inclusion, Marius!</p>
<p>I still have some behavior-related comments about the latest patch by Marius from <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Permission to log time for another user (Closed)" href="https://www.redmine.org/issues/3848#note-44">#3848-44</a>:</p>
<ul>
<li>If the current user doesn't have the permission to edit time entries for other users, I would rather see the creation / edit of a time entry rejected rather than silently logged to the current user, e.g. with a validation error. The currentlt defined behavior could lead to unexpected data, esp. when used via the API</li>
<li><code>TimelogHelper#user_collection_for_select_options</code> should probably use <code>collection = project.members.active.map(&:user)</code> to ensure that locked users don't show up in the list of users</li>
<li>The list of allowed users should be checked with a validation on the <code>TimeEntry</code> model too in order to prevent someone assigning hours to arbitrary users.</li>
<li>In the <code>TimelogController#create</code> action, we will see an exception if somene (e.g. via the API) doesn't correctly provide <code>params[:time_entries]</code>. This case should be handled.</li>
</ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=849142018-05-08T10:15:28ZGo MAEDA
<ul><li><strong>Assignee</strong> set to <i>Marius BĂLTEANU</i></li><li><strong>Target version</strong> changed from <i>4.1.0</i> to <i>Candidate for next major release</i></li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=849992018-05-14T07:29:18ZMarius BĂLTEANU
<ul></ul><p>Holger Just wrote:</p>
<blockquote>
<p>I really like the idea of this feature and would love to have the ability to log time for other users in Redmine. Good job on polishing the patch and making it ready for inclusion, Marius!</p>
<p>I still have some behavior-related comments about the latest patch by Marius from <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Permission to log time for another user (Closed)" href="https://www.redmine.org/issues/3848#note-44">#3848-44</a>:</p>
<ul>
<li>If the current user doesn't have the permission to edit time entries for other users, I would rather see the creation / edit of a time entry rejected rather than silently logged to the current user, e.g. with a validation error. The currentlt defined behavior could lead to unexpected data, esp. when used via the API</li>
<li><code>TimelogHelper#user_collection_for_select_options</code> should probably use <code>collection = project.members.active.map(&:user)</code> to ensure that locked users don't show up in the list of users</li>
<li>The list of allowed users should be checked with a validation on the <code>TimeEntry</code> model too in order to prevent someone assigning hours to arbitrary users.</li>
<li>In the <code>TimelogController#create</code> action, we will see an exception if somene (e.g. via the API) doesn't correctly provide <code>params[:time_entries]</code>. This case should be handled.</li>
</ul>
</blockquote>
<p>Thanks Holger for your feedback. I'll update my patch these days to integrate your feedback.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=857252018-06-21T21:17:33ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/20934">0001-Allow-the-current-user-to-log-time-for-other-users.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/20934/0001-Allow-the-current-user-to-log-time-for-other-users.patch">0001-Allow-the-current-user-to-log-time-for-other-users.patch</a> added</li><li><strong>Assignee</strong> deleted (<del><i>Marius BĂLTEANU</i></del>)</li></ul><p>I've reworked my patch in order to include the issues reported by Holger Just.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=857262018-06-21T21:18:02ZMarius BĂLTEANU
<ul><li><strong>File</strong> deleted (<del><i>0001-Allow-the-current-user-to-log-time-for-other-users.patch</i></del>)</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=857742018-06-23T05:31:55ZMarius BĂLTEANU
<ul><li><strong>Target version</strong> changed from <i>Candidate for next major release</i> to <i>4.1.0</i></li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=860652018-07-05T13:25:56ZGo MAEDA
<ul><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=890492018-12-16T16:40:17ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Subject</strong> changed from <i>Allow the current user to record the time spent by another one.</i> to <i>Permission to log time for another user</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Patch is committed, thanks for your work on this feature.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=890502018-12-16T18:31:57ZMarius BĂLTEANU
<ul><li><strong>File</strong> <a href="/attachments/22019">fix_locales.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/22019/fix_locales.diff">fix_locales.diff</a> added</li><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>Jean-Philippe, please apply the attached patch in order to update the translation for <code>error_not_allowed_to_log_time_for_other_users</code> also for the generated locales. I think that you first generated the locales and after that you have changed the en translation.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=890512018-12-16T19:03:51ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>You're right, thanks!</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=890622018-12-17T18:14:19ZMarius BĂLTEANU
<ul></ul><p>Oh, sorry, I've missed to update the translation for en-GB.yml in my previous patch (<a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/entry/trunk/config/locales/en-GB.yml#L1263">source:trunk/config/locales/en-GB.yml#L1263</a>).</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=890742018-12-18T05:48:58ZMarius BĂLTEANU
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>Please commit the below change:</p>
<pre><code class="diff syntaxhl"><span class="p">vagrant@jessie:/vagrant/project/redmine$ git diff
</span><span class="gh">diff --git a/config/locales/en-GB.yml b/config/locales/en-GB.yml
index 00db732..5cd0e14 100644
</span><span class="gd">--- a/config/locales/en-GB.yml
</span><span class="gi">+++ b/config/locales/en-GB.yml
</span><span class="p">@@ -1260,6 +1260,5 @@</span> en-GB:
error_spent_on_future_date: Cannot log time on a future date
setting_timelog_accept_future_dates: Accept time logs on future dates
label_delete_link_to_subtask: Delete relation
<span class="gd">- error_not_allowed_to_log_time_for_other_users: Your role is not allowed to log time
- for other users
</span><span class="gi">+ error_not_allowed_to_log_time_for_other_users: You are not allowed to log time for other users
</span> permission_log_time_for_other_users: Log spent time for other users
</code></pre> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=895332019-01-20T07:41:52ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Done.</p> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=946162019-10-28T13:24:53ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-3 status-5 priority-4 priority-default closed" href="/issues/32196">Patch #32196</a>: Allow import time entries for other users</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=956762020-01-12T21:52:32ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32774">Defect #32774</a>: Creating time tracking entry for other user through rest API fails with 403</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=961312020-02-06T12:47:40ZGo MAEDA
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32959">Defect #32959</a>: Fix selected user on log time edit page when user has permissions to log time for another user</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=961642020-02-08T21:02:12ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/32973">Defect #32973</a>: Editing a time entry for a locked user changes the user to the current user</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=966422020-03-08T12:59:14ZGo MAEDA
<ul><li><strong>Has duplicate</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/3800">Feature #3800</a>: Editing time entries should show the person involved</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=966442020-03-08T21:06:28ZMarius BĂLTEANU
<ul><li><strong>Has duplicate</strong> deleted (<i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/3800">Feature #3800</a>: Editing time entries should show the person involved</i>)</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=966462020-03-08T21:06:34ZMarius BĂLTEANU
<ul><li><strong>Related to</strong> <i><a class="issue tracker-2 status-5 priority-4 priority-default closed" href="/issues/3800">Feature #3800</a>: Editing time entries should show the person involved</i> added</li></ul> Redmine - Feature #3848: Permission to log time for another userhttps://www.redmine.org/issues/3848?journal_id=1057442022-02-22T13:35:03ZMeindert Oldenburger
<ul></ul><p>Hello, thanks for the good work.</p>
<p>Is there a patch that I can apply on redmine 4.0.7? I can't upgrade because of redmine debian multiple instances solution we use.</p>