Patch #4113

Directory listing with CVS v1.11 patch

Added by alexander smishlajev almost 8 years ago. Updated about 7 years ago.

Status:NewStart date:2009-10-26
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:-

Description

Directory listing with CVS SCM uses rls command which was not available in CVS versons prior to 1.12.

Could the CVS adapter use cvs -q -n rlog -R to get the repository contents listing?

cvs_adapter.rb.patch Magnifier (4.07 KB) alexander smishlajev, 2009-10-27 11:09

History

#1 Updated by Jean-Philippe Lang almost 8 years ago

  • Status changed from New to Closed
  • Resolution set to Invalid

Closing this defect since RedmineRepositories clearly states that cvs 1.12 is required.
Feel free to submit a patch.

#2 Updated by alexander smishlajev almost 8 years ago

Well, but the "stable" CVS version still is 1.11, and 1.11 is shipped with the latest production releases of FreeBSD.

The patch is attached.

I admit that the variant requiring CVS version 1.12 is much more effective. Perhaps Redmine could check the cvs version and then choose which code to run?

#3 Updated by Jean-Philippe Lang almost 8 years ago

  • Tracker changed from Defect to Patch

#4 Updated by Jean-Philippe Lang almost 8 years ago

  • Subject changed from Repository browsing fails with CVS v1.11 to Directory listing with CVS v1.11 patch
  • Category set to SCM
  • Status changed from Reopened to New

#5 Updated by Gareth Sylvester-Bradley about 7 years ago

FWIW, I've now been using this patch successfully for several months to enable repository browsing for our CVS 1.11 server. Thanks!

This week I just needed to tweak the regular expression that parses the revision info very slightly to play nice with patch #6090 to make downloading binary files from a CVS repository work when running Redmine on Windows.

Change line 65 from:

          re_loginfo = "revision ([0-9.]+)\s*\n"
to:
          re_loginfo = "revision ([0-9.]+)\s*\r?\n"

Also available in: Atom PDF