Defect #4182
Links on locked users lead to 404 page
| Status: | Closed | Start date: | 2009-11-08 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Accounts / authentication | |||
| Target version: | 0.9.0 | |||
| Affected version: | Resolution: | Fixed |
Description
When you lock a user account (for instance because person has left the team), there are still many links in every issues, wiki pages, comments left by this person. When you click on them, you are redirected to a 404 page, which is not very easy to understand for users imho.
I think this is because in UsersController#show, user is searched with the "active" scope, and there's a rescue ActiveRecord::RecordNotFound; render_404 at the end of the action. Maybe you could forget the "active" scope, and change the display after that with a specific error page ?
Any opinion on this ?
Associated revisions
- No link to a locked user page (closes #4182)
- Translate Anonymous string
History
#1 Updated by Jean-Philippe Lang over 3 years ago
I think that locked users profiles should stay hidden, especially because of the lack of user deletion feature.
But you're right, we shouldn't link a page that gives a 404. A simple fix would be to display locked users as text in ApplicationHelper#link_to_user.
#2 Updated by Jean-Baptiste Barth over 3 years ago
It would be perfect :)
#3 Updated by Jean-Philippe Lang over 3 years ago
- Status changed from New to Closed
- Target version set to 0.9.0
- Resolution set to Fixed
Fixed in r3024.