Defect #4182

Links on locked users lead to 404 page

Added by Jean-Baptiste Barth about 8 years ago. Updated about 8 years ago.

Status:ClosedStart date:2009-11-08
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Accounts / authentication
Target version:0.9.0
Resolution:Fixed Affected version:

Description

When you lock a user account (for instance because person has left the team), there are still many links in every issues, wiki pages, comments left by this person. When you click on them, you are redirected to a 404 page, which is not very easy to understand for users imho.

I think this is because in UsersController#show, user is searched with the "active" scope, and there's a rescue ActiveRecord::RecordNotFound; render_404 at the end of the action. Maybe you could forget the "active" scope, and change the display after that with a specific error page ?

Any opinion on this ?

Associated revisions

Revision 3024
Added by Jean-Philippe Lang about 8 years ago

Fixes ApplicationHelper#link_to_user
  • No link to a locked user page (closes #4182)
  • Translate Anonymous string

History

#1 Updated by Jean-Philippe Lang about 8 years ago

I think that locked users profiles should stay hidden, especially because of the lack of user deletion feature.

But you're right, we shouldn't link a page that gives a 404. A simple fix would be to display locked users as text in ApplicationHelper#link_to_user.

#2 Updated by Jean-Baptiste Barth about 8 years ago

It would be perfect :)

#3 Updated by Jean-Philippe Lang about 8 years ago

  • Status changed from New to Closed
  • Target version set to 0.9.0
  • Resolution set to Fixed

Fixed in r3024.

Also available in: Atom PDF