Defect #4257
Broken support for Principal plugins
| Status: | Assigned | Start date: | 2009-11-20 | |
|---|---|---|---|---|
| Priority: | High | Due date: | ||
| Assignee: | Jean-Baptiste Barth | % Done: | 0% |
|
| Category: | Plugin API | |||
| Target version: | - | |||
| Affected version: | Resolution: |
Description
I'm not sure when exactly it happens (it's worked sometime ago), but things becomes broken for Principal with empty plugin.
How to reproduce:
$ cat vendor/plugins/test_plugin/init.rb1require 'redmine' 2 3require 'dispatcher' 4Dispatcher.to_prepare :test_plugin do 5 require_dependency 'principal' 6end 7 8Redmine::Plugin.register :test_plugin do 9end
(no other files in vendor/test_plugin)
$ rake test:units <...> 1) Failure: test_roles_updated(GroupTest) [/test/unit/group_test.rb:57]: <[1, 2]> expected but was <[1]>. 2) Failure: test_visible_scope_for_user(IssueTest) [/test/unit/issue_test.rb:94]: <false> is not true. 478 tests, 2036 assertions, 2 failures, 0 errors
Related issues
History
Updated by Alexey Palazhchenko about 2 years ago
Any ideas? Please help, it's showstoper for me.
Updated by Alexey Palazhchenko about 2 years ago
- Assignee changed from Eric Davis to Jean-Philippe Lang
Jean-Philippe, any ideas?
Updated by Alexey Palazhchenko about 2 years ago
Ok, second failure was bisect down to r3039. No idea about first yet...
Updated by Eric Davis about 2 years ago
Aleksey:
That's really odd. I have a few plugins that work with Users that are still working. Is this failing in just a test plugin or something you are working on?
Updated by Alexey Palazhchenko about 2 years ago
Eric, I'm working on plugin for some Redmine models. When I found this 2 broken tests, I started to remove code from my plugin – and it's ended with this bare skeleton.
Updated by Jean-Baptiste Barth over 1 year ago
- Assignee deleted (
Jean-Philippe Lang)
Had the same kind of problem recently with memberships. It seems Rails has some troubles reloading things correctly when some classes has been reloaded through engines. It may have something to do with STI (doesn't affect other classes from what I've seen).
For instance, with your test plugin, in test/unit/group_test.rb, line 57:
assert_equal [1, 2], user.reload.roles_for_project(project).collect(&:id).sort #=> KO assert_equal [1, 2], User.find(9).roles_for_project(project).collect(&:id).sort #=> OK
I tried to mark some classes as unloadable in the core, doesn't change anything...
Updated by Jean-Baptiste Barth over 1 year ago
- Status changed from New to Assigned
- Assignee set to Jean-Baptiste Barth
I continue to think it's a rails bug, but it's solved by forcing memberships reload in User model :
def reload(*args)
@name = nil
self.memberships.reload
super(*args)
end
Any thought about integrating that into the core ? (note it also works when monkey patching User class this way in the plugin...)
Updated by Alexey Palazhchenko over 1 year ago
Any thought about integrating that into the core ?
I'm for it, with a big FIXME comment.
Is it a know Rails bug?
Updated by Jean-Baptiste Barth over 1 year ago
Alexey Palazhchenko wrote:
Is it a know Rails bug?
Didn't find it on lighthouse. It seems inherited scopes (in our case User#like) are also lost when reloading...