https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292011-03-29T11:25:25ZRedmineRedmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=272872011-03-29T11:25:25ZToshi MARUYAMA
<ul><li><strong>Category</strong> changed from <i>UI</i> to <i>SCM</i></li></ul> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=571922014-06-30T11:31:15ZAnonymous
<ul><li><strong>File</strong> <a href="/attachments/11893">_changeset.html.erb</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/11893/_changeset.html.erb">_changeset.html.erb</a> added</li></ul><p>On my local installation I have abstracted part of <code>app/views/repositories/revision.html.erb</code> into a partial called <code>_changeset.html.erb</code> (attached). I could then reference it in both <code>app/views/repositories/revision.html.erb</code> and <code>app/views/repositories/diff.html.erb</code> with</p>
<pre>
<%= render :partial => 'changeset', :locals => {:repository => @repository, :changeset => @changeset} %>
</pre>
<p>This is a small change that I recommend because it makes reviewing changes made by other developers much easier.</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=571942014-06-30T11:54:04ZAnonymous
<ul></ul><p>On a related note, adding the following to <code>app/views/issues/_changesets.html.erb</code> is also helpful: providing a direct link from the changesets on an issue to the diff for each changeset:</p>
<pre>
<%= link_to('(diff)',
:controller => 'repositories',
:action => 'diff',
:id => @issue.project,
:repository_id => changeset.repository.identifier_param,
:path => "",
:rev => changeset.identifier) if changeset.filechanges.any? %>
</pre>
<p>I added this between the <code>link_to_revision</code> and <code><br /></code> tag, so you see a "(diff)" link after the "Revision xxxx" link.</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=572012014-06-30T15:11:45ZGo MAEDA
<ul></ul><p>+1.</p>
<p>Could you create a patch file in accordance with the instructions described in <a class="wiki-page" href="https://www.redmine.org/projects/redmine/wiki/Patch">Patch</a> in order to reproduce your work?</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=572132014-07-01T07:37:42ZAnonymous
<ul><li><strong>File</strong> <a href="/attachments/11904">add_changeset_comment_to_diff_page.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/11904/add_changeset_comment_to_diff_page.diff">add_changeset_comment_to_diff_page.diff</a> added</li></ul><p>Here's a patch on <a class="external" href="http://svn.redmine.org/redmine/branches/2.5-stable">http://svn.redmine.org/redmine/branches/2.5-stable</a> that adds the changeset comment to the top of the diff page, the same as the changeset page.</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=572142014-07-01T07:40:43ZAnonymous
<ul><li><strong>File</strong> <a href="/attachments/11905">add_diff_link_to_issue_changesets.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/11905/add_diff_link_to_issue_changesets.diff">add_diff_link_to_issue_changesets.diff</a> added</li></ul><p>...and here is a patch that adds the "(diff)" link to each changeset on the issue page to provide direct access.</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=572322014-07-02T03:54:28ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/11910">commit_message_displayed_3_times.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/11910/commit_message_displayed_3_times.png">commit_message_displayed_3_times.png</a> added</li></ul><p>Thanks for providing the patch.</p>
<p>I applied the patch "add_changeset_comment_to_diff_page.diff" to trunk(<a class="changeset" title="Merged r13199 from trunk to 2.4-stable (#17151) Fix file upload broken on Chrome 36. Contribute..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13203">r13203</a>) and got the following output. The commit message was displayed 3 times in revision page.</p>
<p><img src="https://www.redmine.org/attachments/download/11910/commit_message_displayed_3_times.png" alt="" /></p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=572452014-07-02T07:51:38ZAnonymous
<ul></ul><p>NOTE: my patch was prepared on <a class="external" href="http://svn.redmine.org/redmine/branches/2.5-stable">http://svn.redmine.org/redmine/branches/2.5-stable</a> NOT trunk. Also, you say that <a class="changeset" title="Merged r13199 from trunk to 2.4-stable (#17151) Fix file upload broken on Chrome 36. Contribute..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13203">r13203</a> is trunk, but it isn't it is on the 2.4-stable branch.</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=572472014-07-02T07:59:28ZAnonymous
<ul></ul><p>Sorry, the link to <a class="changeset" title="Merged r13199 from trunk to 2.4-stable (#17151) Fix file upload broken on Chrome 36. Contribute..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13203">r13203</a> is to the 2.4-stable branch. I guess you meant that you are up to date on trunk.</p>
<p>I cannot see any difference in <code>revision.html.erb</code> on trunk, 2.4-stable and 2.5-stable. I don't know what the problem is. It is working fine for us - we actually have vanilla 2.5.1 deployed with this patch.</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=573032014-07-05T03:59:50ZGo MAEDA
<ul></ul><blockquote>
<p>I applied the patch "add_changeset_comment_to_diff_page.diff" to trunk(<a class="changeset" title="Merged r13199 from trunk to 2.4-stable (#17151) Fix file upload broken on Chrome 36. Contribute..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/13203">r13203</a>) and got the following output. The commit message was displayed 3 times in revision page.</p>
</blockquote>
<p>Sorry, it is problem of my environment. I repeated several times applying the patch and 'svn revert'. While doing the work, 'app/views/repositories/_changeset.html.erb' glowed 3 times larger repeating same code 3 times.</p>
<p>Your patch works fine on trunk. Thanks.</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=573042014-07-05T05:37:12ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/11928">with_patch_applied.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/11928/with_patch_applied.png">with_patch_applied.png</a> added</li></ul><p>It is useful. I hope this patch to be adopted.</p>
<p>with patch applied:<br /><img src="https://www.redmine.org/attachments/download/11928/with_patch_applied.png" alt="" /></p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=573152014-07-05T19:47:38ZAnonymous
<ul></ul><p>Glad to hear it works for you Go MAEDA.</p>
<p>I see that you are not relating revisions to Redmine issues, but for anyone else, I recommend applying the other patch (<code>add_diff_link_to_issue_changesets.diff</code>) also, which gives you a direct link to that page from the changesets on the related issues.</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=573212014-07-06T02:15:35ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/11937">add_diff_link_to_issue_changesets_i18n.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/11937/add_diff_link_to_issue_changesets_i18n.diff">add_diff_link_to_issue_changesets_i18n.diff</a> added</li><li><strong>File</strong> <a href="/attachments/11938">add_diff_link_to_issue_changesets_i18n.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/11938/add_diff_link_to_issue_changesets_i18n.png">add_diff_link_to_issue_changesets_i18n.png</a> added</li></ul><p>The patch <code>add_diff_link_to_issue_changesets.diff</code> is nice. It reduces some clicks. I updated the patch for i18n(replaced English word 'diff' with <code>:label_diff</code>).</p>
<p>I think you would be better to create a new issue about this because the patch seems introducing another feature.</p>
<p><img src="https://www.redmine.org/attachments/download/11938/add_diff_link_to_issue_changesets_i18n.png" alt="" /></p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=683732016-01-09T07:01:39ZGo MAEDA
<ul><li><strong>File</strong> <a href="/attachments/14968">add_changeset_comment_to_diff_page_v2.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/14968/add_changeset_comment_to_diff_page_v2.diff">add_changeset_comment_to_diff_page_v2.diff</a> added</li></ul><p>Updated Jonathan Monahan's add_changeset_comment_to_diff_page.diff to make compatible with the current trunk (<a class="changeset" title="Merged r15006 from trunk to 2.6-stable (#21588) Simplified Chinese "field_cvs_module" translatio..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/15012">r15012</a>).</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=683742016-01-09T07:07:34ZGo MAEDA
<ul><li><strong>Target version</strong> set to <i>3.3.0</i></li></ul><p><a class="attachment" href="https://www.redmine.org/attachments/14968">add_changeset_comment_to_diff_page_v2.diff</a> and <a class="attachment" href="https://www.redmine.org/attachments/11937">add_diff_link_to_issue_changesets_i18n.diff</a> can be applied cleanly to the current trunk.<br />I wish these are included in next feature release.</p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=688532016-01-25T10:05:23ZAnonymous
<ul></ul><p>FYI: I've just found a bug in my original patch, and it is still in the latest patch <a class="attachment" href="https://www.redmine.org/attachments/11937">add_diff_link_to_issue_changesets_i18n.diff</a> from Go MAEDA. The link refers to the project of the issue, rather than the project of the changeset:<br /><pre>
:id => @issue.project,
</pre><br />should be changed to<br /><pre>
:id => changeset.repository.project,
</pre></p> Redmine - Feature #4266: Display changeset comment on repository diff view.https://www.redmine.org/issues/4266?journal_id=689752016-01-31T11:19:00ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Feature added. I've made a few changes so that the changeset details on the diff are displayed when the diff is for a single changeset only. Thanks.</p>