Feature #469

Code Review/Approve workflow?

Added by Frank DePinho about 10 years ago. Updated almost 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Issues workflow
Target version:-
Resolution:Duplicate

Description

Any plans on adding features similar to http://www.review-board.org/ where if enabled, code submitted can be reviewed
and commented with approval or discussion before being committed to the main repository?

Thoughts?


Related issues

Related to Redmine - Feature #7747: Add capability to ask\accept\reject review of patches (fl... New 2011-03-01
Duplicates Redmine - Feature #2048: Code Review Module New 2008-10-18

History

#1 Updated by Jean-Philippe Lang about 10 years ago

Hi, it looks interesting.

In the near time, what can be done is:
- to create a tracker called "Review request" with
appropriate workflow which would be used to submit and comment
patches
- add a diff viewer for attachments (the code already exists
for repository diffs), so that attached patches can be easily
reviewed

Then the submitter create a "Review request" issue
and attach its patch to it. Reviewers would be able to view the
diff (just like you see diffs in the repository browser) and
enter their comments by adding notes to the issue.

What do you think ?

#2 Updated by Toshi MARUYAMA over 6 years ago

  • Category set to Issues workflow

#3 Updated by Daniel Felix almost 5 years ago

Jean-Philippe Lang wrote:

- add a diff viewer for attachments (the code already exists
for repository diffs), so that attached patches can be easily
reviewed

This would be interessting!

#4 Updated by Daniel Felix almost 5 years ago

  • Subject changed from Code Review/Approce workflow? to Code Review/Approve workflow?

#5 Updated by Toshi MARUYAMA almost 5 years ago

Is this issue close as duplicate #2048?

#6 Updated by Daniel Felix almost 5 years ago

Well I would prefer to close the older one as the newer one has a better history and is more general in naming of the review tools. What do you think?

Both seem to be the same request.

#7 Updated by Toshi MARUYAMA almost 5 years ago

#2048 has many watchers.
I think it is better to close this issue.

#8 Updated by Daniel Felix almost 5 years ago

  • Status changed from New to Closed
  • Resolution set to Duplicate

Closed as duplicate of #2048.

Also available in: Atom PDF