Defect #5091: User timezone is not honored everywhere - Redmine

Defect #5091

User timezone is not honored everywhere

Added by Joshua Kifer about 2 years ago. Updated about 2 years ago.

Status:

New

Start date:

2010-03-16

Priority:

Normal

Due date:

Assignee:

% Done:

Category:

Issues

Target version:

Affected version:

Resolution:

Description

As the areas in question are only providing the Date (not the Time), I was only able to notice when my local time was a day off from UTC.

It is honored for:

activity
repository (git)
files

It is not honored for:

issues/XX (issue detail)
issues/calendar
roadmap

i18n.rb.patch - don't apply this, it doesn't work (1.6 kB) Wang Congming, 2010-05-12 10:22

Related issues

History

#1 Updated by Joshua Kifer about 2 years ago

In lib/i18n.rb, format_date is not using User.current.time_zone like format_time does.

#2 Updated by Alain Alain091 about 2 years ago

I suggest the following patch but it is not fully tested and is delivered AS IS.

    def format_date(date)
      return nil unless date
      time = date.to_time
      zone = User.current.time_zone
      local = zone ? time.in_time_zone(zone) : (time.utc? ? time.localtime : time)     
      Setting.date_format.blank? ? ::I18n.l(local.to_date) : local.to_date.strftime(Setting.date_format)
    end

#3 Updated by Wang Congming about 2 years ago

File i18n.rb.patch added

Hi Alain,

I modified i18n.rb as you specified here and in #5378, now the patch looks like as my attachment. However, it doesn't work. I am not a ruby developer, maybe I did something wrong, thanks for any suggestion.

We have a server, running Debian Squeeze + redmine trunk + git. Timezone of this server and our desktops are all UTC+8. Everytime, we (git) push a file to server, and check immediately, redmine says the file is modified 8 hours ago.

#4 Updated by Alain Alain091 about 2 years ago

Are you talking about the zone settings in the redmine profil settings ?

#5 Updated by Wang Congming about 2 years ago

Everywhere. Include: system timezone setting of our server, system timezone setting of all our desktops, and the timezone setting in redmine profile. They are all UTC+8.

However, if I (git) push a file from my desktop to our server, and check redmine's repository immediately, redmine says this file is modified 8 hours ago.

Also available in: Atom PDF

Redmine