Defect #5150
CSS problem
| Status: | Closed | Start date: | 2010-03-22 | |
|---|---|---|---|---|
| Priority: | Low | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | - | |||
| Target version: | - | |||
| Affected version: | Resolution: | Invalid |
Description
In app/helpers/issues_helper.rb
1def render_descendants_tree(issue) 2 s = '<form><table class="list issues">' 3 ancestors = [] 4 issue.descendants.sort_by(&:lft).each do |child| 5 level = child.level - issue.level - 1Shouldn't the table class be just "issues". I'm pretty sure CSS class names can't have spaces in them.
History
#1 Updated by Eric Thomas about 2 years ago
Also, this seems to make sense because I believe it's using this part of the css.
public/stylesheets/application.css
1div.issue div.subject h3 {margin: 0; margin-bottom: 0.1em;}
2
3#issue_tree table.issues { border: 0; }
4#issue_tree td.checkbox {display:none;}
5
6fieldset.collapsible { border-width: 1px 0 0 0; font-size: 0.9em; }
#2 Updated by Nick Read about 2 years ago
Eric Thomas wrote:
Shouldn't the table class be just "issues". I'm pretty sure CSS class names can't have spaces in them.
Nope - that's absolutely fine. The CSS class doesn't have a space in it, it is two different CSS classes to apply.
#3 Updated by Eric Thomas about 2 years ago
Nick Read wrote:
Eric Thomas wrote:
Shouldn't the table class be just "issues". I'm pretty sure CSS class names can't have spaces in them.
Nope - that's absolutely fine. The CSS class doesn't have a space in it, it is two different CSS classes to apply.
Ahh I see. Well is there any reason to have the "list" class since the "issues" class just takes away the border attributes that the "list" class defines?
#4 Updated by Felix Schäfer about 2 years ago
- Status changed from New to Closed
- Resolution set to Invalid
Eric Thomas wrote:
Well is there any reason to have the "list" class since the "issues" class just takes away the border attributes that the "list" class defines?
Yes, because that is only the behavior of the default theme, other themes might do it another way. The CSS classes are to be understood as "markup" that roughly tells you what is in there, so that you can make the presentation according to that.
#5 Updated by Eric Thomas about 2 years ago
Okay, I guess I've got something wrong on my end. Thank you for your responses.