Project

General

Profile

Actions

Defect #5150

closed

CSS problem

Added by Eric Thomas about 14 years ago. Updated about 14 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Category:
-
Target version:
-
Start date:
2010-03-22
Due date:
% Done:

0%

Estimated time:
Resolution:
Invalid
Affected version:

Description

In app/helpers/issues_helper.rb

def render_descendants_tree(issue)
    s = '<form><table class="list issues">'
    ancestors = []
    issue.descendants.sort_by(&:lft).each do |child|
      level = child.level - issue.level - 1

	

Shouldn't the table class be just "issues". I'm pretty sure CSS class names can't have spaces in them.

Actions #1

Updated by Eric Thomas about 14 years ago

Also, this seems to make sense because I believe it's using this part of the css.

public/stylesheets/application.css

div.issue div.subject h3 {margin: 0; margin-bottom: 0.1em;}

#issue_tree table.issues { border: 0; }
#issue_tree td.checkbox {display:none;}

fieldset.collapsible { border-width: 1px 0 0 0; font-size: 0.9em; }
Actions #2

Updated by Anonymous about 14 years ago

Eric Thomas wrote:

Shouldn't the table class be just "issues". I'm pretty sure CSS class names can't have spaces in them.

Nope - that's absolutely fine. The CSS class doesn't have a space in it, it is two different CSS classes to apply.

Actions #3

Updated by Eric Thomas about 14 years ago

Nick Read wrote:

Eric Thomas wrote:

Shouldn't the table class be just "issues". I'm pretty sure CSS class names can't have spaces in them.

Nope - that's absolutely fine. The CSS class doesn't have a space in it, it is two different CSS classes to apply.

Ahh I see. Well is there any reason to have the "list" class since the "issues" class just takes away the border attributes that the "list" class defines?

Actions #4

Updated by Felix Schäfer about 14 years ago

  • Status changed from New to Closed
  • Resolution set to Invalid

Eric Thomas wrote:

Well is there any reason to have the "list" class since the "issues" class just takes away the border attributes that the "list" class defines?

Yes, because that is only the behavior of the default theme, other themes might do it another way. The CSS classes are to be understood as "markup" that roughly tells you what is in there, so that you can make the presentation according to that.

Actions #5

Updated by Eric Thomas about 14 years ago

Okay, I guess I've got something wrong on my end. Thank you for your responses.

Actions

Also available in: Atom PDF