https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292010-07-22T01:54:15ZRedmineRedmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=185762010-07-22T01:54:15ZDavid Le Dieu
<ul></ul><p>Thanks for addressing this Hugo - it will certainly be a nice improvement. I am trying to run the patch but get the following output...</p>
<p>bash-4.1$ patch <del>p0 < wrap_text_fields_in_pdf_r3764.patch <br />patching file patch<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: permissions if not admin (Closed)" href="https://www.redmine.org/issues/1">#1</a> FAILED at 87.<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Listing 5 projects on Welcome page (Closed)" href="https://www.redmine.org/issues/2">#2</a> FAILED at 100.<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: ajax pagination of projects (Closed)" href="https://www.redmine.org/issues/3">#3</a> FAILED at 122.<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: log problem (Closed)" href="https://www.redmine.org/issues/4">#4</a> FAILED at 140.<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Setting an issue status as default status leads to an sql error. (Closed)" href="https://www.redmine.org/issues/5">#5</a> FAILED at 159.<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: info.rhtml uninitialized constant (Closed)" href="https://www.redmine.org/issues/6">#6</a> FAILED at 174.<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: bad user submission returns application error. (Closed)" href="https://www.redmine.org/issues/7">#7</a> FAILED at 185.<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Schema Creation fails with Redmine 0.4.2 & MySQL 5 (Closed)" href="https://www.redmine.org/issues/8">#8</a> FAILED at 194.<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Export feature(to csv/pdf) doesn't work (in Japanese) (Closed)" href="https://www.redmine.org/issues/9">#9</a> FAILED at 247.<br />Hunk <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: not work administration-menu with prefix-url (Closed)" href="https://www.redmine.org/issues/10">#10</a> FAILED at 286.<br />10 out of 10 hunks FAILED -</del> saving rejects to file patch.rej</p>
<p>Any idea what I might be doing wrong? I am running the latest bitnami redmine stack if that gives you any clues.</p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=208192010-09-29T00:08:02ZHugo Ferreira
<ul><li><strong>File</strong> <a href="/attachments/4585">issue5629_wrap_text_fields_in_pdf_r4213.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4585/issue5629_wrap_text_fields_in_pdf_r4213.patch">issue5629_wrap_text_fields_in_pdf_r4213.patch</a> added</li><li><strong>Assignee</strong> set to <i>Eric Davis</i></li></ul><p>Eric, can't you check this patch I've just updated for v1.0.2?<br />Would it be possible to get it in while it is still up-to-date with the latest version of the "lib/redmine/export/pdf.rb" file?</p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=208202010-09-29T00:15:12ZHugo Ferreira
<ul></ul><p>David Le Dieu wrote:</p>
<blockquote>
<p>Any idea what I might be doing wrong? I am running the latest bitnami redmine stack if that gives you any clues.</p>
</blockquote>
<p>Not really sure, but most likely at the time the bitnami version had already moved past the v0.9.4 against which the patch was made.</p>
<p>This new version tested successfully against Redmine v1.0.2 (<a class="changeset" title="Tagging 1.0.2" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4213">r4213</a>) so you can try it again on that version, although I believe the bitnami is still at v1.0.1 and considering that the patched file was changed from v1.0.1 to v1.0.2 I'm not sure it'll update successfully.</p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=217302010-10-25T14:59:36ZEric Davis
<ul><li><strong>Assignee</strong> deleted (<del><i>Eric Davis</i></del>)</li></ul> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=244492011-01-25T15:32:11ZMichael P
<ul></ul><p>Hi,<br />is this patch still working for V1.1.0?</p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=245482011-01-27T08:25:33ZMichael P
<ul><li><strong>Assignee</strong> set to <i>Hugo Ferreira</i></li></ul> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=247332011-02-01T13:53:17ZHugo Ferreira
<ul><li><strong>File</strong> <a href="/attachments/5268">issue5629_wrap_text_fields_in_pdf_r4784.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5268/issue5629_wrap_text_fields_in_pdf_r4784.patch">issue5629_wrap_text_fields_in_pdf_r4784.patch</a> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Nope, it does not apply successfully to the latest v1.1.1, since there was a <a href="/projects/redmine/repository/diff/trunk/lib/redmine/export?rev=4736&rev_to=4104">small change made</a> in <a class="changeset" title="Avoid "private method `gsub' called for nil:NilClass" error when exporting issues with nil descri..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4736">r4736</a> that touched one of the lines of the patch.</p>
<p>I'm attaching a new patch that works on the latest <a class="changeset" title="Update for 1.1.1 release." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4784">r4784</a>: "issue5629_wrap_text_fields_in_pdf_r4784.patch"</p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=247342011-02-01T13:56:23ZHugo Ferreira
<ul></ul><p>Now, who can pick this up and commit it to trunk?<br />(before the main code moves yet again and invalidates this patch… it's been 8 months, already!)</p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=248352011-02-04T14:38:34ZEtienne Massip
<ul><li><strong>Category</strong> set to <i>PDF export</i></li></ul> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=284802011-04-29T21:59:40ZToshi MARUYAMA
<ul><li><strong>% Done</strong> changed from <i>100</i> to <i>50</i></li></ul><p><a class="external" href="https://www.chiliproject.org/issues/357">https://www.chiliproject.org/issues/357</a></p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=284882011-04-30T00:17:25ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>New</i></li><li><strong>Assignee</strong> changed from <i>Hugo Ferreira</i> to <i>Toshi MARUYAMA</i></li></ul> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=284922011-04-30T00:30:27ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> set to <i>1.2.0</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li></ul><p>Committed in <a class="changeset" title="Wrap long text fields properly in PDF exports (#5629). Contributed by Hugo Ferreira." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/5604">r5604</a>, thanks.</p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=285042011-04-30T05:39:35ZJun NAITOH
<ul><li><strong>File</strong> <a href="/attachments/5900">chinese.rb.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5900/chinese.rb.patch">chinese.rb.patch</a> added</li><li><strong>File</strong> <a href="/attachments/5901">before_chinese.rb.patch.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5901/before_chinese.rb.patch.png">before_chinese.rb.patch.png</a> added</li><li><strong>File</strong> <a href="/attachments/5902">after_chinese.rb.patch.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5902/after_chinese.rb.patch.png">after_chinese.rb.patch.png</a> added</li><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p>I found the bug of the Automatic line break in Chinese PDF of <a class="changeset" title="Wrap long text fields properly in PDF exports (#5629). Contributed by Hugo Ferreira." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/5604">r5604</a>. <br />This is FPDF original bug. (Japanse and Korean don't have this problem)</p>
<p>I wrote patch.</p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=285052011-04-30T05:59:35ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Note 13 patch is committed in <a class="changeset" title="PDF: fix automatic line break in Chinese PDF (#5629). Contributed by Jun NAITOH." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/5605">r5605</a>, thanks.</p> Redmine - Patch #5629: Wrap text fields properly in PDF https://www.redmine.org/issues/5629?journal_id=285222011-04-30T12:35:52ZHugo Ferreira
<ul></ul><p>Thanks for the prompt reply Toshi.<br />Congrats for the excellent work; things <em>feel</em> much lively around here lately.</p>