https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292010-07-26T11:40:26ZRedmineRedmine - Defect #5958: Empty visible sidebar in Overview sectionhttps://www.redmine.org/issues/5958?journal_id=187062010-07-26T11:40:26ZHenrik Ammer
<ul><li><strong>File</strong> <a href="/attachments/4191">sidebar_empty.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4191/sidebar_empty.diff">sidebar_empty.diff</a> added</li></ul><p>I've been thinking about this aswell. Since the CSS selector <code>:empty</code> needs the element to have no white-space I did a small patch.</p> Redmine - Defect #5958: Empty visible sidebar in Overview sectionhttps://www.redmine.org/issues/5958?journal_id=443332013-01-15T08:56:50ZDaniel Felix
<ul><li><strong>File</strong> <a href="/attachments/8817">emptySidebar.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/8817/emptySidebar.png">emptySidebar.png</a> added</li><li><strong>Status</strong> changed from <i>New</i> to <i>Confirmed</i></li></ul><p>I can confirm this misbehaviour. But the applied patch won't fix this.</p>
<p>There still need to be some css enhancement to remove the sidebar display.</p>
<p>But in my opinion it would be better that the whole sidebar div won't be rendered at all if there is nothing to display. What do you think?</p> Redmine - Defect #5958: Empty visible sidebar in Overview sectionhttps://www.redmine.org/issues/5958?journal_id=491102013-05-05T09:51:44ZJean-Baptiste Barth
<ul><li><strong>Category</strong> set to <i>UI</i></li><li><strong>Assignee</strong> set to <i>Jean-Baptiste Barth</i></li><li><strong>Target version</strong> set to <i>Candidate for next major release</i></li><li><strong>Affected version (unused)</strong> set to <i>devel</i></li></ul><p>I don't think introducing a CSS hack would be a good idea for this. I would prefer that <code>ApplicationHelper#has_content?</code> behaves the right way. It turns out simply delegating to Rails' <code>#content_for?</code> seems to work well, but I'd like to understand why Redmine had hack around it in the first place. I'll dig into that and let you know.</p> Redmine - Defect #5958: Empty visible sidebar in Overview sectionhttps://www.redmine.org/issues/5958?journal_id=491122013-05-05T17:00:15ZJean-Baptiste Barth
<ul><li><strong>File</strong> <a href="/attachments/9700">5958-patch.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/9700/5958-patch.diff">5958-patch.diff</a> added</li></ul><p>After some research, there's a very good reason redmine has hacked around it: it wasn't present in Rails 1.x and 2.x, it was introduced in 3.0.0.</p>
<p>This part of the code is 5 years old, and not really tested, but I guess the framework does the right thing here, so we should rely on it. Jean-Philippe: can you tell me what you think about the attached patch ? Anything I missed ? Does it need some more tests in your opinion ?</p> Redmine - Defect #5958: Empty visible sidebar in Overview sectionhttps://www.redmine.org/issues/5958?journal_id=532862013-11-20T20:22:28ZMischa The Evil
<ul><li><strong>Status</strong> changed from <i>Confirmed</i> to <i>Closed</i></li><li><strong>Target version</strong> deleted (<del><i>Candidate for next major release</i></del>)</li></ul><p>This issue is superseded by <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Defect: Empty sidebar should not be displayed in project overview (Closed)" href="https://www.redmine.org/issues/15414">#15414</a>, which itself is fixed - like suggested by Jean-Baptiste - in <a class="changeset" title="Fixed that the sidebar may be displayed empty (#15414)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/12310">r12310</a>.</p> Redmine - Defect #5958: Empty visible sidebar in Overview sectionhttps://www.redmine.org/issues/5958?journal_id=532882013-11-20T20:25:26ZMischa The Evil
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/15414">Defect #15414</a>: Empty sidebar should not be displayed in project overview</i> added</li></ul>