https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292010-08-12T16:31:28ZRedmineRedmine - Defect #6045: Repository file Diff view sometimes shows more than selected filehttps://www.redmine.org/issues/6045?journal_id=192892010-08-12T16:31:28ZMarc Mengel
<ul></ul><p>Just to be more specific, this is due to the wrong URI in the action= of the <form> around the inline/side-by-side selection. It is missing the file pathname part.</p> Redmine - Defect #6045: Repository file Diff view sometimes shows more than selected filehttps://www.redmine.org/issues/6045?journal_id=192902010-08-12T17:49:49ZMarc Mengel
<ul><li><strong>File</strong> <a href="/attachments/4298">diff_format.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/4298/diff_format.patch">diff_format.patch</a> added</li><li><strong>% Done</strong> changed from <i>0</i> to <i>50</i></li></ul><p>Here's a patch for it...</p> Redmine - Defect #6045: Repository file Diff view sometimes shows more than selected filehttps://www.redmine.org/issues/6045?journal_id=193032010-08-13T03:21:40ZMischa The Evil
<ul><li><strong>Target version</strong> set to <i>1.0.1</i></li><li><strong>Affected version (unused)</strong> changed from <i>1.0.0-RC</i> to <i>devel</i></li></ul><p>@ Marc: Thanks for your contribution. Sadly the patch-file seems to be broken somehow but nevertheless I have extracted the change locally...</p>
<p>It includes a one-line change of <a class="source" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/3938/entry/trunk/app/views/repositories/diff.rhtml#L4">source:/trunk/app/views/repositories/diff.rhtml@3938#L4</a></p>
<p>from:</p>
<pre><code class="rhtml syntaxhl"><span class="cp"><%</span> <span class="n">form_tag</span><span class="p">({},</span> <span class="ss">:method</span> <span class="o">=></span> <span class="s1">'get'</span><span class="p">)</span> <span class="k">do</span> <span class="cp">%></span></code></pre>
<p>to</p>
<pre><code class="rhtml syntaxhl"><span class="cp"><%</span> <span class="n">form_tag</span><span class="p">(</span><span class="n">request</span><span class="p">.</span><span class="nf">request_uri</span><span class="p">,</span> <span class="ss">:method</span> <span class="o">=></span> <span class="s1">'get'</span><span class="p">)</span> <span class="k">do</span> <span class="cp">%></span></code></pre>
<p>I have tested this tiny patch and it fixed the issue for me too. Dunno for sure though if this is the right way to fix this issue most effectively. I'll leave that up to the commiters.</p>
<p>I've targetted this issue for Redmine <a class="version" href="https://www.redmine.org/versions/21">1.0.1</a> since it seems it can be fixed easily. Please retarget if time is missing to include this for <a class="version" href="https://www.redmine.org/versions/21">1.0.1</a>...<br />I've also set the affected version to devel since it's still broken in the trunk too.</p> Redmine - Defect #6045: Repository file Diff view sometimes shows more than selected filehttps://www.redmine.org/issues/6045?journal_id=193162010-08-13T05:38:08ZJean-Baptiste Barth
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>7</i></li><li><strong>Assignee</strong> set to <i>Jean-Baptiste Barth</i></li><li><strong>Priority</strong> changed from <i>Low</i> to <i>Normal</i></li></ul><p>I don't really like the idea of using request.request_uri, it could introduce weird bugs, but I'll take a look at this one. I confirm it could be the kind of defect we want to address in 1.0.1, but I don't know when Eric wants to stop adding issues for this one (due date is in 7 days!).</p>
<p>Thanks for the patch and your investigations on that.</p> Redmine - Defect #6045: Repository file Diff view sometimes shows more than selected filehttps://www.redmine.org/issues/6045?journal_id=193182010-08-13T06:08:17ZJean-Baptiste Barth
<ul><li><strong>Status</strong> changed from <i>7</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>It was just missing path information, fixed in <a class="changeset" title="Fixed: changing view style in repository/diff doesn't keep previously selected file. #6045" href="https://www.redmine.org/projects/redmine/repository/svn/revisions/3939">r3939</a></p> Redmine - Defect #6045: Repository file Diff view sometimes shows more than selected filehttps://www.redmine.org/issues/6045?journal_id=195232010-08-19T04:35:47ZEric Davis
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul><p>Merged to 1.0-stable for release in 1.0.1.</p>