Defect #6625

Attachments lost when activity field error occures

Added by Maxim Strukov about 7 years ago. Updated over 2 years ago.

Status:ClosedStart date:2010-10-11
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Attachments
Target version:-
Resolution:Fixed Affected version:1.0.2

Description

If there is activity field error (set Timelog, but not set Activity type) Redmine does not save attached files and I need attach it once again.

clearatt.png (366 KB) Maxim Strukov, 2010-10-11 15:09


Related issues

Related to Redmine - Defect #4401: Attachments get saved on issue update even if validation ... Closed 2009-12-15
Duplicated by Redmine - Defect #8793: Attachment lost when filed validation fails Closed 2011-07-12

History

#1 Updated by Holger Just about 7 years ago

This was introduced in r3305.

I think it is rather hard to really say which of the two cases is better:
  • throw the file away and thus have atomic update operations
  • attach the file nevertheless the other fields are invalid

The second case is better for larger files where uploading can take some significant time, the first case fits the currently designed workflow better, where we have atomic operations everywhere in Redmine.

#2 Updated by Maxim Strukov about 7 years ago

Redmine can check the field before sending to the server without reloading page? In this case file will still not loaded, but already choosed and ready for upload.

#3 Updated by Etienne Massip over 6 years ago

  • Category set to Attachments

#4 Updated by Peter Englmaier almost 6 years ago

This issue seems not to be worked on and is still present in Redmine 1.2.2.stable.7811.

Please add the issue to the 'Candidate for next minor release' list!

#5 Updated by Go MAEDA over 2 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Probably implemented in r10977 and 10977 (Redmine 2.3).
In current versions, attachments are kept even after validation errors.

Also available in: Atom PDF