Defect #6656

Mercurial adapter loses seconds of commit times

Added by Toshi MARUYAMA about 7 years ago. Updated almost 7 years ago.

Status:ClosedStart date:2010-10-13
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:SCM
Target version:1.0.5
Resolution:Fixed Affected version:1.0.2

Description

This issue is reported at note-85 of #4455 .
As I described at note-86 of #4455 , template keyword at source:tags/1.0.2/lib/redmine/scm/adapters/mercurial/hg-template-1.0.tmpl#L4 is isodate .
isodatesec is supported since Mercurial revision 8999d1249171 , which means Mercurial 1.0 has it.

Following is hg log output of source:/tags/1.0.2/test/fixtures/repositories/mercurial_repository.tar.gz .

$ hg log -r 76bce72867b1 --template='{date|isodate}\n'
2007-12-14 16:15 +0100

$ hg log -r 76bce72867b1 --template='{date|isodatesec}\n'
2007-12-14 16:15:51 +0100

There are my patches at following links.

I pushed it to my github repository.

English locale does not show seconds, but Italian locale shows seconds.

I post Italian locale images.

Before patch applied

After patch applied

isodatesec-it-before.png (61.3 KB) Toshi MARUYAMA, 2010-10-13 11:22

isodatesec-it-after.png (62.3 KB) Toshi MARUYAMA, 2010-10-13 11:22

hg-isodatesec.patch Magnifier (2.09 KB) Toshi MARUYAMA, 2010-11-27 13:09

hg-isodatesec-20101128.patch Magnifier (2.2 KB) Toshi MARUYAMA, 2010-11-28 02:25

Associated revisions

Revision 4561
Added by Jean-Philippe Lang almost 7 years ago

Fixes: Mercurial adapter loses seconds of commit times (#6656).

History

#2 Updated by Toshi MARUYAMA almost 7 years ago

As I described at note-164 of #4455, bug fix for this issue is no behavior change (very minor behavior change).

I attach hg-isodatesec.patch again.
This patch is same with http://www.redmine.org/attachments/4219/hg-isodatesec.patch at note-144 of #4455,

Please set this issue target 1.0.4.

#3 Updated by Toshi MARUYAMA almost 7 years ago

I have updated unit test to switch Mercurial version higher than 1.0 or not.
Because template keyword 'isodatesec' is supported supported in Mercurial 1.0 and higher.

I attache hg-isodatesec-20101128.patch .

Please set this issue target 1.0.4.

#4 Updated by Toshi MARUYAMA almost 7 years ago

Is next release version 1.1.0?
Could someone set this issue target to next release version?

#5 Updated by Jean-Philippe Lang almost 7 years ago

  • Target version set to 1.0.5

#6 Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed in r4561.

Also available in: Atom PDF