Defect #7097

Starting day of week cannot be set to Saturday

Added by Ebrahim Mohammadi about 7 years ago. Updated over 6 years ago.

Status:ClosedStart date:2010-12-11
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:Administration
Target version:1.2.0
Resolution:Fixed Affected version:1.0.4

Description

Starting day of week is Saturday in some countries, Iran for one, but the drop down list in settings page only has Sunday and Monday.
It would be nice to be able to set starting day of week to Saturday independent of current locale of Redmine.

redmine-saturday.diff Magnifier (1.44 KB) Ebrahim Mohammadi, 2011-03-16 15:37


Related issues

Duplicated by Redmine - Feature #2884: No way to configure start of week day Closed 2009-03-02

Associated revisions

Revision 5228
Added by Jean-Philippe Lang over 6 years ago

Adds support for saturday as the first week day (#7097).

Revision 5596
Added by Jean-Philippe Lang over 6 years ago

Makes 'This week' filter work with any starting day of week (#7097).

Revision 5603
Added by Jean-Philippe Lang over 6 years ago

Fixes an assertion for postgresql (#7097).

History

#1 Updated by Jonas De Meulenaere almost 7 years ago

  • Category set to Administration

#2 Updated by Ebrahim Mohammadi almost 7 years ago

This tiny patch adds Saturday to choices of first day of week.

May somebody review and merge it?

#3 Updated by Etienne Massip almost 7 years ago

  • Status changed from Resolved to New
  • Target version set to Candidate for next minor release

#4 Updated by Jean-Philippe Lang over 6 years ago

  • Status changed from New to Resolved
  • Target version changed from Candidate for next minor release to 1.1.3
  • Resolution set to Fixed

Patch with additional fixes and tests committed in r5228.

#5 Updated by Etienne Massip over 6 years ago

  • Status changed from Resolved to New

Was looking at #7218 when I realized the code at source:trunk/app/models/query.rb#L625 needs to be fixed to handle date filter "This week" properly according to the present issue.

#6 Updated by Jean-Philippe Lang over 6 years ago

  • Target version changed from 1.1.3 to 1.2.0

#7 Updated by Jean-Philippe Lang over 6 years ago

  • Status changed from New to Closed

Etienne Massip wrote:

Was looking at #7218 when I realized the code at source:trunk/app/models/query.rb#L625 needs to be fixed to handle date filter "This week" properly according to the present issue.

Fixed in r5596.

#8 Updated by Toshi MARUYAMA over 3 years ago

  • Duplicated by Feature #2884: No way to configure start of week day added

Also available in: Atom PDF