https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292011-01-12T10:01:54ZRedmineRedmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=239522011-01-12T10:01:54ZToshi MARUYAMA
<ul><li><strong>File</strong> <a href="/attachments/5139">7307-rev-empty.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/5139/7307-rev-empty.diff">7307-rev-empty.diff</a> added</li></ul><p>This is ad hoc patch.</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=239532011-01-12T11:21:17ZGloriaer smith
<ul><li><strong>File</strong> <i>leanspawithacai.jpg</i> added</li><li><strong>Assignee</strong> set to <i>Maxim Krušina</i></li></ul> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=239552011-01-12T11:48:13ZToshi MARUYAMA
<ul><li><strong>File</strong> deleted (<del><i>leanspawithacai.jpg</i></del>)</li></ul> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=239562011-01-12T11:48:22ZToshi MARUYAMA
<ul><li><strong>Assignee</strong> deleted (<del><i>Maxim Krušina</i></del>)</li></ul> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=239582011-01-12T12:04:43ZToshi MARUYAMA
<ul></ul><p>Etienne Massip wrote:</p>
<blockquote>
<p>Additional question (UX) : why is the 'Ok' button displayed on the revision page and not on the repository page ?</p>
</blockquote>
<p>Git shows branches and tags list box.<br /><a class="external" href="https://projects.kde.org/projects/extragear/kdevelop/kdevelop/repository">https://projects.kde.org/projects/extragear/kdevelop/kdevelop/repository</a></p>
<p>But, I don't know the reason of no 'Ok' button.</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=239652011-01-12T13:32:08ZEtienne Massip
<ul></ul><p>Toshi MARUYAMA wrote:</p>
<blockquote>
<p>This is ad hoc patch.</p>
</blockquote>
<p>Do you want me to test it ?</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=239672011-01-12T13:41:45ZToshi MARUYAMA
<ul></ul><p>Etienne Massip wrote:</p>
<blockquote>
<p>Toshi MARUYAMA wrote:</p>
<blockquote>
<p>This is ad hoc patch.</p>
</blockquote>
<p>Do you want me to test it ?</p>
</blockquote>
<p>I tested in Subversion.<br />I will research other SCMs.</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=240032011-01-13T03:42:43ZToshi MARUYAMA
<ul><li><strong>Assignee</strong> set to <i>Toshi MARUYAMA</i></li></ul> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=240102011-01-13T12:20:24ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> set to <i>1.1.1</i></li><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Fixed in trunk by <a class="changeset" title="scm: fix error on revision page for empty revision (#7307)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4703">r4703</a>, <a class="changeset" title="scm: mercurial: fix error on revision page for empty revision (#7307)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4704">r4704</a> and in 1.1 by <a class="changeset" title="Merged r4703 from trunk (scm: fix error on revision page for empty revision)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4707">r4707</a>.</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=240892011-01-14T14:11:02ZВе Fio
<ul></ul><p>Hmm. I'm using 4707 right now, and the issue doesn't seem fixed for me. I click the repository tab, click view all revisions, then in the "Revision: <input box> <ok button>" I just click the ok button without entering anything, and up pops a 500 error.</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=241012011-01-14T18:56:17ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Closed</i> to <i>Reopened</i></li></ul><p><a class="changeset" title="Merged r4703 from trunk (scm: fix error on revision page for empty revision)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4707">r4707</a> will return a 500 status code indeed. Maybe we could simply redirect to the revisions list when no revision parameter is given.</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=241022011-01-14T19:32:39ZEtienne Massip
<ul></ul><p>I'm running <a class="changeset" title="Adds a test for TimeEntry#spent_on= with invalid string." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4709">r4709</a> and I get the same redmine 500 error I would get if I typed in a revision number which would not exist.</p>
<p>I don't have the Internal Server Error HTTP 500 any more (with svn, at least) so, as for myself, this issue is resolved.</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=241052011-01-14T19:49:26ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul>Yes, it's a user friendly 500 error but still, it's a 500 error response (meaning <a href="http://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_Server_Error" class="external">Internal Server Error</a>) and this is not really appropriate. I think we should:
<ul>
<li>response with a 404 when the revision that was entered was not found</li>
<li>do a redirect to the revision list when no revision parameter is given</li>
</ul> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=241062011-01-14T19:53:35ZEtienne Massip
<ul></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
Yes, it's a user friendly 500 error but still, it's a 500 error response (meaning <a href="http://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_Server_Error" class="external">Internal Server Error</a>) and this is not really appropriate. I think we should:
<ul>
<li>response with a 404 when the revision that was entered was not found</li>
<li>do a redirect to the revision list when no revision parameter is given</li>
</ul>
</blockquote>
<p>Sure, both looks like a (far for 404) better behavior.</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=241072011-01-14T20:26:00ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>500 error changed to 404 in <a class="changeset" title="Use #blank? instead of #nil? || #empty?." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4711">r4711</a>.</p> Redmine - Defect #7307: HTTP 500 error on query for empty revisionhttps://www.redmine.org/issues/7307?journal_id=241192011-01-15T00:51:32ZToshi MARUYAMA
<ul><li><strong>Status</strong> changed from <i>Reopened</i> to <i>Closed</i></li></ul><p>Fixed in trunk by from <a class="changeset" title="scm: use #blank? instead of #nil? || #empty? at Repository#find_changeset_by_name(name) (#7307). ..." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4712">r4712</a> to <a class="changeset" title="scm: mercurial: fix id at functional test_empty_revision test(#7307)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4714">r4714</a> and in 1.1 by from <a class="changeset" title="Merged r4712 from trunk." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4715">r4715</a> to <a class="changeset" title="Merged r4713 from trunk." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4717">r4717</a>.</p>