https://www.redmine.org/https://www.redmine.org/favicon.ico?16793021292011-01-17T19:35:48ZRedmineRedmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=241872011-01-17T19:35:48ZEtienne Massip
<ul></ul><p>Are you using gravatars ?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=241892011-01-17T20:16:57ZLuke Dixon
<ul></ul><p>Yes i am.</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=241912011-01-17T22:21:37ZEtienne Massip
<ul></ul><p>What does your mail address, as filled in your profile, looks like to (just replace ascii chars, please) ?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=242292011-01-18T09:22:50ZEtienne Massip
<ul></ul><p>Must be an exception raised in <code>gravatar_url()</code> because of MD5 gem or whatever.</p>
<p>could you remove the <code>rescue nil</code> at the end of line 874 of <code>app/helpers/application_helper.rb</code>, try again then report the new exception stack ?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=251782011-02-14T08:58:30ZDavid Barbion
<ul></ul><p>I made the modification in <code>app/helpers/application_helper.rb</code> but I still have the same exception stack...</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=251792011-02-14T09:03:09ZEtienne Massip
<ul></ul><p>Did you restart your web server before testing ?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=251802011-02-14T09:06:16ZEtienne Massip
<ul></ul><p>Note : line is now 892 :</p>
<pre>
<code class="ruby syntaxhl"><span class="o">...</span>
<span class="k">return</span> <span class="n">gravatar</span><span class="p">(</span><span class="n">email</span><span class="p">.</span><span class="nf">to_s</span><span class="p">.</span><span class="nf">downcase</span><span class="p">,</span> <span class="n">options</span><span class="p">)</span> <span class="k">unless</span> <span class="n">email</span><span class="p">.</span><span class="nf">blank?</span> <span class="k">rescue</span> <span class="kp">nil</span>
<span class="o">...</span></code><br /></pre> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=251812011-02-14T09:54:12ZEtienne Massip
<ul></ul><p>The only other possibility is that someone, assigned to an issue, has a blank e-mail address.</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=251822011-02-14T09:55:13ZEtienne Massip
<ul></ul><p>Which should not happen because mail address is not supposed to be blank.</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257242011-02-28T15:19:24ZTerence Mill
<ul></ul><p>We have same error here!</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257262011-02-28T15:38:13ZEtienne Massip
<ul></ul><p>If you don't have any assignee with a blank mail address (note 8), could you try with the above mentioned change (notes 5 & 7) ?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257282011-02-28T15:58:32ZTerence Mill
<ul></ul><p>I checked all users (also disabled ones) have an email string <>"")<br />I changed line app/helpers/application_helper.rb 874<br />from<br /><pre>
return gravatar(email.to_s.downcase, options) unless email.blank? rescue nil
</pre><br />to<br /><pre>
return gravatar(email.to_s.downcase, options) unless email.blank?
</pre><br />restarted apache and called gant tab</p>
<p>Error still is<br /><pre>
ActionView::TemplateError (can't convert nil into String) on line #63 of app/views/gantts/show.html.erb:
60: # Width of the entire chart
61: g_width = (@gantt.date_to - @gantt.date_from + 1)*zoom
62:
63: @gantt.render(:top => headers_height + 8, :zoom => zoom, :g_width => g_width)
64:
65: g_height = [(20 * (@gantt.number_of_rows + 6))+150, 206].max
66: t_height = g_height + headers_height
lib/redmine/helpers/gantt.rb:356:in `subject_for_issue'
lib/redmine/helpers/gantt.rb:221:in `render_issues'
lib/redmine/helpers/gantt.rb:220:in `each'
lib/redmine/helpers/gantt.rb:220:in `render_issues'
lib/redmine/helpers/gantt.rb:197:in `render_project'
lib/redmine/helpers/gantt.rb:209:in `render_project'
lib/redmine/helpers/gantt.rb:208:in `render_project'
lib/redmine/helpers/gantt.rb:209:in `render_project'
lib/redmine/helpers/gantt.rb:208:in `render_project'
lib/redmine/helpers/gantt.rb:166:in `render'
app/views/gantts/show.html.erb:63
app/controllers/gantts_controller.rb:26:in `show'
app/controllers/gantts_controller.rb:25:in `show'
passenger (2.2.14) lib/phusion_passenger/rack/request_handler.rb:92:in `process_request'
passenger (2.2.14) lib/phusion_passenger/abstract_request_handler.rb:207:in `main_loop'
passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:441:in `start_request_handler'
passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:381:in `handle_spawn_application'
passenger (2.2.14) lib/phusion_passenger/utils.rb:252:in `safe_fork'
passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:377:in `handle_spawn_application'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `__send__'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:163:in `start'
passenger (2.2.14) lib/phusion_passenger/railz/application_spawner.rb:222:in `start'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:262:in `spawn_rails_application'
passenger (2.2.14) lib/phusion_passenger/abstract_server_collection.rb:126:in `lookup_or_add'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:256:in `spawn_rails_application'
passenger (2.2.14) lib/phusion_passenger/abstract_server_collection.rb:80:in `synchronize'
passenger (2.2.14) lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:255:in `spawn_rails_application'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:154:in `spawn_application'
passenger (2.2.14) lib/phusion_passenger/spawn_manager.rb:287:in `handle_spawn_application'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `__send__'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:352:in `main_loop'
passenger (2.2.14) lib/phusion_passenger/abstract_server.rb:196:in `start_synchronously'
</pre></p>
<p>Bad issue, cause i wanted to present redmine as new bug tracking system tomorrow.<br />Any ideas for a quick fix, altough disabling gant module?<br />Tx for help!</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257292011-02-28T16:06:07ZEtienne Massip
<ul></ul><p>You can just disable gravatars.</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257312011-02-28T16:18:47ZTerence Mill
<ul></ul><p>Etienne Massip wrote:</p>
<blockquote>
<p>You can just disable gravatars.</p>
</blockquote>
<p>I noticed that on some projects it working and on other not.<br />I am not 100% sure, but the difference seems to be that the projects it is working are "leaf" projects, mean there are no sub projects<br />And it looks like as the parent projects is call gant chart, don't have "own issues but only issues come from child projects.<br />Does that maybe help to track down the problem?</p>
<p>I am using Wavatars, bou do you mean diabled the user pictures completly?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257322011-02-28T16:27:13ZEtienne Massip
<ul></ul><p>Could you try replacing the<br /><pre><code class="ruby syntaxhl"><span class="k">return</span> <span class="n">gravatar</span><span class="p">(</span><span class="n">email</span><span class="p">.</span><span class="nf">to_s</span><span class="p">.</span><span class="nf">downcase</span><span class="p">,</span> <span class="n">options</span><span class="p">)</span> <span class="k">unless</span> <span class="n">email</span><span class="p">.</span><span class="nf">blank?</span> <span class="k">rescue</span> <span class="kp">nil</span></code><br /></pre><br />with<br /><pre><code class="ruby syntaxhl"><span class="k">return</span> <span class="n">gravatar</span><span class="p">(</span><span class="n">email</span><span class="p">.</span><span class="nf">to_s</span><span class="p">.</span><span class="nf">downcase</span><span class="p">,</span> <span class="n">options</span><span class="p">)</span> <span class="o">||</span> <span class="s1">''</span> <span class="k">unless</span> <span class="n">email</span><span class="p">.</span><span class="nf">blank?</span> <span class="k">rescue</span> <span class="kp">nil</span></code><br /></pre><br />?</p>
<p>And yes, I meant that (only if you want to show the Gantt).</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257352011-02-28T17:04:10ZTerence Mill
<ul></ul><p>Doesn't change things better :(</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257362011-02-28T17:07:03ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>ApplicationHelper#avatar may return nil, empty string or whatever so this patch should be an easy fix:</p>
<pre>
Index: lib/redmine/helpers/gantt.rb
===================================================================
--- lib/redmine/helpers/gantt.rb (revision 4949)
+++ lib/redmine/helpers/gantt.rb (working copy)
@@ -353,7 +353,7 @@
subject = "<span class='#{css_classes}'>"
if issue.assigned_to.present?
assigned_string = l(:field_assigned_to) + ": " + issue.assigned_to.name
- subject << view.avatar(issue.assigned_to, :class => 'gravatar icon-gravatar', :size => 10, :title => assigned_string)
+ subject << view.avatar(issue.assigned_to, :class => 'gravatar icon-gravatar', :size => 10, :title => assigned_string).to_s
end
subject << view.link_to_issue(issue)
subject << '</span>'
</pre>
<p>Do not forget to restart.</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257372011-02-28T17:10:50ZEtienne Massip
<ul></ul><p>God damn it !</p>
<p>The only way it can return nil is either because an exception has been raised by <code>gravatar(...)</code> or because <code>gravatar(...)</code> itself returns nil, and we just checked both, didn't we ?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257382011-02-28T17:14:35ZTerence Mill
<ul></ul><p>Terence Mill wrote:</p>
<blockquote>
<p>Doesn't change things better :(</p>
</blockquote>
<p>BTW. From my point of view this BUG has at least priotity <strong>high</strong>!</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257392011-02-28T17:16:08ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Do you mean you still have the error? Can you give the exact version or branch/revision you're using?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257402011-02-28T17:17:25ZEtienne Massip
<ul></ul><p>What plugins are you actually running with ?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257412011-02-28T17:18:34ZTerence Mill
<ul></ul><p>Terence Mill wrote:</p>
<blockquote>
<p>Terence Mill wrote:</p>
<blockquote>
<p>Doesn't change things better :(</p>
</blockquote>
<p>BTW. From my point of view this BUG has at least priotity <strong>high</strong>!</p>
</blockquote>
<p>I made some more tests and the theory that it is <strong>not</strong> working for parents, does not hold, because i also found some procejts, it is working. I activated same modules on parent projects it is not working as on that ones it is working, but that doesn't change things.<br />I also tested the threory that the project itself but at least on issue (in any tracker) to work around, but this doesn not hold also.</p>
<p>I can check other test cases if you tell me..</p>
<p>Hopefully this bug will be solved soon, because</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257422011-02-28T17:25:33ZTerence Mill
<ul></ul><p>Jean-Philippe Lang wrote:</p>
<blockquote>
<p>ApplicationHelper#avatar may return nil, empty string or whatever so this patch should be an easy fix:</p>
<p>[...]</p>
<p>Do not forget to restart.</p>
</blockquote>
<p>You won the prize! Fix seems to work ..</p>
<p>Thank our so much ;)</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257432011-02-28T17:31:05ZTerence Mill
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>Assignee</strong> set to <i>Jean-Philippe Lang</i></li></ul> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257442011-02-28T17:47:38ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Target version</strong> set to <i>1.1.2</i></li></ul> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257462011-02-28T18:08:44ZEtienne Massip
<ul></ul><p>Doesn't this fix have any effect on issue subject icon rendering ?</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257472011-02-28T18:09:31ZEtienne Massip
<ul><li><strong>Subject</strong> changed from <i>Gantt tab gives internal error.</i> to <i>Gantt tab gives internal error due to nil avatar icon</i></li></ul> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257502011-02-28T20:25:56ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Resolution</strong> set to <i>Fixed</i></li></ul><p>Fix committed in <a class="changeset" title="Stringify avatar to prevent "can't convert nil into String" errors on gantt (#7317)." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4968">r4968</a>.</p>
<p>Etienne Massip wrote:</p>
<blockquote>
<p>Doesn't this fix have any effect on issue subject icon rendering ?</p>
</blockquote>
<p>It certainly does. But I'm not sure it's worth to handle it.</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=257512011-02-28T20:30:25ZJean-Philippe Langjp_lang@yahoo.fr
<ul></ul><p>Merged in 1.1-stable in <a class="changeset" title="Merged r4968 from trunk." href="https://www.redmine.org/projects/redmine/repository/svn/revisions/4969">r4969</a>.</p> Redmine - Defect #7317: Gantt tab gives internal error due to nil avatar iconhttps://www.redmine.org/issues/7317?journal_id=259832011-03-06T12:53:28ZJean-Philippe Langjp_lang@yahoo.fr
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>